Re: [trill] Shepherd's review of draft-ietf-trill-loss-delay

Tal Mizrahi <talmi@marvell.com> Thu, 29 May 2014 18:01 UTC

Return-Path: <talmi@marvell.com>
X-Original-To: trill@ietfa.amsl.com
Delivered-To: trill@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 758FE1A0164 for <trill@ietfa.amsl.com>; Thu, 29 May 2014 11:01:55 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.267
X-Spam-Level:
X-Spam-Status: No, score=-2.267 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, IP_NOT_FRIENDLY=0.334, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kfBlaK8Pd8Yq for <trill@ietfa.amsl.com>; Thu, 29 May 2014 11:01:53 -0700 (PDT)
Received: from mx0a-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B502A1A016D for <trill@ietf.org>; Thu, 29 May 2014 11:01:53 -0700 (PDT)
Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.14.5/8.14.5) with SMTP id s4TI1mK6006052; Thu, 29 May 2014 11:01:48 -0700
Received: from sc-owa04.marvell.com ([199.233.58.150]) by mx0a-0016f401.pphosted.com with ESMTP id 1m55y36a9q-1 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Thu, 29 May 2014 11:01:48 -0700
Received: from YK-HUB02.marvell.com (10.4.102.52) by SC-OWA04.marvell.com (10.93.76.33) with Microsoft SMTP Server (TLS) id 8.3.327.1; Thu, 29 May 2014 11:01:48 -0700
Received: from IL-MB01.marvell.com ([10.4.102.53]) by YK-HUB02.marvell.com ([10.4.102.52]) with mapi; Thu, 29 May 2014 21:01:45 +0300
From: Tal Mizrahi <talmi@marvell.com>
To: Susan Hares <shares@ndzh.com>, 'Donald Eastlake' <d3e3e3@gmail.com>
Date: Thu, 29 May 2014 21:01:44 +0300
Thread-Topic: [trill] Shepherd's review of draft-ietf-trill-loss-delay
Thread-Index: AQHSZ7EyT6EveJweaWumkLBv9lSqqQHzqYJbm0BRBECAAb628A==
Message-ID: <74470498B659FA4687F0B0018C19A89C01E731C2F4AF@IL-MB01.marvell.com>
References: <005301cf7a01$8f2ed200$ad8c7600$@ndzh.com> <CAF4+nEGMc5dCtihe7BSC4pM4-aq9fjd6w0qZwPKkr3uSf5xJvg@mail.gmail.com> <000301cf7a5f$9ba0eb50$d2e2c1f0$@ndzh.com>
In-Reply-To: <000301cf7a5f$9ba0eb50$d2e2c1f0$@ndzh.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.11.96, 1.0.14, 0.0.0000 definitions=2014-05-29_06:2014-05-29,2014-05-29,1970-01-01 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1402240000 definitions=main-1405290215
Archived-At: http://mailarchive.ietf.org/arch/msg/trill/iGLr6OllLFq_oJ9L_zmnqGZDtY4
Cc: "draft-ietf-trill-loss-delay@tools.ietf.org" <draft-ietf-trill-loss-delay@tools.ietf.org>, 'Jon Hudson' <jon.hudson@gmail.com>, "trill@ietf.org" <trill@ietf.org>
Subject: Re: [trill] Shepherd's review of draft-ietf-trill-loss-delay
X-BeenThere: trill@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "Developing a hybrid router/bridge." <trill.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/trill>, <mailto:trill-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/trill/>
List-Post: <mailto:trill@ietf.org>
List-Help: <mailto:trill-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/trill>, <mailto:trill-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 29 May 2014 18:01:55 -0000

Sue,

Thanks for the comments.
I posted an updated draft that addresses these comments.
http://tools.ietf.org/html/draft-ietf-trill-loss-delay-04

Thanks,
Tal.


-----Original Message-----
From: trill [mailto:trill-bounces@ietf.org] On Behalf Of Susan Hares
Sent: Wednesday, May 28, 2014 1:29 PM
To: 'Donald Eastlake'
Cc: draft-ietf-trill-loss-delay@tools.ietf.org; trill@ietf.org; 'Jon Hudson'
Subject: Re: [trill] Shepherd's review of draft-ietf-trill-loss-delay

Donald:

I agree that the normative reference [OAM-FRAMEWK] (now [RFC7174]) can be changed to an informative reference, which would avoid the down reference.

On the textual "4.4.1 ", if it is easier - let the RFC Editor fix the final form.  I will note the RFC editor should watch for it, and remove the editorial comment for the authors. 

On the IANA suggestion,  I agree that IANA should not have control over the registries that IEEE 802.1 has. The question is whether IANA should track the non-IETF specifications that IETF drafts includes.  Unless someone objects, I will remove this comment from the shepherds report. 

I'll see if anyone else has comments on the shepherds report today until 3pm ET, and then change it. 

Sue             

-----Original Message-----
From: trill [mailto:trill-bounces@ietf.org] On Behalf Of Donald Eastlake
Sent: Tuesday, May 27, 2014 11:40 PM
To: Susan Hares
Cc: draft-ietf-trill-loss-delay@tools.ietf.org; Jon Hudson; trill@ietf.org
Subject: Re: [trill] Shepherd's review of draft-ietf-trill-loss-delay

Hi Sue,

Thanks for the Shepherd review.

On Tue, May 27, 2014 at 7:15 PM, Susan Hares <shares@ndzh.com> wrote:
> Authors and TRILL WG:
>
>
> I submit for the authors and WG's review attached review of the 
> draft-ietf-trill-loss-delay-03.txt
>
>
> Sue Hares
> -----
>
>
> Document Quality
>
>
> The written text of this document is high.  The performance monitoring 
> issues clearly specified with clear descriptions of the mechanisms.
>  This document is a pleasure to read with only 3 editorial issues 
> mentioned Below, and one IANA suggestion.

Thanks.

>  The document has been co-authors by two groups implementing the  code 
> for deployment (Cisco and Huawei).  The careful attention to
> operational issues have shows in this draft.   No specific announcement
> of the release date for  these TRILL PM implementations has been made.  
> An implementation survey planned for June so a better understanding of 
> the deployments may align with the IESG review.
>  Other vendors have indicated consideration of the PM specification.
>
>
> Required Editorial Fixes [May be deleted if authors revise] =====
>
>
> draft-to-RFC updated needed:
>
>
> 1) Outdated reference: draft-ietf-trill-oam-framework has been
>      published as RFC 7174
>
> 2) Outdated reference: draft-ietf-trill-fine-labeling has been 
> published as RFC 7172

Yes, these need to be updated.

> -------
>
> downref: Normative reference to informational draft
>
>
>      draft-ietf-trill-oam-framework (ref. 'OAM-FRAMEWK')
>
>
> As a shepherd, I find this to be correct technically.  However, WG 
> chairs/AD should review this down ref.

I'm not sure. There is a lot of interesting background in the framework document, but do you actually have to look at it to implement this draft? The closest I can find to that is the following text in the draft:

      This document does not define procedures for packet loss
      computation based on counting user data. For further details see
      [OAM-FRAMEWK].

This sort of looke like a normative reference but really, I think it should be changed to something like

      This document does not define procedures for packet loss
      computation based on counting user data for the reasons given in
      Section 5.1 of [RFC7174].

So, unless I'm missing something, I think the normative reference to [OAM-FRAMEWK] (now [RFC7174]) can be changed to an informative reference, which would avoid the down reference.

> Suggested Technical changes
>
> [pages 24-25: Is the reserved field zero? If so, please indicate.
> If not, please indicate that it is unspecified.
>
> Editorial:
>
> "4.1.1 ,"  to "4.4.1,"
> [this seems to be an artifact of the word processing]

I'm slightly confused. There seem to be two occurrences of "4.1.1" but neither looks like that and there seem to be zero occurrences of "4.4.1"...  Near the beginning of Section 4.1.1 there is a "3.2.1.  ,"
(with two spaces).  Typically I think that sort of thing is due to weirdness with MS Word adding a space. It may be hard to fix if the original is in that form, but the RFC Editor can clear such stuff up.

> -----
>
> IANA suggestion:
>
> It may be worth considering if IANA should keep a record assignments 
> of the
> Y.1731 defined in 6.4.  This will be useful if there is ISO/IETF 
> collaboration discussion.

IANA registries for the OpCodes and TLV Types values that are available for IETF assignment are being set up by draft-eastlake-iana-cfm-considerations which is currently in IESG ballot. However, this draft doesn't need to allocat any additional values. IEEE 802.1 is in charge of these code points and has allocated blocks to ITU-T, for Y.1731, and to IETF for TRILL and other IETF uses.  I'm not sure that IANA having informative duplicative of code points in this space that are not on IANA control is such a good idea.

Thanks,
Donald
=============================
 Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
 155 Beaver Street, Milford, MA 01757 USA  d3e3e3@gmail.com

> Sue Hares

_______________________________________________
trill mailing list
trill@ietf.org
https://www.ietf.org/mailman/listinfo/trill

_______________________________________________
trill mailing list
trill@ietf.org
https://www.ietf.org/mailman/listinfo/trill