[trill] draft-ietf-trill-ia-appsubtlv-05.txt - Shepherd's review
"Susan Hares" <shares@ndzh.com> Fri, 02 October 2015 21:12 UTC
Return-Path: <shares@ndzh.com>
X-Original-To: trill@ietfa.amsl.com
Delivered-To: trill@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 62A571B2E9A for <trill@ietfa.amsl.com>; Fri, 2 Oct 2015 14:12:40 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -99.054
X-Spam-Level:
X-Spam-Status: No, score=-99.054 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DOS_OUTLOOK_TO_MX=2.845, HTML_MESSAGE=0.001, USER_IN_WHITELIST=-100] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SJSdikvg5kxZ for <trill@ietfa.amsl.com>; Fri, 2 Oct 2015 14:12:37 -0700 (PDT)
Received: from hickoryhill-consulting.com (hhc-web3.hickoryhill-consulting.com [64.9.205.143]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EE6DE1B2E99 for <trill@ietf.org>; Fri, 2 Oct 2015 14:12:36 -0700 (PDT)
X-Default-Received-SPF: pass (skip=loggedin (res=PASS)) x-ip-name=184.157.84.146;
From: Susan Hares <shares@ndzh.com>
To: trill@ietf.org
Date: Fri, 02 Oct 2015 17:12:29 -0400
Message-ID: <00a801d0fd57$0c2c5b40$248511c0$@ndzh.com>
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="----=_NextPart_000_00A9_01D0FD35.851F4F20"
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AdD9VvyjrOjY2f59TeWKgSYbNiSBDg==
Content-Language: en-us
X-Authenticated-User: skh@ndzh.com
Archived-At: <http://mailarchive.ietf.org/arch/msg/trill/iyf33lhNfYZHdhAVOYLMFeI0aWg>
Cc: 'Donald Eastlake' <d3e3e3@gmail.com>, trill-chairs@tools.ietf.org, 'Jon Hudson' <jon.hudson@gmail.com>
Subject: [trill] draft-ietf-trill-ia-appsubtlv-05.txt - Shepherd's review
X-BeenThere: trill@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "Developing a hybrid router/bridge." <trill.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/trill>, <mailto:trill-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/trill/>
List-Post: <mailto:trill@ietf.org>
List-Help: <mailto:trill-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/trill>, <mailto:trill-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Oct 2015 21:12:40 -0000
Shepherd's review: draft-ietf-trill-ia-appsubtlv-05 Authors: Donald Eastlake and Yizhou Li Status: Major concern on complexity of AFN template concepts. This concern has been expressed to authors who will revise the draft. The text for the AFN Template is covered in Section 2 and section 3. Note: IANA previewed section 5, and agreed to it. Minor Technical issues: none Editorial issues #1 Abstract: Current This document specifies a TRILL (Transparent Interconnection of Lots of Links) IS-IS application sub-TLV that enables the reporting by a TRILL switch of sets of addresses such that all of the addresses in each set designate the same interface (port) and the reporting for such a set of the TRILL switch by which it is reachable. New suggested: This document specifies a TRILL (Transparent Interconnection of Lots of Links) IS-IS application sub-TLV that enables the reporting by a TRILL switch of sets of addresses. Each set of addresses reports addresses the same interface (port) and the TRILL switch by which it reachable. #2 - Section 2 - paragraph 1 p. 5 Please enumerate or point to where the enumeration of the types of addresses. #3 Section 2 - page 6 Current: Addr Sets End: The unsigned integer offset of the byte, within the IA APPsub-TLV value part, of the last byte of the last Address Set. This will be the byte just before the first sub-sub-TLV if any sub-sub-TLVs are present (see Section 3). If this is equal to Length, there are no sub-sub-TLVs. If this is greater than Length or points to before the end of the Template, the IA APPsub-TLV is corrupt and MUST be discarded. This field is always two bytes in size. New Addr Sets End: The unsigned integer offset of the byte, within the IA APPsub-TLV value part, of the last byte of the last Address Set. This byte will be the byte just before the first sub-sub-TLV if any sub-sub-TLVs are present (see Section 3). The processing is as follows: . If this is equal to Length, there are no sub-sub-TLVs. . If this is greater than Length or points to before the end of the Template, the IA APPsub-TLV is corrupt and MUST be discarded. . Note: This field is always two bytes in size. #3 - page 7 paragraph 3 N: Notify flag: When a TRILL switch receives a new IA APPsub- TLV (one in an ESADI-LSP fragment with a higher sequence number or a new message of some other type) and the N bit is one, the TRILL switch then checks the contents of the APPsub-TLV for address sets including both an IP address and a MAC address. For each such address set it finds, a gratuitous ARP [RFC826] or spontaneous Neighbor Advertisement [RFC4861], depending on whether the IP address is IPv4 or IPv6 respectively, may be sent. In both cases, these are sent out all the ports of the TRILL switch offering end station service and are in the VLAN or FGL of the address set information, that is, are Appointed Forwarder for the VLAN or for the VLAN to which the FGL maps. What needs changing: Old: /and are in the VLAN or FGL of/ New: /which are in the VLAN or FGL of/ - I believe the dependent "which" clause is more appropriate here.
- [trill] draft-ietf-trill-ia-appsubtlv-05.txt - Sh… Susan Hares
- Re: [trill] draft-ietf-trill-ia-appsubtlv-05.txt … Donald Eastlake
- Re: [trill] draft-ietf-trill-ia-appsubtlv-05.txt … Susan Hares