Re: [trill] Genart telechat review of draft-ietf-trill-smart-endnodes-08

"Susan Hares" <shares@ndzh.com> Tue, 27 February 2018 23:01 UTC

Return-Path: <shares@ndzh.com>
X-Original-To: trill@ietfa.amsl.com
Delivered-To: trill@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 23F5012E8CB; Tue, 27 Feb 2018 15:01:09 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.946
X-Spam-Level:
X-Spam-Status: No, score=0.946 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DOS_OUTLOOK_TO_MX=2.845, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EGSLZZ7wmNyY; Tue, 27 Feb 2018 15:01:07 -0800 (PST)
Received: from hickoryhill-consulting.com (50-245-122-97-static.hfc.comcastbusiness.net [50.245.122.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E866812E8C8; Tue, 27 Feb 2018 15:01:03 -0800 (PST)
X-Default-Received-SPF: pass (skip=loggedin (res=PASS)) x-ip-name=166.176.251.46;
From: "Susan Hares" <shares@ndzh.com>
To: "'Robert Sparks'" <rjsparks@nostrum.com>, <gen-art@ietf.org>
Cc: <ietf@ietf.org>, <draft-ietf-trill-smart-endnodes.all@ietf.org>, <trill@ietf.org>
References: <151976308758.28489.12406772916405932448@ietfa.amsl.com>
In-Reply-To: <151976308758.28489.12406772916405932448@ietfa.amsl.com>
Date: Tue, 27 Feb 2018 18:00:58 -0500
Message-ID: <008c01d3b01e$d55d8620$80189260$@ndzh.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AQE5Ku0ELzOLO9TA7gXOCj8SO4KyCaTt5Tng
Content-Language: en-us
X-Authenticated-User: skh@ndzh.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/trill/kyIAqM2Fd7PdrzQHylU2dAypqXQ>
Subject: Re: [trill] Genart telechat review of draft-ietf-trill-smart-endnodes-08
X-BeenThere: trill@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Developing a hybrid router/bridge." <trill.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/trill>, <mailto:trill-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/trill/>
List-Post: <mailto:trill@ietf.org>
List-Help: <mailto:trill-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/trill>, <mailto:trill-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Feb 2018 23:01:09 -0000

Robert: 

Thank you for the review and a big thanks for catching the "F" Bit issue  in
section 4.3.   I apologize for letting that slip through my shepherd filter.
I suspect I've been reading this draft so often, that I'm starting to miss
the obvious. 

Your point is valid about expanding the security considerations.   I'll
check in with Fangwei, Donald, and other co-authors to spin a revision to
address your points. 

I'm glad you read through this draft as GEN-ART reviewer. 

Cheerily, Sue 


-----Original Message-----
From: trill [mailto:trill-bounces@ietf.org] On Behalf Of Robert Sparks
Sent: Tuesday, February 27, 2018 3:25 PM
To: gen-art@ietf.org
Cc: ietf@ietf.org; draft-ietf-trill-smart-endnodes.all@ietf.org;
trill@ietf.org
Subject: [trill] Genart telechat review of
draft-ietf-trill-smart-endnodes-08

Reviewer: Robert Sparks
Review result: Ready with Issues

I am the assigned Gen-ART reviewer for this draft. The General Area Review
Team (Gen-ART) reviews all IETF documents being processed by the IESG for
the IETF Chair. Please wait for direction from your document shepherd or AD
before posting a new version of the draft.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>;.

Document: draft-ietf-trill-smart-endnodes-08
Reviewer: Robert Sparks
Review Date: 2018-02-27
IETF LC End Date: 2018-03-06
IESG Telechat date: 2018-03-08

Summary: Ready with issues

Major issues

1) In section 4.3 the bullet describing the F bit does not parse. There are
two instances of "Otherwise" that do not work together.

2) All of section 4.3 is confusing as to what the length of the TLV really
is.
Row 3 in the diagram says 2 bytes or 4 bytes, but the number of bits called
out in bullets 4 and 5 below it don't seem to add up to those things. Maybe
it would be better to draw a diagram with F=0 and a separate diagram with
F=1

3) I think the security considerations section should call out again what an
RB should do if it gets message that looks like it's from a SE, containing
the right nickname, but the RB hasn't done the right Smart-Hello handshaking
with that SE already. What would keep a lazy implementation (or one driven
by product managers picking and choosing features) from just forwarding a
message from a malicious element that just happened to know the RB's
nickname?

Nits

Terminology: The definition of Transit RBridge says it's also named as a
Transit Rbridge?


_______________________________________________
trill mailing list
trill@ietf.org
https://www.ietf.org/mailman/listinfo/trill