Re: [trill] WG Last Call - draft-ietf-trill-oam-fm

Hi Donald

Thanks for the comments will follow through and update the draft accordingly.

Thanks
Tissa

-----Original Message-----
From: trill [mailto:trill-bounces@ietf.org] On Behalf Of Donald Eastlake
Sent: Friday, March 14, 2014 12:18 AM
To: trill@ietf.org
Subject: Re: [trill] WG Last Call - draft-ietf-trill-oam-fm

I did a careful review of the draft and have the following suggestions:

Section 3: This section correctly says that the TRILL Ethertype is really part of the link header on Ethernet links; however, that means that the length of the basic TRILL header is 6 bytes, not 8 bytes. So "8" should be changed to "6" in Figure 1 and in the text on the TRILL Header below that figure.

Section 3.3 at the end, looks like a "B" and an "F" got swapped. I think OLD
   Capability flags "A" and "B" are defined by [rfc6326bis] and
   [rfcFGL]. "O" and "F" Flags are located after "F" flag in the NEW
   Capability flags "A" and "F" are defined by [rfc6326bis] and
   [rfcFGL]. "O" and "B" Flags are located after "F" flag in the

Section 4.3.2: Most of 4.3 looks reasonable but the 2nd top level bullet in 4.3.2 seems to specify that OAM frames be egressed and any other TRILL Data frame addressed to the local nickname be discarded.
Maybe I'm confused, but what about regular user data...

Section 4.4: I think a two instances where it says "If MEP or MIP is configured on the Inner.VLAN ..." should says "If MEP or MIP is configured on the inner VLAN/FGL ..."

Section 4.4:  At one point it says "Non OAM l Packet". Perhaps that should just be " Non-OAM Packet"

Section 8.4.2: Add one more line to the list of TLV types:
    TBDk         Authentication TLV

Minor Editorial/Typos:

Section 3.2: "RFC6325" should be "[RFC6325]" although "RFC 6325" would also be OK.

Section 3.3: Just before the Section 4 header, missing "is". Should say
   Usage of "O" and "B" bits flags is discussed above.

Section 8.4.13: top of page 36, "in which case he process" -> "in which case the process"
                         "using the Key ID space as" -> "using the same Key ID space as"

Section 11.1: At end, "the Opcodes used is." -> "the Opcode used is TBD4."

Section A.2: "RBrdige" -> "RBridge"

Appendix B: A comment in multiple square brackets that is no longer true got left in and should be deleted.

Appendix B: "shirt" -> "short"

Thanks,
Donald
=============================
 Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
 155 Beaver Street, Milford, MA 01757 USA  d3e3e3@gmail.com

On Fri, Mar 7, 2014 at 1:30 PM, Donald Eastlake <d3e3e3@gmail.com> wrote:
> Hi,
>
> As announced at the TRILL WG meeting today, this starts a WG Last Call 
> on draft-ietf-trill-oam-fm-02.txt running through March 24th.
>
> Thanks,
> Donald and Jon

_______________________________________________
trill mailing list
trill@ietf.org
https://www.ietf.org/mailman/listinfo/trill