[Tsv-art] Tsvart last call review of draft-ietf-tram-turnbis-25

Joseph Touch via Datatracker <noreply@ietf.org> Wed, 05 June 2019 06:04 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: tsv-art@ietf.org
Delivered-To: tsv-art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id DF25B12003E; Tue, 4 Jun 2019 23:04:03 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Joseph Touch via Datatracker <noreply@ietf.org>
To: <tsv-art@ietf.org>
Cc: draft-ietf-tram-turnbis.all@ietf.org, ietf@ietf.org, tram@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.97.0
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Joseph Touch <touch@strayalpha.com>
Message-ID: <155971464360.28104.6837263931145163343@ietfa.amsl.com>
Date: Tue, 04 Jun 2019 23:04:03 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/tsv-art/1-MOnTmZwspZChNuyJ7tnPjEnrw>
Subject: [Tsv-art] Tsvart last call review of draft-ietf-tram-turnbis-25
X-BeenThere: tsv-art@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Transport Area Review Team <tsv-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tsv-art/>
List-Post: <mailto:tsv-art@ietf.org>
List-Help: <mailto:tsv-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Jun 2019 06:04:05 -0000

Reviewer: Joseph Touch
Review result: Ready with Issues

This document has been reviewed as part of the transport area review team's
ongoing effort to review key IETF documents. These comments were written
primarily for the transport area directors, but are copied to the document's
authors and WG to allow them to address any issues raised and also to the IETF
discussion list for information.

When done at the time of IETF Last Call, the authors should consider this
review as part of the last-call comments they receive. Please always CC
tsv-art@ietf.org if you reply to or forward this review.

As a preface, this review is performed focusing on the changes since RFC 5766,
as this document appears to be a fairly direct update of that content.

Transport issues:

Although this document has substantial implications for transport protocols, it
does not significantly alter the content of RFC5766 in this regard. However,
there is a significant gap as follows:

- The direct translation of TCP into UDP or UDP into TCP is arguably a host
endpoint emulation function, which strongly suggests that this document needs
to explicitly address both receiving and transmitting transport options. Even
if all received options are ignored and no options are used on transmission,
that should be more directly stated – as well as the impact of that decision,
both on functionality and security.

Sec 2.7 might also note that the support for UDP fragmentation and reassembly
could be of benefit here in avoiding IP fragmentation, but that would be
contingent on the previous note – i.e., being able to use and react to UDP
options in the translation process.

Non-transport issues:

Like RFC 5766, this doc continues to cite I-D.rosenberg-mmusic-ice-nonsip as
guidance, even using a gentle version of “must”, but this no longer seems
appropriate because that document has expired over a decade ago. Either the
guidance should be summarized in this document or the recommendation should be
removed.

Section 2.7 is incorrect in its claim of 576 for IPv4; it confuses the receiver
reassembly minimum (EMTU_R, 576) for the link MTU (EMTU_S, 68). See
draft-ietf-tunnels for details. If 576 is the focus, at best it could be
claimed that 576 is the “de-facto” EMTU_S for IPv4. Other nits:

Sec 23 indicates the changes since RFC5766; a similar section addressing
changes since RFC6156 would be useful to add.