Re: [Tsv-art] Tsvart last call review of draft-ietf-avtcore-cc-feedback-message-08

Colin Perkins <csp@csperkins.org> Thu, 17 September 2020 22:39 UTC

Return-Path: <csp@csperkins.org>
X-Original-To: tsv-art@ietfa.amsl.com
Delivered-To: tsv-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9445E3A0D69; Thu, 17 Sep 2020 15:39:23 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.1
X-Spam-Level:
X-Spam-Status: No, score=-2.1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=csperkins.org
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WfYgrpKt9TVc; Thu, 17 Sep 2020 15:39:22 -0700 (PDT)
Received: from balrog.mythic-beasts.com (balrog.mythic-beasts.com [IPv6:2a00:1098:0:82:1000:0:2:1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DB6CE3A0D66; Thu, 17 Sep 2020 15:39:21 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=csperkins.org; s=mythic-beasts-k1; h=To:Date:From:Subject; bh=UE4M4sjbIlzrtQ0SV0y5hntS+lrcoT6n4Wf5fBIb868=; b=qXn7Hq9Th4Zf6I7Df5nQu8sE9/ hw//JVrz+yUueptcc3oxV99WDWkhBWVvn55wFD9DP/2PG/wolCMB8FM6fav+iE/VsbS7QaT0JZPyh fjJlzBKhh2lufp9yUfN52s/wvs51Y92VRIXXbniPRwTcwkJ66Z8/L3wuQ1lsvtIGT/fIy3rWCfgK4 0PWRoKzfJlD+EJgBJCALAjKbCVQYcFpEYF82ykt9oDs/RodP8fkiVsMtYI6YBZZHWz+8/pSxYRlb3 sQLb18xJFbA1orrdbRUoes4pXC72tJ0Yt7d+yqG9ZvHjyU5Ih25aVB0Nf4f2tLNp8kV/s28WHkRpW DbjsDrbA==;
Received: from [81.187.2.149] (port=42530 helo=[192.168.0.67]) by balrog.mythic-beasts.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from <csp@csperkins.org>) id 1kJ2Ye-00029S-AI; Thu, 17 Sep 2020 23:39:20 +0100
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.15\))
From: Colin Perkins <csp@csperkins.org>
In-Reply-To: <159963975122.30982.6287742761908271234@ietfa.amsl.com>
Date: Thu, 17 Sep 2020 23:39:08 +0100
Cc: tsv-art@ietf.org, draft-ietf-avtcore-cc-feedback-message.all@ietf.org, last-call@ietf.org, avt@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <BA317277-8D77-476B-9B69-F59EA1E5066D@csperkins.org>
References: <159963975122.30982.6287742761908271234@ietfa.amsl.com>
To: Michael Scharf <michael.scharf@hs-esslingen.de>
X-Mailer: Apple Mail (2.3445.104.15)
X-BlackCat-Spam-Score: 4
Archived-At: <https://mailarchive.ietf.org/arch/msg/tsv-art/CUJS6FcvcZz8reObdr6gvgNfLO8>
Subject: Re: [Tsv-art] Tsvart last call review of draft-ietf-avtcore-cc-feedback-message-08
X-BeenThere: tsv-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Transport Area Review Team <tsv-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tsv-art/>
List-Post: <mailto:tsv-art@ietf.org>
List-Help: <mailto:tsv-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Sep 2020 22:39:24 -0000

Hi Michael,

> On 9 Sep 2020, at 09:22, Michael Scharf via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Michael Scharf
> Review result: Ready with Issues
> 
> This document has been reviewed as part of the transport area review team's
> ongoing effort to review key IETF documents. These comments were written
> primarily for the transport area directors, but are copied to the document's
> authors and WG to allow them to address any issues raised and also to the IETF
> discussion list for information.
> 
> When done at the time of IETF Last Call, the authors should consider this
> review as part of the last-call comments they receive. Please always CC
> tsv-art@ietf.org if you reply to or forward this review.
> 
> Major issues
> -------------
> 
> None
> 
> Minor issues
> -------------
> 
> 1/ Section 5:
> 
>   All RTP congestion control algorithms MUST specify how they
>   respond to the loss of feedback packets.
> 
> This is a process-related requirement not relevant for interoperability of
> implementations. In addition, the requirement is not very specific (What would
> have to be specified?). I am not sure if such a requirement in capital letters
> is really needed here. This should be handled consistently in all IETF
> documents.

Happy to change this to “need to specify”, but I also think “MUST” is appropriate. RTCP congestion control feedback packets can carry information about a larger number of data packets than is typical for, e.g., TCP ACKs, so it might be considered more critical that response to loss of feedback is defined.

> 2/ Section 11:
> 
> The Security Considerations do not discuss off-path attacks, and it is not
> clear why this case is missing. Can an off-path attacker trick the sender into
> sending at either an excessively high or excessively low rate?

An off-path attacker can’t modify RTCP congestion control feedback, but they could potentially spoof such packets. The fix is the same: use Secure RTP to authenticate. Will clarify.

> Nits
> ----
> 
> 1/ Abstract:
> 
> The protocol extension enables fine-grained feedback on per-packet reception
> quality. The rationale is provided in Section 1 and (more comprehensively) in
> Section 8. Yet, I wonder if this objective could also be made a bit more
> explicit in the abstract, e.g., along the lines of the "fine-grained feedback"
> wording in the first paragraph of Section 8.

Sure, seems reasonable.

> 2/ Section 7:
> 
> Typo in "a=ecn-capaable-rtp:”

Will fix.



-- 
Colin Perkins
https://csperkins.org/