[Tsv-art] Tsvart early review of draft-ietf-opsawg-tsvwg-udp-ipfix-03

Tommy Pauly via Datatracker <noreply@ietf.org> Tue, 02 January 2024 17:07 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: tsv-art@ietf.org
Delivered-To: tsv-art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id EEFEDC14F74A; Tue, 2 Jan 2024 09:07:39 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Tommy Pauly via Datatracker <noreply@ietf.org>
To: tsv-art@ietf.org
Cc: draft-ietf-opsawg-tsvwg-udp-ipfix.all@ietf.org, opsawg@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 12.1.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <170421525995.16166.10968274423251140899@ietfa.amsl.com>
Reply-To: Tommy Pauly <tpauly@apple.com>
Date: Tue, 02 Jan 2024 09:07:39 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/tsv-art/Dz9T8NbgpbrDcOXYZN6uYCgMJuM>
Subject: [Tsv-art] Tsvart early review of draft-ietf-opsawg-tsvwg-udp-ipfix-03
X-BeenThere: tsv-art@ietf.org
X-Mailman-Version: 2.1.39
List-Id: Transport Area Review Team <tsv-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tsv-art/>
List-Post: <mailto:tsv-art@ietf.org>
List-Help: <mailto:tsv-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Jan 2024 17:07:40 -0000

Reviewer: Tommy Pauly
Review result: Almost Ready

Thanks for writing a clear and succinct draft. I only found one issue of note,
around the registration of the new udpOptions Information Element.

Section 4.1:
The data type used for the “udpOptions” entry is just listed as “unsigned”, and
is described as being either an unsigned32 or an unsigned64. However, when I
look at the registry at https://www.iana.org/assignments/ipfix/ipfix.xhtml, I
don’t see any entries that use this abstract “unsigned” type, and it is not
listed as an option in the element data types. Is there a reason this shouldn’t
just be registered as an unsigned64? My understanding from
https://www.rfc-editor.org/rfc/rfc7011#section-6.2 is that an unsigned64 can be
automatically encoded as an unsigned32 if the value is small enough, so the
definition can just use unsigned64.