[Tsv-art] Tsvart last call review of draft-ietf-ipsecme-multi-sa-performance-06
Marcus Ihlar via Datatracker <noreply@ietf.org> Wed, 10 April 2024 09:06 UTC
Return-Path: <noreply@ietf.org>
X-Original-To: tsv-art@ietf.org
Delivered-To: tsv-art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id DF6B3C151068; Wed, 10 Apr 2024 02:06:50 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Marcus Ihlar via Datatracker <noreply@ietf.org>
To: tsv-art@ietf.org
Cc: draft-ietf-ipsecme-multi-sa-performance.all@ietf.org, ipsec@ietf.org, last-call@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 12.9.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <171274001090.2420.10816994295519414610@ietfa.amsl.com>
Reply-To: Marcus Ihlar <marcus.ihlar@ericsson.com>
Date: Wed, 10 Apr 2024 02:06:50 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/tsv-art/SojffZ1Eq2q1ML9PpPBk0Xfi544>
Subject: [Tsv-art] Tsvart last call review of draft-ietf-ipsecme-multi-sa-performance-06
X-BeenThere: tsv-art@ietf.org
X-Mailman-Version: 2.1.39
List-Id: Transport Area Review Team <tsv-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tsv-art/>
List-Post: <mailto:tsv-art@ietf.org>
List-Help: <mailto:tsv-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Apr 2024 09:06:51 -0000
Reviewer: Marcus Ihlar Review result: Ready with Issues This document has been reviewed as part of the transport area review team's ongoing effort to review key IETF documents. These comments were written primarily for the transport area directors, but are copied to the document's authors and WG to allow them to address any issues raised and also to the IETF discussion list for information. When done at the time of IETF Last Call, the authors should consider this review as part of the last-call comments they receive. Please always CC tsv-art@ietf.org if you reply to or forward this review. This document introduces a mechanism for establishing multiple child SAs for a single traffic selector and binding these SAs to specific resources such as CPUs. This simplifies parallel crypto processing since there is no need to synchronize state between CPUs. Overall this is a well written document with a straight forward solution to a concrete problem. Packets of a single traffic selector can be mapped to multiple Child SAs that are bound to specific resources. How individual packets are mapped to Child SAs can have consequences for end-to-end performance, for instance by introducing packet reordering and packet delay variation if packets of a single end-to-end flow are split across Child SAs. Load balancing algorithms and policies are likely best left as implementation details but I do think a paragraph in the operational considerations section could be warranted.
- [Tsv-art] Tsvart last call review of draft-ietf-i… Marcus Ihlar via Datatracker
- Re: [Tsv-art] [Last-Call] Tsvart last call review… Paul Wouters
- Re: [Tsv-art] [Last-Call] Tsvart last call review… Marcus Ihlar
- Re: [Tsv-art] [Last-Call] Tsvart last call review… Steffen Klassert