Re: [Tsv-art] Tsvart last call review of draft-ietf-detnet-mpls-over-udp-ip-06

Balázs Varga A <balazs.a.varga@ericsson.com> Thu, 01 October 2020 14:46 UTC

Return-Path: <balazs.a.varga@ericsson.com>
X-Original-To: tsv-art@ietfa.amsl.com
Delivered-To: tsv-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 293F53A10B9; Thu, 1 Oct 2020 07:46:58 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.301
X-Spam-Level:
X-Spam-Status: No, score=-3.301 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id W0q7lWU-cKrW; Thu, 1 Oct 2020 07:46:56 -0700 (PDT)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70043.outbound.protection.outlook.com [40.107.7.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6F5993A10AD; Thu, 1 Oct 2020 07:46:56 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PqHn0WFX7ZbQvKonu3AUEUHrBEnhYP7mRj45zsjUv8snEabWCeqd1QdvoWkkKCikx60ub8txq7YSfKB56ntuh9bPmuHzoYLciRXiE5Txhk48WSgM9ROq6MoOznBbq/xuBZtFhhClVEIY+JpINRw3E7yaHNsHYCDogIWGiutB8pY30wZX6qsL6huG+n6k4AS2E54NrWg20Usbctae+sltcBGmJk3HzSTJNQwaAwfjFMPVCoWocq721wKmYmFifz5c4vF4CfWLth3seOe7pQdAoYrFiQq7rDcDj54zg+ar2KoEvJ4X6Ro3OPY9dg9g16u/NIeCmNU1EPtKNPrjQBIgbw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VhzO/JZKVikPKestNyLTGpFYiMXhMAAtm8HIv6OZTJA=; b=GWoQrHwgNPjEc1Mcj/gl9VjCL4SVuxWzty7StVVFWOv1ys6xxZ9cZ3gD4UdGMaWm2UvNRM8SL6jLycZPYlLDnT04SuHPVIaBeeVjsbKNYOkCiGtGFrr62EKjDa2OQRTZ0OMbsek/gjo6WeauYwKD+uEEYlGagQmhtdbvc6LHKpjNYBRaHlHEs3DJUeRkjzUg8TioHec992xxTBgFhumxnSxewdZe4f7iscajBIU5jC9AL+c//XDL1lUCoZgTfoCRDkCs4OgIlZDowpFlK9tfDNTui+Y8/N6Rela/yRLDsERkkpoTDvFo7CPKf9euXrXqubT/BqFoQPXCYRFcRDOGDA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VhzO/JZKVikPKestNyLTGpFYiMXhMAAtm8HIv6OZTJA=; b=p0pS8b+nwGne7MIq+xaZ9Aq8DXk2GROCJTLIwzKIme9z02gNgEFEztUYqLtS2JhaM4y/3CN6qz+7sYx/9YqRSBtY9LxYxrOQ0tUl8o/eB0V9PMaSaLJ5B7PpirdpsCz8Jr6O8mTusNZRbzpd9PviV9bsXGzQRNispZHkaj2rgLw=
Received: from AM0PR0702MB3603.eurprd07.prod.outlook.com (2603:10a6:208:22::25) by AM0PR07MB4481.eurprd07.prod.outlook.com (2603:10a6:208:78::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.18; Thu, 1 Oct 2020 14:46:53 +0000
Received: from AM0PR0702MB3603.eurprd07.prod.outlook.com ([fe80::59ca:540d:b7f3:58b9]) by AM0PR0702MB3603.eurprd07.prod.outlook.com ([fe80::59ca:540d:b7f3:58b9%6]) with mapi id 15.20.3433.035; Thu, 1 Oct 2020 14:46:53 +0000
From: =?utf-8?B?QmFsw6F6cyBWYXJnYSBB?= <balazs.a.varga@ericsson.com>
To: Joerg Ott <jo@acm.org>, "tsv-art@ietf.org" <tsv-art@ietf.org>
CC: "last-call@ietf.org" <last-call@ietf.org>, "draft-ietf-detnet-mpls-over-udp-ip.all@ietf.org" <draft-ietf-detnet-mpls-over-udp-ip.all@ietf.org>, "detnet@ietf.org" <detnet@ietf.org>
Thread-Topic: Tsvart last call review of draft-ietf-detnet-mpls-over-udp-ip-06
Thread-Index: AQHWh4fjPNq7ksmbIk2SAngS3p3BLKmC7Vcg
Date: Thu, 1 Oct 2020 14:46:53 +0000
Message-ID: <AM0PR0702MB3603DB6950799E6A19CA0E30AC300@AM0PR0702MB3603.eurprd07.prod.outlook.com>
References: <159975206822.20137.12087047270168117389@ietfa.amsl.com>
In-Reply-To: <159975206822.20137.12087047270168117389@ietfa.amsl.com>
Accept-Language: hu-HU, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: acm.org; dkim=none (message not signed) header.d=none;acm.org; dmarc=none action=none header.from=ericsson.com;
x-originating-ip: [94.21.192.99]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 42219f3b-eb56-4007-bf67-08d86618d689
x-ms-traffictypediagnostic: AM0PR07MB4481:
x-microsoft-antispam-prvs: <AM0PR07MB4481486D0C6F1EAEF4638450AC300@AM0PR07MB4481.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: ZNW+Djl342q/U7W3C+W91/Hg8ERqc6Bdk4hAEh0PLrEydGrg6oDmPDW0gAbq1X3A5YFrq7vMjC485qHnNlp2PffcloBPlrr9UpUfPC9UhisCgKoGmvYp0sMJmwjcsIct6db6VFmqP64PkO0OmySAUtPW4XK2F8FKIhXQT9QZ2g0j0X9F+R8AQIfwLEhRVOz2e38XvYpN+Y2w+DnLhs1dVuCzYcixG4EHufrTyDvX1VxH1eOpizGMdu4nvPOv7Oyfa79T7j2ize9GumIkDfW/94D6NBhU4u+5njmh7Slx7pfoYwN0KAp2necVeATriw69
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR0702MB3603.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(396003)(366004)(376002)(136003)(346002)(186003)(26005)(9686003)(7696005)(6506007)(86362001)(478600001)(83380400001)(53546011)(4326008)(55016002)(76116006)(85202003)(8936002)(8676002)(52536014)(66946007)(64756008)(66556008)(2906002)(66446008)(66476007)(5660300002)(54906003)(316002)(110136005)(71200400001)(33656002)(85182001); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata: gOcXgG95RxHnmGYJbXB39SLw1dEPw2BudL/1ciyPJ8vUwUprqub5NbQ4CRnD0TX4XNLwn6AkA35Q7om755kfjfMAzJ+I++nvibTgrhQQh+rFCIJEpGjVspiFPUx3IQLZwwdvLYfVGmpFlOkk8Do5wsuxL7fDaONRMgMKYUQQT5X+JLAT2HE7IeBMEdDZJ5cpb1YSdYhlhYEHExCtvVWPJzzutH3HJf6V43JcAMkl/iFdZOXn4cQfSdbGxPN8iv9vrHuIKATGS3EwWCJhnibjAY9Vgm7dUodVMV3uEpzCGDo/J9M3d5t8JPVW4qSzpatwcVH/q2ndhFAq2DGUgoz0gUyJG95/oc4Yxa+FI3it7X2N2ehRN37Z3DsbOSfNi9JKYbSoUI8vnrxdnHTiflOZzB4QkEtoDdOlf3NIUi90mGsK89d0s0nMvM1X6az5kxc9HpkteUA66KvJfFcNdlbWVqu9Wk2nW6nKuqNxmAXyhRQC8ziTb4mrZrE4u7q3j3tNkdhnKc/37hngQJqGN+WrE0j/2setkvDxqv6BYbq45bRvmj85QnjDWtIHumMiMhkcdWKEE3jM+2CKOl4r8T9vDBi+Igzj7Mm/4PCD881gM2se6gBfU0u2X2i90IRlHmmFnV5pwsvhhKuL37HbyV9Vow==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR0702MB3603.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 42219f3b-eb56-4007-bf67-08d86618d689
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Oct 2020 14:46:53.6225 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: X3jOut4EUjX/LZk22Sd+OY5f+t6eZSG769eZEMhPPx6OWxWOiQ0ruwCJEmQNRGiX3Wm4l6ChV2+v4ZYoGGQGQTzMxxFbbdYyvKyD+ETgAgY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR07MB4481
Archived-At: <https://mailarchive.ietf.org/arch/msg/tsv-art/uX3BVWmg1HErXgl8QpEGXikU8Yg>
Subject: Re: [Tsv-art] Tsvart last call review of draft-ietf-detnet-mpls-over-udp-ip-06
X-BeenThere: tsv-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Transport Area Review Team <tsv-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tsv-art/>
List-Post: <mailto:tsv-art@ietf.org>
List-Help: <mailto:tsv-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Oct 2020 14:46:58 -0000

Hi Jörg,

Thanks for the review. Regarding your quick question:
- Yes your comment is right. In the presence of network (and port) address translation 
devices/functions it would be up to the controller plane to determine the appropriate 
addresses. Recognizing DetNet flows at the IP level is based on port/address fields.
Controller plane have to ensure that nodes after the translation are configured with 
the translate IP header fields, when recognition of DetNet flows is required.

It can be mentioned with a note (to be added at the end of section "5.  Management 
and Control Information Summary):
--- NEW TEXT
     Note: In the presence of network (and port) address translation 
     devices/functions it would be up to the controller plane to 
     determine the appropriate information to ensure proper 
     mapping at the sender/receiver.
--- END

Thanks & Cheers
Bala'zs

-----Original Message-----
From: Joerg Ott via Datatracker <noreply@ietf.org> 
Sent: Thursday, September 10, 2020 5:34 PM
To: tsv-art@ietf.org
Cc: last-call@ietf.org; draft-ietf-detnet-mpls-over-udp-ip.all@ietf.org; detnet@ietf.org
Subject: Tsvart last call review of draft-ietf-detnet-mpls-over-udp-ip-06

Reviewer: Joerg Ott
Review result: Ready

This document has been reviewed as part of the transport area review team's ongoing effort to review key IETF documents. These comments were written primarily for the transport area directors, but are copied to the document's authors and WG to allow them to address any issues raised and also to the IETF discussion list for information.

When done at the time of IETF Last Call, the authors should consider this review as part of the last-call comments they receive. Please always CC tsv-art@ietf.org if you reply to or forward this review.

The document defines the transmission and reception behaviour as well as the configuration information for encapsulating DetNet MPLS packets over UDP.
The draft provides an explicit applicability statement concerning carrying non-congestion controlled traffic.

With the latter in mind, the document seems to be complete.
(Fragmentation and reassembly seem to be already covered with MPLS-over-UDP in RFC7510 and RFC4023)

One quick question to the authors:
Section 5 provides the necessary information to be configured for flow mapping and makes reference to IP source and destination addresses. Is the presence of network (and port) address translation devices/functions covered elsewhere in the many specs to ensure proper transmission at a sender and proper reverse mapping at a receiver? It would be up to the control plane to determine the appropriate addresses. Does this need explicit mentioning?

Best,
Jörg