[Tsv-art] Tsvart last call review of draft-ietf-rtgwg-qos-model-11
Colin Perkins via Datatracker <noreply@ietf.org> Wed, 06 December 2023 19:05 UTC
Return-Path: <noreply@ietf.org>
X-Original-To: tsv-art@ietf.org
Delivered-To: tsv-art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 772BEC0900AF; Wed, 6 Dec 2023 11:05:12 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Colin Perkins via Datatracker <noreply@ietf.org>
To: tsv-art@ietf.org
Cc: draft-ietf-rtgwg-qos-model.all@ietf.org, last-call@ietf.org, rtgwg@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 11.16.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <170188951244.40572.5956395979778664215@ietfa.amsl.com>
Reply-To: Colin Perkins <csp@csperkins.org>
Date: Wed, 06 Dec 2023 11:05:12 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/tsv-art/uxvjN8nH90odVwUq6-nmflDGivU>
Subject: [Tsv-art] Tsvart last call review of draft-ietf-rtgwg-qos-model-11
X-BeenThere: tsv-art@ietf.org
X-Mailman-Version: 2.1.39
List-Id: Transport Area Review Team <tsv-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tsv-art/>
List-Post: <mailto:tsv-art@ietf.org>
List-Help: <mailto:tsv-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Dec 2023 19:05:12 -0000
Reviewer: Colin Perkins Review result: Ready with Nits This document has been reviewed as part of the transport area review team's ongoing effort to review key IETF documents. These comments were written primarily for the transport area directors, but are copied to the document's authors and WG to allow them to address any issues raised and also to the IETF discussion list for information. When done at the time of IETF Last Call, the authors should consider this review as part of the last-call comments they receive. Please always CC tsv-art@ietf.org if you reply to or forward this review. I am not an expert on YANG or DiffServ, and I have not followed the development and discussion related to this draft. This review is hence necessarily written from a generalist transport perspective. Please accept my apologies if I touch on topics that have been considered before in the working group. The draft looks to be defining mechanisms to configure the use of existing QoS mechanisms and to report on their effects. As such, any new transport protocol impact would seem limited. The mechanisms described may make it easier to deploy QoS, but the QoS techniques exist and can be used irrespective of whether this draft is published. For AQM, this draft specifies configuration parameters for RED and WRED. These AQM algorithms have certainly been widely implemented and used, but there are more modern alternatives that have been defined in IETF and that are also starting to see use (e.g., PIE – RFC 8033, and several variants on CoDel – RFC 8289/8290). Has consideration been given to whether any other AQM algorithms should be included? Is the mechanism extensible to support these and other future AQM approaches? From a transport perspective I would not recommend use of RED or WRED today, since the alternatives perform better and are harder to misconfigure. Some discussion about extensibility and alternatives would be helpful. Similarly there are only two traffic classifiers specified, which may warrant an extension point. Otherwise, this seems broadly ready. Colin
- [Tsv-art] Tsvart last call review of draft-ietf-r… Colin Perkins via Datatracker
- Re: [Tsv-art] Tsvart last call review of draft-ie… Gorry Fairhurst
- Re: [Tsv-art] Tsvart last call review of draft-ie… Yingzhen Qu
- Re: [Tsv-art] Tsvart last call review of draft-ie… Ruediger.Geib