Re: [tsvwg] Some unclear points about rfc4960 (SCTP).

[Michael Tuexen <[e-mail]>]

> On 22. Aug 2021, at 06:13, 一念之后★だ <[e-mail]> wrote:
> 
> HI,
> I am sorry for late reply. I combined the reply for several emails: 
> 
> Which version of the Linux kernel are you using (what is the output of uname -a)?
> 
> Zhouming: I test ubuntu16.04 LTS and ubuntu20.04 LTS, they both have these problems.
> 
>  uname -a
> 
> 
> Linux ubuntu 4.4.0-142-generic #168-Ubuntu SMP Wed Jan 16 21:00:45 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
> 
> # uname -a
> 
> Linux ubuntu 5.11.0-27-generic #29~20.04.1-Ubuntu SMP Wed Aug 11 15:58:17 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
> 
> NCAT version:   Ncat: Version 7.80 ( https://nmap.org/ncat )
> 
> 
> 
> ---------------
> 
> I agree that the your attached .pcap file indicates that the implementation used has the bug you are describing. I used packetdrill (from https://github.com/nplab/packetdrill) with the  attached script on a 5.11 kernel, and the attached script passes, which means that that stack does not have the problem. I'm also attaching the corresponding .pcapng file.
> 
> So it seems that this bug was fixed recently in Linux, or am I missing something?
> 
> Zhouming:  I checked the source code of 5.11 kernel, and find nothing fix about the problems we discussed. I guess maybe you missed something, I have no idea if packetdrill is suitable for this test.
OK, I spend some more time and now figured out what is going on:

* The linux kernel implementation handles the reception of an INIT chunk with 
  (1) initiate tag = 0
  (2) os = 0
  (3) mis = 0
  (4) partial chunk (chunk length >= 20, but but not enough bytes in the packet)
  (5) missing mandatory parameters (chunk length < 20, number of bytes in the packet as described by chunk length)
  in state ESTABLSHED in the same way:
  (a) It does not affect the state of the association at the endpoint receiving the INIT chunk
  (b) It sends out a packet with an ABORT chunk. The verification tag of this packet it the verification
      tag expected by the peer.

* packetdrill was not verifying the verification tag used in the outgoing packets containing the ABORT
  chunks. This is fixed now in packetdrill.

So I can confirm that Linux has a bug. It should not send a packet containing an ABORT chunk when condition (1)
is true. When sending a packet containing an ABORT chunk because it received an INIT chunk with (2), (3), (4), or
(5), it should use the initiate tag of the received INIT chunk. If that is not possible, no ABORT should be sent.

I guess we agree now on the current state of the Linux implementation. Sorry for not seeing this initially,
since I was only focussing on the endpoint receiving the INIT chunk and was happy that it stays in ESTABLISHED.
I'm also attaching a .pcapng file showing (4) and (5).
> 
> 
> 
> ---------------
> 
> > This has already been clarified in draft-ietf-tsvwg-rfc4960-bis-13.
> >
> > It states now:
> > <t>If the value of the Initiate Tag in a received INIT chunk is found to be 0,
> > the receiver MUST treat it as an error and silently discard the packet.</t>
> >
> > For OS = 0 or MIS = 0, the INIT chunk MUST be dropped and an ABORT chunk
> > SHOULD be sent. So the next revision will contain:
> >
> > <t>A receiver of an INIT chunk with the OS value set to 0 MUST discard the
> > packet and SHOULD send a packet in response containing an ABORT chunk and using
> > the Initiate Tag as the Verification Tag.
> > Any existing association MUST NOT be affected.</t>
> >
> > <t>A receiver of an INIT chunk with the MIS value set to 0 MUST discard the
> > packet and SHOULD send a packet in response containing an ABORT chunk and using
> > the Initiate Tag as the Verification Tag.
> > Any existing association MUST NOT be affected.</t>
> >
> > I guess this makes the description for the INIT chunk crystal clear.
> 
> Zhouming:  situation(2) is missing in draft-ietf-tsvwg-rfc4960-bis-13 or it no need to be clarified  ??    I have test this, an init msg with mandatory parameters not fully carried can also trigger an Abort msg to release the association.
I agree that there is a problem in the Linux implementation.

I changed the text in Section 5.1 from

OLD:
The Verification Tag field in the common header of the outbound SCTP packet containing the
ABORT chunk MUST be set to the Initiate Tag value of the peer.

NEW:
The Verification Tag field in the common header of the outbound SCTP packet
containing the ABORT chunk MUST be set to the Initiate Tag value of the
received INIT or INIT ACK chunk this ABORT chunk is responding to.</t>

I guess the makes things clearer.
> 
> ---
> 
> As can be seen from the above description, when an init message or init ACK message is received,
> 
> (1)If the init tag in the message is 0, the association must be released
> 
> (2)If the mandatory parameters in the message are not fully carried, the association must be released
> 
> 
> (3)When the OS value or MIS value in the message is 0, it is strongly recommended to release this association
> 
> 
> 
> >> Unfortunately, the SCTP implementation of Linux will be affected by the attacks described above, such as the open source lksctp.
> > Have you reported that issue? If not, I can let them know.
> 
> Zhouming:  I still do not report this issue to them, I think I need disscuss it with you first, so you can let them know about it.
OK. I think we agree now on the state? Please CC me on the mail you send to lksctp mailing
list, I can provide a packetdrill script.
> 
> -------------
> 
> > Please let me know how to write your name in ASCII to give you credit.
> 
> Zhouming:  Thanks very much,  it's a great honor，my English name is Zhouming.
OK, thank you. I have added your name to the acknowledgement section of RFC 4960bis.

Best regards
Michael

> 
> 
> 
> ------------------ 原始邮件 ------------------
> 发件人: "Michael Tuexen" <[e-mail]>;
> 发送时间: 2021年8月21日(星期六) 上午6:03
> 收件人: "一念之后★だ"<[e-mail]>;
> 抄送: "tsvwg"<[e-mail]>;"draft-ietf-tsvwg-2960bis"<[e-mail]>;
> 主题: Re: [tsvwg] Some unclear points about rfc4960 (SCTP).
> 
> > On 18. Aug 2021, at 18:46, Michael Tuexen <[e-mail]> wrote:
> > 
> >> On 17. Aug 2021, at 18:56, 一念之后★だ <[e-mail]> wrote:
> >> 
> >> Dear IETF experts，
> >> 
> >> I read rfc4960 (SCTP) and felt that there were some unclear descriptions in the document. I hope to get your reply, so I wrote this email to you. And I think it's better to describe these more clearly in the subsequent version of the RFC.
> >> The following description describes some scenarios requiring abort Association in rfc4960:
> >> Page25
> >> 
> >> 
> >> <[e-mail]>
> >> 
> >> Page26
> >> <[e-mail]>
> >> 
> >> Page30
> >> <[e-mail]>
> >> 
> >> Page31
> >> <[e-mail]>
> >> 
> >> Page56
> >> <[e-mail]>
> >> 
> >> As can be seen from the above description, when an init message or init ACK message is received,
> >> (1)If the init tag in the message is 0, the association must be released
> >> (2)If the mandatory parameters in the message are not fully carried, the association must be released
> >> (3)When the OS value or MIS value in the message is 0, it is strongly recommended to release this association
> > You are correct, using an initiate tag of 0 or limit the number of streams to 0 is not allowed.
> > 
> > Please note the in the case of an initiate tag of 0 in an INIT chunk, you can't send an ABORT
> > since you have no tag different from 0 you could use as the verification tag.
> > This has already been clarified in draft-ietf-tsvwg-rfc4960-bis-13.
> > 
> > It states now:
> > <t>If the value of the Initiate Tag in a received INIT chunk is found to be 0,
> > the receiver MUST treat it as an error and silently discard the packet.</t>
> > 
> > For OS = 0 or MIS = 0, the INIT chunk MUST be dropped and an ABORT chunk
> > SHOULD be sent. So the next revision will contain:
> > 
> > <t>A receiver of an INIT chunk with the OS value set to 0 MUST discard the
> > packet and SHOULD send a packet in response containing an ABORT chunk and using
> > the Initiate Tag as the Verification Tag.
> > Any existing association MUST NOT be affected.</t>
> > 
> > <t>A receiver of an INIT chunk with the MIS value set to 0 MUST discard the
> > packet and SHOULD send a packet in response containing an ABORT chunk and using
> > the Initiate Tag as the Verification Tag.
> > Any existing association MUST NOT be affected.</t>
> > 
> > I guess this makes the description for the INIT chunk crystal clear.
> > 
> > The situation for the INIT-ACK is different. The INIT-ACK is only processed, if
> > the verification tag in the common header was correct. In this case it is OK
> > to destroy the association. A potential attacker has to guess the 32-bit
> > verification tag and if the attacker can do this, the attacker can send a
> > packet containing an ABORT chunk.
> > However, the consistency of the text can be improved.
> Here are the suggested changes to improve the consistency of the handling
> of illegal parameters in the INIT ACK chunk:
> 
> For the Initiate Tag:
> <t>If an endpoint in the COOKIE-WAIT state receives an INIT ACK chunk with the
> Initiate Tag set to 0, it MUST destroy the TCB and SHOULD send an ABORT chunk
> with the T bit set.
> If such an INIT-ACK chunk is received in any state other than CLOSED or
> COOKIE-WAIT, it SHOULD be discarded silently
> (see <xref target='sec_unexpected_init_ack'/>).</t>
> 
> 
> For OS:
> <t>If an endpoint in the COOKIE-WAIT state receives an INIT ACK chunk with the
> OS value set to 0, it MUST destroy the TCB and SHOULD send an ABORT chunk.
> If such an INIT-ACK chunk is received in any state other than CLOSED or
> COOKIE-WAIT, it SHOULD be discarded silently
> (see <xref target='sec_unexpected_init_ack'/>).</t>
> 
> For MIS:
> <t>If an endpoint in the COOKIE-WAIT state receives an INIT ACK chunk with the
> MIS value set to 0, it MUST destroy the TCB and SHOULD send an ABORT chunk.
> If such an INIT-ACK chunk is received in any state other than CLOSED or
> COOKIE-WAIT, it SHOULD be discarded silently
> (see <xref target='sec_unexpected_init_ack'/>).</t>
> 
> Best regards
> Michael
> >> 
> >> The following description also shows that there can only be one SCTP association between two SCTP endpoints at any time:
> >> <[e-mail]>
> >> 
> >> 
> >> Because init messages can be forged arbitrarily, take the scenario where the initial tag in init message is 0 as an example.
> >> In this scenario, a malicious attacker can destroy other associations at a very low cost:
> >> <[e-mail]>
> >> 
> >> For the other two scenarios, i.e. init message with missing mandatory parameters or init message with OS value / MIS value of 0, the effect may be similar.
> >> I think from the original intention of the protocol design, these error scenarios should be handled according to the following. However, the RFC does not specify how to deal with the established association endpoint when receiving this wrong init (or init ACK) message, and whether the corresponding association should still be removed.
> > I agree. I think the suggested changes above make this crystal clear.
> >> <[e-mail]>
> >> 
> >> Unfortunately, the SCTP implementation of Linux will be affected by the attacks described above, such as the open source lksctp.
> > Have you reported that issue? If not, I can let them know.
> >> I hope to receive your reply to clarify the above unclear areas.
> >> Thank you very much.
> > Thank you very mich for reporting the issue.
> >> 
> >> Yours faithfully!
> >> Zhouming.
> > Please let me know how to write your name in ASCII to give you credit.
> > 
> > Best regards
> > Michael
> > 
>