Re: [tsvwg] Gen-art LC review: draft-ietf-tsvwg-rsvp-pcn-09

Robert Sparks <rjsparks@nostrum.com> Mon, 15 September 2014 14:58 UTC

Return-Path: <rjsparks@nostrum.com>
X-Original-To: tsvwg@ietfa.amsl.com
Delivered-To: tsvwg@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A2C1F1A036A; Mon, 15 Sep 2014 07:58:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.552
X-Spam-Level:
X-Spam-Status: No, score=-3.552 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RP_MATCHES_RCVD=-1.652] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6nTaMcgZvlvq; Mon, 15 Sep 2014 07:58:03 -0700 (PDT)
Received: from nostrum.com (raven-v6.nostrum.com [IPv6:2001:470:d:1130::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D89391A0363; Mon, 15 Sep 2014 07:58:03 -0700 (PDT)
Received: from unnumerable.local (pool-173-71-50-162.dllstx.fios.verizon.net [173.71.50.162]) (authenticated bits=0) by nostrum.com (8.14.9/8.14.7) with ESMTP id s8FEvoXG084547 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=OK); Mon, 15 Sep 2014 09:57:51 -0500 (CDT) (envelope-from rjsparks@nostrum.com)
X-Authentication-Warning: raven.nostrum.com: Host pool-173-71-50-162.dllstx.fios.verizon.net [173.71.50.162] claimed to be unnumerable.local
Message-ID: <5416FE6F.8070006@nostrum.com>
Date: Mon, 15 Sep 2014 09:57:51 -0500
From: Robert Sparks <rjsparks@nostrum.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.0
MIME-Version: 1.0
To: karagian@cs.utwente.nl
References: <53F659F7.3080106@nostrum.com>, <dd4843f243834354b3126c28313b1ae6@EXMBX31.ad.utwente.nl> <1fee4dfecb414eb8b47673f906dcf827@EXMBX31.ad.utwente.nl>
In-Reply-To: <1fee4dfecb414eb8b47673f906dcf827@EXMBX31.ad.utwente.nl>
Content-Type: text/plain; charset="windows-1252"; format="flowed"
Content-Transfer-Encoding: 7bit
Archived-At: http://mailarchive.ietf.org/arch/msg/tsvwg/Gu-S5orotI6tvYE8vNh-VI4BRM4
Cc: gen-art@ietf.org, anuragb@cisco.com, ietf@ietf.org, draft-ietf-tsvwg-rsvp-pcn.all@tools.ietf.org, tsvwg@ietf.org
Subject: Re: [tsvwg] Gen-art LC review: draft-ietf-tsvwg-rsvp-pcn-09
X-BeenThere: tsvwg@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Transport Area Working Group <tsvwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tsvwg>, <mailto:tsvwg-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/tsvwg/>
List-Post: <mailto:tsvwg@ietf.org>
List-Help: <mailto:tsvwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tsvwg>, <mailto:tsvwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Sep 2014 14:58:05 -0000

Thanks Georgios - these are improvements.

RjS

On 9/14/14 3:58 AM, karagian@cs.utwente.nl wrote:
> Hi Robert,
>
> Thank you for your comments!
>
> We have worked out your comments in the following way, see in line!
>
> Please let us know if you are satisfied with these changes!
>   
>
>
>> -----Original Message-----
>> From: tsvwg [mailto:tsvwg-bounces@ietf.org] On Behalf Of Robert Sparks
>> Sent: donderdag 21 augustus 2014 22:44
>> To: General Area Review Team; ietf@ietf.org; tsvwg@ietf.org; draft-ietf-
>> tsvwg-rsvp-pcn.all@tools.ietf.org
>> Subject: [tsvwg] Gen-art LC review: draft-ietf-tsvwg-rsvp-pcn-09
>>
>> I am the assigned Gen-ART reviewer for this draft. For background on Gen-
>> ART, please see the FAQ at
>>
>> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
>>
>> Please resolve these comments along with any other Last Call comments you
>> may receive.
>>
>> Document: draft-ietf-tsvwg-rsvp-pcn-09
>> Reviewer: Robert Sparks
>> Review Date: 21 Aug 2014
>> IETF LC End Date: 26 Aug 2014
>> IESG Telechat date: 2 Oct 2014
>>
>> Summary: Ready (with nits) for publication as Experimental.
>>
>> David's shepherd writeup points out that implementation and usage
>> experience is desired before producing a proposed standard. Are there any
>> points of concern about how this might behave (or misbehave) in a deployed
>> network that such experience would inform? If so, it would be useful to call
>> them out in the document.
>
> Georgios: Added the following paragraph at the end of Section 1.1:
>
>     This draft is intended to be published as Experimental in order to:
>     
>        o) validate industry interest by allowing implementation and
>           deployment
>
>        o) gather operational experience, in particular around dynamic
>           interactions of RSVP signaling and PCN notification and
>           corresponding levels of performance.
>
>
>> It would be nicer if the document argued why there are no new security
>> considerations introduced by the new behavior defined in this draft, rather
>> than tacitly asserting that there aren't any.
> Georgios:
> Added the following text in Section 5:
>
>     In particular, the security considerations within the PCN domain come
>     from the Trust Assumption Section 6.3.1, of [RFC5559] i.e., that all
>     PCN-nodes are PCN-enabled and are trusted for truthful PCN-metering
>     and PCN-marking.
>
>     In the PCN domain environments addressed by this document, Generic
>     Aggregate Resource ReSerVation Protocol (RSVP)messages specified in
>     [RFC4860] are used for support of the PCN Controlled Load (CL) and
>     Single Marking (SM) edge behaviors over a Diffserv cloud using Pre-
>     Congestion Notification. Similar, to [RFC4860], [RFC2747] and
>     [RFC3097] may be used to protect RSVP message integrity hop-
>     by hop and provide node authentication as well as replay protection,
>     thereby protecting against corruption and spoofing of RSVP messages
>     and PCN feedback.
>
>     Based on these assumptions, it is considered that this document is
>     NOT introducing any additional security concerns/issues compared to
>     [RFC5559] and/or [RFC4860].
>
>> The terminology section has lots of 2119 words in it. It's hard to tell when
>> these have been copied from some other draft (and this is just restating
>> them) vs when this draft is introducing a new requirement.
>> Since a new requirement would likely be missed if it appeared only in a
>> terminology section, would it be feasible to make sure anything new is well
>> covered in section 3 or 4 and remove 2119 from these definitions altogether?
> Georgios:
> Removed all RFC 2119 words from the terminology section (Section 1.3)
>
>> The rest of these comments are minor editorial nits:
>>
>> Section 1.2, paragraph 3: "Intserv over Diffserv can operate over a statically
>> provisioned Diffserv region or RSVP aware." is missing a a word somewhere.
> Georgios:
> changed From:
> Intserv over Diffserv can operate over a statically provisioned Diffserv region or a RSVP aware.
>
> INTO
> Intserv over Diffserv can operate over a statically provisioned or a RSVP aware Diffserv region
>> Section 1.2 paragraph 4: "By using multiple aggregate reservations for the
>> same PHB allows enforcement of the different preemption priorities within
>> the aggregation region." doesn't parse. Should the initial "By"
>> be deleted?
> Georgios:
> Changed from:
>
> By using multiple aggregate reservations for the same PHB, allows enforcement of the different preemption priorities within the aggregation region.
>
> INTO:
> By using multiple aggregate reservations for the same PHB, it allows enforcement of the different preemption priorities within the aggregation region.
>
>> The definition for PCN-domain is very close to circular. Perhaps some words
>> can be removed?
> In Section 1.3, we have replaced PCN-domain with domain in the text, see below:
> Channged from:
>     PCN-domain:      a PCN-capable domain; a contiguous set of
>                      PCN-enabled nodes that perform Diffserv scheduling
>                      [RFC2474]; the complete set of PCN-nodes that in
>                      principle can, through PCN-marking packets,
>                      influence decisions about flow admission and
>                      termination within the PCN-domain; includes the PCN-
>                      egress-nodes, which measure these PCN-marks, and the
>                      PCN-ingress-nodes.
>
>
> INTO:
>     PCN-domain:      a PCN-capable domain; a contiguous set of
>                      PCN-enabled nodes that perform Diffserv scheduling
>                      [RFC2474]; the complete set of PCN-nodes that in
>                      principle can, through PCN-marking packets,
>                      influence decisions about flow admission and
>                      termination within the domain; includes the PCN-
>                      egress-nodes, which measure these PCN-marks, and the
>                      PCN-ingress-nodes.
>
> =========
>
> Best regards,
> Georgios
>
>>