[Tzdist-bis] Opsdir last call review of draft-murchison-tzdist-tzif-14

Qin Wu <bill.wu@huawei.com> Wed, 26 September 2018 04:57 UTC

Return-Path: <bill.wu@huawei.com>
X-Original-To: expand-draft-murchison-tzdist-tzif.all@virtual.ietf.org
Delivered-To: tzdist-bis@ietfa.amsl.com
Received: by ietfa.amsl.com (Postfix, from userid 65534) id 6C6DF130E01; Tue, 25 Sep 2018 21:57:20 -0700 (PDT)
X-Original-To: draft-murchison-tzdist-tzif.all@ietf.org
Delivered-To: xfilter-draft-murchison-tzdist-tzif.all@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 30221126BED; Tue, 25 Sep 2018 21:57:20 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Qin Wu <bill.wu@huawei.com>
To: ops-dir@ietf.org
Cc: draft-murchison-tzdist-tzif.all@ietf.org, ietf@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.84.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <153793784014.5492.3352087171961683649@ietfa.amsl.com>
Date: Tue, 25 Sep 2018 21:57:20 -0700
Resent-From: alias-bounces@ietf.org
Resent-To: arthurdavidolson@gmail.com, eggert@cs.ucla.edu, murch@fastmailteam.com, alexey.melnikov@isode.com, ben@nostrum.com, adam@nostrum.com, aamelnikov@fastmail.fm, tzdist-bis@ietf.org, lear@ofcourseimright.com
Resent-Message-Id: <20180926045720.6C6DF130E01@ietfa.amsl.com>
Resent-Date: Tue, 25 Sep 2018 21:57:20 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/tzdist-bis/YtAMn_zw9esrxE8mX4XyOKReLVY>
Subject: [Tzdist-bis] Opsdir last call review of draft-murchison-tzdist-tzif-14
X-BeenThere: tzdist-bis@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Extensions to Time Zone Data Distribution Service <tzdist-bis.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tzdist-bis>, <mailto:tzdist-bis-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tzdist-bis/>
List-Post: <mailto:tzdist-bis@ietf.org>
List-Help: <mailto:tzdist-bis-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tzdist-bis>, <mailto:tzdist-bis-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Sep 2018 04:57:20 -0000

Reviewer: Qin Wu
Review result: Has Nits

I have reviewed this document as part of the Operational directorate's ongoing
effort to review all IETF documents being processed by the IESG.  These
comments were written with the intent of improving the operational aspects of
the IETF drafts. Comments that are not addressed in last call may be included
in AD reviews during the IESG review.  Document editors and WG chairs should
treat these comments just like any other last call comments.

This document defines the Time Zone Information Format (TZif) for representing
and exchanging time zone information. The typical application is iCalendar or
scheduling system.

This document is ready, and I only found a few nits in it.
1.Section 3, what is 32-bit transitions, what is 64 bit transitions, how it is
different from 32-bit transition times and leap second occurrences, why header
should also include 32 bit transitions? Wouldn’t header a 44-octet header?
Would it be great to add transition as a new term in the terminology section.

2.Section 3.2 What is the header of the 64-bit data block, how it is different
from 64bit transitions? Isn’t header of the 64 bit data block 44-octet header?

3.Leap second records definition
How 64 bit data block can be used to accommodate 16 octet records?
4. Can you explain footer is needed for version 2 and 3 of TZif file while not
needed for version 1?