Re: [Uta] Updated TLSRPT (WGLC Comments)

[Viktor Dukhovni <[e-mail]>]

> On Mar 4, 2018, at 1:47 PM, Brotman, Alexander <[e-mail]> wrote:
> 
> Hello folks,
> 
> We used the feedback from folks during the WGLC and have submitted a new version.  This is mostly editorial changes or minor inconsistencies.  We did also remove any relation between the TLS-Report-Submitter and the filename.  If you have any comments, please let us know.  Thank you.
> 
> https://www.ietf.org/id/draft-ietf-uta-smtp-tlsrpt-16.txt

Almost there, but a couple of editorial nits:

        4.4

            o  "policy-string": A string representation of the policy,

Since it is no longer a "string representation" of the policy, but rather
an array of strings, at least the description should probably change to:
"An encoding of the policy as a JSON array of strings" or some such.  You
could also rename the element to "policy-array", but I don't feel strongly
about that.

 	4.5.  Policy Samples

 	   Part of the report body includes the policy that is applied when
 	   attemping relay to the destination.

 	   For DANE TLSA policies, a JSON array of strings each representing the
 	   RDATA of a single TLSA resource record as a space-separated list of
 	   its four TLSA fields; the fields are in presentation format (defined
 	   in RFC6698 Section 2.2) with no internal spaces or grouping
 	   parentheses:
 		
 	   ["3 0 1
 	   1F850A337E6DB9C609C522D136A475638CC43E1ED424F8EEC8513D747D1D085D",
 	   3 0 1
 	   12350A337E6DB9C6123522D136A475638CC43E1ED424F8EEC8513D747D1D1234"]

There's a missing open double-quote for the second "3 0 1".
 		
 	   For the MTA-STS policy, an array of JSON string will represent the

s/array of JSON string will represent/JSON array of strings that represents/
just as in the DANE paragraph above.

 	   policy that is declared by the receiving site, including any errors
 	   that may be present.  Note that if there are multiple MX records,
 	   they are not included as an array.
           
           [
           "version: STSv1",
           "mode: report",
           "mx: mx1.example.com",
           "mx: mx2.example.com",
           "mx: mx.backup-example.com",
           "max_age: 12345678"
           ]

I reformatted the JSON array with one element per line for clarity (putting the
square brackets on separate lines), I think you should do the same both here,
and in the DANE example:

           [
           "3 0 1 1F850A337E6DB9C609C522D136A475638CC43E1ED424F8EEC8513D747D1D085D",
 	   "3 0 1 12350A337E6DB9C6123522D136A475638CC43E1ED424F8EEC8513D747D1D1234"
           ]

The comment about MX host patterns not being included as an array may be a
confusing.  It might be clearer to say:

  Note that where there are multiple "mx" values, they must be listed as separate
  "mx" elements in the policy array, rather as a single nested "mx" sub-array.

-- 
	Viktor.