Re: [Webpush] Kathleen Moriarty's No Objection on draft-ietf-webpush-vapid-03: (with COMMENT)

Martin Thomson <martin.thomson@gmail.com> Thu, 17 August 2017 00:45 UTC

Return-Path: <martin.thomson@gmail.com>
X-Original-To: webpush@ietfa.amsl.com
Delivered-To: webpush@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7ABE81323C0; Wed, 16 Aug 2017 17:45:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.699
X-Spam-Level:
X-Spam-Status: No, score=-2.699 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iUsxhjgRBkqW; Wed, 16 Aug 2017 17:45:30 -0700 (PDT)
Received: from mail-it0-x22e.google.com (mail-it0-x22e.google.com [IPv6:2607:f8b0:4001:c0b::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 47663132386; Wed, 16 Aug 2017 17:45:30 -0700 (PDT)
Received: by mail-it0-x22e.google.com with SMTP id 76so24468257ith.0; Wed, 16 Aug 2017 17:45:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=CxhErxl3ontWNWY4L/5h9fo113OKEP2KFANYh3Rp/b8=; b=KKnCuYTpP1v/2GJzAOFbSdATiO/4Mh/pzEc9xGAUK+EHOpugdlSSYaGnQEG2httL96 2C42ovbHDuAtmBwfk7dGSq9RD9iyOl372+QYqXlswnfXe2c960bxQCVDeqfMoQZ+PvpI 5xZvkj8lwhYy5dfsWk9XzIyDuudpTIr2lFiL7RYMyDW/bAS9VzmLM5I2+d0IWNezYp97 OpmQxbWfKHKqjssgNgM1k34wBdhCA1UbDB9aWMC8unEh1atf7qZh+GZy/ThQDDnA1Ly8 8Am5TD38yoj7H1yJ8aVSp/e7GOFz/4kDO3YAoXWsSuU3NyZE5YmgvIY1RV6ZyOVlp9EK k1Ag==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=CxhErxl3ontWNWY4L/5h9fo113OKEP2KFANYh3Rp/b8=; b=DfLT3x+yMulAbQJ/1zyKJru/OmmQH+u5LTKqkWNhcPNotLAdRCli1Z7fV2oIqdOmct f+/DXMTsBkU7c670jpq1MSptYmxK/AaGQCoEW7Yy+XhpkJBOMNga+T5kBIdrptsfpjlX ++7t3I5netDjvL8Im/XUsbc2Gh32p2XW8M84KzoS6BjKbIta+lYfCRe/1EuMyeHs225W vBheOVq4L7ePQ+9nPWwUj76Hu81cDFm20N9N+S/Ft2kjuE39w5uZlxkRiVErDT+dblS3 J4UZ8FPnbpdU+t2ii58fLngku4/1goPxxH8+mebI28TkPJM+yZhVZ45aU8M/BULwHzk/ paRw==
X-Gm-Message-State: AHYfb5gMkg5SDPSb5Rr+t4HUUFBFn+Vayt7lA1cGMsrDDmEezxRgeSFy tDmfpbKh8+PhvRR0eIrjje+8g/ywTbYBD70=
X-Received: by 10.36.13.10 with SMTP id 10mr284505itx.51.1502930729682; Wed, 16 Aug 2017 17:45:29 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.107.164.42 with HTTP; Wed, 16 Aug 2017 17:45:29 -0700 (PDT)
In-Reply-To: <CAHbuEH7cB=ST=zz8r-G-q6eREy66cRoQCkgS=qq50pX6=pPTyg@mail.gmail.com>
References: <150282302424.20984.16954614287039839165.idtracker@ietfa.amsl.com> <CABkgnnXotYcLeJyPcF97Den=-bEzoOv6WWjT3uQ=ELGA94DkNA@mail.gmail.com> <CAHbuEH7cB=ST=zz8r-G-q6eREy66cRoQCkgS=qq50pX6=pPTyg@mail.gmail.com>
From: Martin Thomson <martin.thomson@gmail.com>
Date: Thu, 17 Aug 2017 10:45:29 +1000
Message-ID: <CABkgnnXBGFqRYAChyjQz+86brz8NTrJT+B5p_rWXCD=CPjJ0Dg@mail.gmail.com>
To: Kathleen Moriarty <kathleen.moriarty.ietf@gmail.com>
Cc: The IESG <iesg@ietf.org>, draft-ietf-webpush-vapid <draft-ietf-webpush-vapid@ietf.org>, Phil Sorber <sorber@apache.org>, webpush-chairs@ietf.org, "webpush@ietf.org" <webpush@ietf.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/webpush/ap7crTK1YmzCgzQUBbJhB5hbbkg>
Subject: Re: [Webpush] Kathleen Moriarty's No Objection on draft-ietf-webpush-vapid-03: (with COMMENT)
X-BeenThere: webpush@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Discussion of potential IETF work on a web push protocol <webpush.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/webpush>, <mailto:webpush-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/webpush/>
List-Post: <mailto:webpush@ietf.org>
List-Help: <mailto:webpush-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/webpush>, <mailto:webpush-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Aug 2017 00:45:33 -0000

On 17 August 2017 at 01:34, Kathleen Moriarty
<kathleen.moriarty.ietf@gmail.com>; wrote:
>> The text you cite is included specifically to maybe prevent someone
>> from incorrectly using the same key for signing (in -vapid) and
>> encryption (in -encryption).  Unfortunately, this specific type of
>> misuse is possible in a lot of codebases and does happen.
>
> OK, if it's possible to edit the cited text to make it more clear, I
> think that would be helpful to any implementer that comes along later.

I made a change in response to Ben's review that might help:
https://github.com/webpush-wg/webpush-vapid/pull/44/commits/3269c22c083793b52da9dff51273843e3dc0d3f7