Re: [websec] Richard Barnes' Discuss on draft-ietf-websec-x-frame-options-09: (with DISCUSS and COMMENT)

Richard Barnes <rlb@ipv.sx> Mon, 19 August 2013 20:24 UTC

Return-Path: <rlb@ipv.sx>
X-Original-To: websec@ietfa.amsl.com
Delivered-To: websec@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9383A11E82E3 for <websec@ietfa.amsl.com>; Mon, 19 Aug 2013 13:24:36 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.813
X-Spam-Level:
X-Spam-Status: No, score=-2.813 tagged_above=-999 required=5 tests=[AWL=0.163, BAYES_00=-2.599, FM_FORGED_GMAIL=0.622, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-1]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TyZ59w4ZatPl for <websec@ietfa.amsl.com>; Mon, 19 Aug 2013 13:24:32 -0700 (PDT)
Received: from mail-oa0-f52.google.com (mail-oa0-f52.google.com [209.85.219.52]) by ietfa.amsl.com (Postfix) with ESMTP id 3DCF711E82E4 for <websec@ietf.org>; Mon, 19 Aug 2013 13:24:02 -0700 (PDT)
Received: by mail-oa0-f52.google.com with SMTP id n12so4336340oag.39 for <websec@ietf.org>; Mon, 19 Aug 2013 13:24:01 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=p6FdZNyDOeOV1oNkNypFdc9aMIn4eZu/8VM0L1GPv/4=; b=TvbGjO3U/Sbb/GAhg5q8EzVAUaFieCUIVk2syR377A5bN5GMwQCH2VtIbEQe179ewO nmUATaexQxeQsknd+V+N94yl/h/EW5Qu/sYwoCLDUCb1yPicNMRVNAb5MM212XpVIP0S Rc5kPHkVt1py9OMejv1aibjOeXe5XaAn1VMOKGerDXyybZqH7x3o6jeUCEas7q7J6rnE 1mEKnud1XNSVj3ZUnHPaU1vNheLX3+aJlgUqZ+rGByix6/0qHud6DrEhlkWY6H/cmC8G ZP9IQW3NqMSes7BjkOt8cEnBfo3068PyixgNhN9f6LxMtqeZcwSy9HBA5DbjEbeG+WDd 9bNQ==
X-Gm-Message-State: ALoCoQkxlV3IZ7JQ1bk5p9Z3DVllzSj+3RoagD9+FJoOpojTLeiJquqqDThsefirtexO7bIITwv+
MIME-Version: 1.0
X-Received: by 10.60.47.129 with SMTP id d1mr71640oen.84.1376943841616; Mon, 19 Aug 2013 13:24:01 -0700 (PDT)
Received: by 10.60.31.74 with HTTP; Mon, 19 Aug 2013 13:24:01 -0700 (PDT)
X-Originating-IP: [2001:470:8:aff:c898:b483:6058:dadf]
In-Reply-To: <370C9BEB4DD6154FA963E2F79ADC6F2E27BAF121@DEN-EXDDA-S12.corp.ebay.com>
References: <20130815014121.17800.33179.idtracker@ietfa.amsl.com> <370C9BEB4DD6154FA963E2F79ADC6F2E27BAD2A7@DEN-EXDDA-S12.corp.ebay.com> <370C9BEB4DD6154FA963E2F79ADC6F2E27BAF121@DEN-EXDDA-S12.corp.ebay.com>
Date: Mon, 19 Aug 2013 16:24:01 -0400
Message-ID: <CAL02cgS8e=9-heOyU=2hbc3TibMo-XFUTYkX4s=98j6ORE3VLg@mail.gmail.com>
From: Richard Barnes <rlb@ipv.sx>
To: "Hill, Brad" <bhill@paypal-inc.com>
Content-Type: multipart/alternative; boundary="001a11c303f28e406204e452b8d2"
Cc: "draft-ietf-websec-x-frame-options@tools.ietf.org" <draft-ietf-websec-x-frame-options@tools.ietf.org>, "websec@ietf.org" <websec@ietf.org>, The IESG <iesg@ietf.org>, "websec-chairs@tools.ietf.org" <websec-chairs@tools.ietf.org>
Subject: Re: [websec] Richard Barnes' Discuss on draft-ietf-websec-x-frame-options-09: (with DISCUSS and COMMENT)
X-BeenThere: websec@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Web Application Security Minus Authentication and Transport <websec.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/websec>, <mailto:websec-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/websec>
List-Post: <mailto:websec@ietf.org>
List-Help: <mailto:websec-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/websec>, <mailto:websec-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Aug 2013 20:24:36 -0000

Safari also renders the innermost frame.


On Mon, Aug 19, 2013 at 3:31 PM, Hill, Brad <bhill@paypal-inc.com> wrote:

> I received a question as to whether all browsers really implement the
> top-level only check, or if any do an immediate parent or ancestor walk.  I
> could guess, but I'd rather test.  Here's a test case for public use:
>
> http://webappsec-test.info/~bhill2/XFO/XFO_Top.html
>
> I checked the latest IE, Chrome, Opera and Firefox and they all render the
> innermost frame. (don't have a Safari instance handy at the moment to test
> but welcome others' reports)
>
> -Brad
> ________________________________________
> From: Hill, Brad
> Sent: Friday, August 16, 2013 4:44 PM
> To: Richard Barnes; The IESG
> Cc: draft-ietf-websec-x-frame-options@tools.ietf.org; websec@ietf.org;
> websec-chairs@tools.ietf.org
> Subject: RE: [websec] Richard Barnes' Discuss on
>  draft-ietf-websec-x-frame-options-09:   (with DISCUSS and COMMENT)
>
> Additional comments inline.
> ________________________________________
>
>
> (D3) Shouldn't ALLOW-FROM be followed by an origin, not a URI?  In other
> words, what does it mean to send "X-Frame-Options: ALLOW-FROM
> https://example.com/this/is/a/path?query#fragment"?
>
> [Hill, Brad] Agreed.
>
>
> (D3) In the ALLOW-FROM: what does "top level context" mean?  Do you
> really mean the top level here, as opposed to the next one up?  For
> example, suppose A loads B in an iframe, and B loads C, and then C sends
> an X-Frame-Options header with ALLOW-FROM.  Is the ALLOW-FROM origin
> compared to B or A?  In either case, you should also note the attacks
> that remain.  For example, if the answer is B, then B needs to use
> X-Frame-Options as well, or else, A can maliciously frame A within B.  Or
> if the answer is A, then C is trusting A not to load any malicious
> intermediate frames B.
>
> [Hill, Brad]  This really does mean the top/final origin value in a frame
> ancestor
> chain walk.  Browsers have implemented X-Frame-Options to check the
> Origin context that is topmost in the window or tab.  (the _top target,
> representing the full, original browsing context, not just the immediate
> parent frame)  This could be clarified perhaps, but is not incorrect.
>
>