Re: [Wish] 2nd WG Last Call for draft-ietf-wish-whip

Christer Holmberg <christer.holmberg@ericsson.com> Fri, 12 January 2024 13:48 UTC

Return-Path: <christer.holmberg@ericsson.com>
X-Original-To: wish@ietfa.amsl.com
Delivered-To: wish@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7E45FC14F68E for <wish@ietfa.amsl.com>; Fri, 12 Jan 2024 05:48:27 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.11
X-Spam-Level:
X-Spam-Status: No, score=-2.11 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FU0Biqn5zdVW for <wish@ietfa.amsl.com>; Fri, 12 Jan 2024 05:48:23 -0800 (PST)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2087.outbound.protection.outlook.com [40.107.20.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 50866C14F5FC for <wish@ietf.org>; Fri, 12 Jan 2024 05:48:23 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c4pJ4V3pgzh8KeoCQi2mXOcGwDZgn/GsH9vi7Vi3l7AeRVad3zCoz9p8Z4kMO2STBbxYMHNdh5LTfxlhrKtEN0rEhlbpCR8cXwGthw0AYfhjKVse+StUBB0dm/bJIIv+RP5fsE9qQ2r4UBrzKNtQVQqJ/BXVVlVBW8KUCYwR+lR73AD/88jgK+oleXy/WqCAnxYyN/DYpmTTWMACmbJ67rBxVp4uaf57L0O5wTrNLGNwzp/B/xzSoqciFXV0yXmfKv+bIc+rtS/dvzo/ki0fGiV+EZaHH5xKMSDgNFAN6Dzx7u5cc651FWEItFNMT+6a9YQAfhLM/WMAfusUY6Y9zA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kfjv/mj7jXewkmRRAdJnzEvMC9XHZflqOsa2pQY+/UI=; b=JqYvD6giq0yfsaC7JWApZrQfwpirjnkRjOIq5y6JU++lcQEiZeiF/eNIZw02BfzmT1iZ4iaIMgh7XWLZNt0uaWIoK57Gtc0COwCOuYdxAWM6T6D2NI93N7NtISUTt7WVVfqMBPVTFKAowzzUzR8wQ+mv58oSgBIpNpebUsLG9T47uA13lC0G3sNe43hTrKulCfpIadEW43nvFfI8but99ri6JL5KxN7wcuyCH7lyhhubEfQi7RPiJgEpcLZvqNS7O2YBKLIlfL/RdXVmm4G2gIT4KBLvO6IKcWUMV43AYoZogGWXHw96UL0dn9lsIJ6yewZXXLvIQyrnF6Y7sJWT6A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kfjv/mj7jXewkmRRAdJnzEvMC9XHZflqOsa2pQY+/UI=; b=cudwLhxnm2tvT19HeMnyHGSb7ipFV4A1FfIGbAyeo90EaIXt04tM2SISrTw+Ljp9gpWtfSxRTU+g89ehK4rdtTU10mw/UMOn6q+01qIlUhaqpIJd2UZJA2WlU6h7ZIAzGq410PNCzGQPsPWxawpiy4VJ4zg56d1XZUD1n51KgVR0atZxFdKn4diMwt5NDafxdki6ab9Qa4chuWq3zYbSoc21PUW79EWl3/OK3Gpivd2IbTMphMzlMTg1+puV9D70kMEk/p2RRK5+sYKaIoA2GgMtkHtxTSJWomjptWu+sfYaslj2PSu7hasuJRoJAkmCEC+KbvefxkbmfVKpXz2qBw==
Received: from HE1PR07MB4441.eurprd07.prod.outlook.com (2603:10a6:7:9f::27) by AM8PR07MB7490.eurprd07.prod.outlook.com (2603:10a6:20b:244::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.21; Fri, 12 Jan 2024 13:48:20 +0000
Received: from HE1PR07MB4441.eurprd07.prod.outlook.com ([fe80::5ef9:ca02:b63f:263]) by HE1PR07MB4441.eurprd07.prod.outlook.com ([fe80::5ef9:ca02:b63f:263%4]) with mapi id 15.20.7181.019; Fri, 12 Jan 2024 13:48:20 +0000
From: Christer Holmberg <christer.holmberg@ericsson.com>
To: Sergio Garcia Murillo <sergio.garcia.murillo@gmail.com>
CC: Sean Turner <sean@sn3rd.com>, WISH List <wish@ietf.org>
Thread-Topic: [Wish] 2nd WG Last Call for draft-ietf-wish-whip
Thread-Index: AQHaMuKZYl7SxOP80EWCl3RP3TCtTLDG8WYAgAk7+ICAAVBPMIAEhqgAgABIIkA=
Date: Fri, 12 Jan 2024 13:48:20 +0000
Message-ID: <HE1PR07MB44412695005E2FA745CCC65E936F2@HE1PR07MB4441.eurprd07.prod.outlook.com>
References: <6E5C6103-767B-41FC-8C69-CBC5FE5201EB@sn3rd.com> <E41AA83B-7798-4DE9-99A7-EEC263391CF4@sn3rd.com> <CA+ag07ZU2g5UmjShMUSXg5pnu0JWPVpszuKM9eBFWLeezCZgCA@mail.gmail.com> <HE1PR07MB4441B913AC8A42B5BD5AD45E936A2@HE1PR07MB4441.eurprd07.prod.outlook.com> <CA+ag07ZyqcXtGdLXDQv_x-bMcPJtS3Tgv00QLMxkGrUZHPDfaQ@mail.gmail.com>
In-Reply-To: <CA+ag07ZyqcXtGdLXDQv_x-bMcPJtS3Tgv00QLMxkGrUZHPDfaQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=ericsson.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: HE1PR07MB4441:EE_|AM8PR07MB7490:EE_
x-ms-office365-filtering-correlation-id: 57edeb4f-72d9-41f9-abe9-08dc13752342
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 0kV3Zg7DntEu+1pyxRvqn7J1hWlh7T42exciCsnZt1NyxIjhe7KKc+ApsrW5UEHoN5OLjqD2QYRBgItCKS9Apy3FNrYchMJa/qo4tjq7vDrHkrJj8XTYL97wavnGCbKYPhBC7Hegeayw4xnnsQR+327ZMwnvDI0rEk/W3ZNG+Qyp0D0Rjt+uXV6MGu0HOZrXrugMsjXOCQIxRUcibBrQoejDm6RdekvRE1t5Esthp6JeCIG6t0f3XbhudyeOsjYk4I7+9ZCsou+pxEFta7LCN0pWqQen3hpBL3c3sxNUZ4faRq2LCqdWtxmQpSUyqpY7Cw9XAW6QiV+8YevBH7NXspiMMe38oaDII7rb+UsZXVismEcnVNjQPb/TBUXT7utH4fY/xTJoz6ja23ov1GpmnpfF9G0/mzGdBJXGiTDgS1aUtQqCzYXuYIJJ3nNNoKz2XpMpgrRpmCwDQAWLJghfaSR3VTslB/DijjGU9VUjch87NnzTK54cyUfGZyQTeIdYH6U27KO6JAa9yDUYq/DngMWXg3CCXvafEob66wT7xyKFvdR49fyW0ceJhnEzKpTtLedE/v5tT5nu3louFUb5j0g9bRJCEX5Cl5TBbVDIi8U=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:HE1PR07MB4441.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(136003)(366004)(376002)(396003)(39860400002)(230922051799003)(1800799012)(451199024)(64100799003)(186009)(66899024)(82960400001)(99936003)(38100700002)(2906002)(122000001)(26005)(41300700001)(55016003)(38070700009)(33656002)(86362001)(44832011)(478600001)(966005)(5660300002)(64756008)(66556008)(66476007)(7696005)(66946007)(6916009)(66446008)(9686003)(71200400001)(76116006)(8936002)(6506007)(54906003)(52536014)(4326008)(316002)(8676002)(83380400001); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: zRRtKCWfhIVRHxE3ypvAE4M/JCHJ6yMm6JgWjTTnIg96t6LZB31a6jpNNfsHEDKQHGm6ootJn3fy9s+x7u0Dj2okrr4pCSM1kzZKA4CyYmJhN2p6qMLUyGaMiQKZ0Lbi5dsNjQUY9Rpo3tcE66YMMy0hDVtvrdyGZxfMuLaOC97GE2+59v7hDHEldgBFM6m5V0c+WdOf2S8vFHnR6I2uKK6deGPBdILBCZ+/t7k1g2/9scxjrM98fn4dIuZRFfGvpk+7GV7NjUtRWDg1+LUtbklXpanyfP4Re347zBqxRnEeLhLU6vZsmCSQsMk0H1x2JyWLc306jyqkyR68mDiQI+PWOtzh5i/OJiqEd/XgfMIS33RgCL/p7lngbeE0Hmq2EisMN3142x3iB7dvYEDzNr7Hq5MJWctJw4Ebj9Z4wC931yc12oyouGpnx3QI0sk2aHWEneeIvISsC92JdvE9OuAAgNlDmu1yWTOmBtLJ9B6UO20uOI057etblWba9dctKJqMZMn/AquI2dXaq0nbqO9CTapPQ3x6N2kEA5wu9nrLU8dIs98icQgWAv/rkgw0rqYXMxgiLE/VDiv21/355pOR2jSyn9n0GuDhhQWrwkiU1rL+nOQAUqcPiKrBlT9qQitBJse7iMfroC31w0lJqHUdspNjOAOTWKDmehMjROvlP/EWTSPuTXC+kjsTFow1yi7u/twvXI/kcCri2cVslDtnFM5jwkpv/ih1PNRlXFaibjSqf8H8saFL5Vvn+PVRKJe6CDl0YFGKezRNbV9XTC8Zr1yvnFKHNsYkh79kSdO5R7HU82Hv4LgWQG8Xx8LKm0Ma2F+MIRQp6XPDIpQfrCPAwUYoeio7CIukoPtOXDdZSTBJlDbdBw8OT+6nudXJyIIALvn6LofvKoI9w7o+PG0U6iPi8PxGGV5NTQcGTBI+TQd3+/Lf8401RRr+o21PrxRK/BGpJQYQGbwi5cPqjtaLJ4UuWctGFsUDACzJXEakHd4a1GHvogkp83ml0B84/2mdwUhKOaocD8xs0DJ7ZuVGmKrl67uAb+cTvM97IqnpkwFgA5ew92AWpdY+mpkK69dPg3tcD6P+3GA+A3a7IF1jKdcHiJRYqr6QfCqGsQWo9GUr2U+VFEpYEwbi1jT7Sock9lAvCjKMsz2QCXck3rMQTwFUs+8fmbfizFMxQX+c4MCEtWp0xE9ofOsq6DQAG3j8KoDh7i84obqlRwA/SdjiwoEfPPxjnAiOBnP/tV8+TE93ud38dssi0iGj+3szFBiEjklIidlni3EiNbsRWK/lZqSc6t4IMVLH4sG0GOv4QPQsseS/FoNSZW/xsSj2AWST66woi04Nhnm+L/uDlfW8m9tWz2k096dq0gs2cgI0M44IYDcGh6hJ1T6G83TYlFn2H8/LUO98cAs8/j0Z9tmXZ+mRjpekDyh2Kcn7qulCi+pi0BIoV+VquMKEOGMzYSxJLy3XhPgwvOL1aHSNCPKA+trVlRSP7Cn6GvZzqxec0xI/eucD+Dvdl5wamyrGV7GLSDSvycklbhuw2a0AsOSEbEBMnsXnBQVNJaJjuomjkNQm1dxBs1wr5xlVTOl1ZjsKlLwRljIylngnLiXnqA==
Content-Type: multipart/signed; micalg="SHA1"; protocol="application/x-pkcs7-signature"; boundary="----=_NextPart_000_0031_01DA456E.C44646B0"
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: HE1PR07MB4441.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 57edeb4f-72d9-41f9-abe9-08dc13752342
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2024 13:48:20.3289 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: B2lwKb2ZZ9Vsl28gA7xON83YwHfgO+uCxGWFUh/oe7onyObpVRSx8dLdL096bm11rDP38Usnx10kB/EseZEOVhzEQH/VgcmTuJrOkGq6eU0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR07MB7490
Archived-At: <https://mailarchive.ietf.org/arch/msg/wish/vR2dkaoiN31J5pDg2FNyhIFMEps>
Subject: Re: [Wish] 2nd WG Last Call for draft-ietf-wish-whip
X-BeenThere: wish@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: WebRTC Ingest Signaling over HTTPS <wish.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/wish>, <mailto:wish-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/wish/>
List-Post: <mailto:wish@ietf.org>
List-Help: <mailto:wish-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/wish>, <mailto:wish-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Jan 2024 13:48:27 -0000

Hi,

>> 	The following issue has been discussed between myself and Sergio in:
>>
>> 	https://github.com/wish-wg/webrtc-http-ingest-protocol/issues/163
>> 
>> 	However, I bring it to the list because I think it would be useful to get 
>>          wider community input and guidance.
>> 
>> 	WHIP uses the SDP trickle-ice-sdpfrag content type for ICE restarts.
>>          However, RFC 8838 only defines usage of trickle-ice-sdpfrag for trickle ICE.
>>          With SIP, an ICE restart triggers a new SDP renegotiation.
>>  
>> 	Now, AFAIK the justification of WHIP using PATCH with trickle-ice-
>>          sdpfrag also for ICE restart (instead of POST with a new SDP offer),  is the
>>          statement in Section 3, saying that SDP renegotiations are not supported.
>>
>> 	“It is important to note that SDP renegotiations are not supported in WHIP, 
>>          meaning that no modifications to the "m=" sections can be made after the
>>          initial SDP offer/answer exchange via HTTP POST is completed and only
>>          ICE related information can be updated via HTTP PATCH requests as defined in
>>          Section 4.1.”
>> 
>>  
>> 	Q1: SDP renegotiation is more than the “m=” sections. There is also
>>          the session-level information, e.g., the “c=” section, the “o=” section etc. So,
>>          I think the text needs to talk about what INFORMATION can/cannot be
>>          updated.
> 
> Nothing can be changed except what we explicitly allowed in the 4.1. ICE
> support section.

Section 4.1 only talks about ICE support in general.

> I don't think we should make a list of what can and can't be
> changed here, especially given that some of that info has the spec in
> different RFCs which we may conflict with.

Section 3 explicitly forbids modifying "m=" sections, but does not e.g., talk about session-level information etc.

Could we simply say?

"Once the initial SDP offer/answer exchange via HTTP POST has been completed, only the ICE credentials and candidates
can be updated and renegotiated via HTTP PATCH, as defined in Section 4.1."

>> Q2: Related to Q1, the text says that ICE related information can be
>> updated. But, if the “m=” section cannot be updated, does that also mean
>> that the IP port in the host candidate cannot be updated, as that it typically
>> the port value also used in the “m=” section? Again, I think it is better to
>> explicitly describe what information can be updated.
>  
> I disagree, it would be easy to contradict what is specified on another rfcs.
> We could even be more precise and change the " and only ICE related
> information can be updated" by " and only certain ICE related information
> can be  updated"

See my reply to Q1.

>> Q3: Related to Q1 and Q2, it needs to be clear what information the
>> WHIP session can return in the PATCH response in case of an ICE restart. Can
>> the WHIP session change the port number of its host candidate? Etc.
>  
> As we are adding ICE restart in this draft, I agree that we should be more
> precise about the construction of the PATCH response. Do you have any
> suggestions? I will try to create a PR for that.

Since the WHIP client can only change certain ICE information, I guess the same could apply to the WHIP session?

Regards,

Christer