Re: [xml2rfc-dev] xml2rfc Input Document Issues

[Josh Bothun <[e-mail]>]

On Jul 30, 2011, at 6:38 AM, Tony Hansen wrote:

> ...
> 
> On 7/30/2011 2:13 AM, Mike Biglan wrote:
>> Hi Henrik and Tony,
>> 
>> Here is a little more detail on what we worked on this past week in response to the input documents. We went ahead and tested a set of 450 documents in an attempt to categorize the errors, then fix any that needed fixing. Below are the categories that had errors and the counts in parentheses; this includes issues we have fixed, errors in the document or outside our codebase, and open questions.
>> 
>> FIXED
>> 
>> 1) Include instructions are being handled properly now.
>> 
>> 2) No DTD file was declared in the document (12)
>> We had already planned to handle this but it wasn't possible until a recent change.  I will implement a function in the application to default to rfc2629.dtd if no dtd is declared.
> 
> I'll note also that the --dtd parameter didn't seem to work either.

This has been fixed in the latest version (2.0.2).

> 
>> 9) Incorrect DTD filename given (2)
>> Could be a typo or intended to complete later, some files used 'rfcXXXX.dtd' for the DTD.  If we need to, we can treat this in the same way as if no DTD were given, but it might be more appropriate to display an error.
> 
> Can you be more specific about which documents displayed the above errors so we can see exactly what you're referring to?

Sure -- the following documents have a DOCTYPE referencing "rfcXXXX.dtd":
   draft-dnoveck-nfsv4-storage-control-01.xml
   draft-dnoveck-storage-control-01.xml
   draft-jdfalk-maawg-cfblbcp-01.xml
   draft-kanno-secsh-camellia-02.xml
   draft-kanno-tls-camellia-03.xml
   draft-worley-service-example-07.xml

> 
> ERROR: Unable to parse the XML document: draft-livingood-woundy-p4p-experiences-10.xml
> internal error, line 6, column 70
> 
> 
> I hadn't spotted these before. "Internal error" is just as bad as a exceptions.

I'm currently looking into these to see how we can better express the errors.  It looks like the pattern from documents that throw this is that they have syntax errors in the DOCTYPE declaration.

> 
> Tons of errors like
> 
> ERROR: Unable to validate the XML document: draft-maino-lisp-sec-00.xml
> Line 407: IDREF attribute target references an unknown ID "RFC5226"
> 
> 
> that need to be understood.
> 
>   Tony

This large class of errors you are getting seems to be an issue with the citation loading -- I would be curious if you ran the latest HEAD again with some of my new changes if the problem still exists.

I am able to replicate the error by invalidating my XML_LIBRARY path, or by removing the citation document entirely, however the script will also then print a warning saying that the include could not be resolved.  I've made it warning level instead of error level because it doesn't actually halt the parser, since processing instructions are not limited by the DTD, however it may be more appropriate for this to be an error.
		
If the error is still coming up, I believe that means the citation document was not found in $XML_LIBRARY OR in the same directory as the input XML file.  Running the script with --verbose may help because it prints the path to the reference its trying to load.

-josh