Re: [xml2rfc] Low priority bug - bad date input

[Kesara Rathnayake <[e-mail]>]

On 6/05/22 11:54 pm, David R. Oran wrote:
> On 5 May 2022, at 17:52, Kesara Rathnayake wrote:
> 
>> Hi Dave,
>>
>> Can you provide the xml2rfc version and draft that causes this error?
> xml2rfc in /usr/local/lib/python3.9/site-packages (3.12.5)
> 
>> I can create an issue in https://github.com/ietf-tools/xml2rfc/issues/ for this.
>>
>> I grabbed https://www.ietf.org/id/draft-oran-icnrg-pathsteering-06.xml changed the year to 2016.
>> And `xml2rfc --text --pdf --html draft-oran-icnrg-pathsteering-06.xml` gave me following error:
>> ```
>> Error: Expected <date> to have the current year when month is missing, but found '2016'
>> ```
>>
> Strange - I can try to recreate.
> It turns out the typo was “2016	“ (i.e. a tab in the year field that crashed xml2rfc)
> 
> I’ve attached the file.

Thanks for the information.
xml2rfc should emit an error in this instance without crashing.
I have created https://github.com/ietf-tools/xml2rfc/issues/769 to 
capture this issue.

  --Kesara
> 
>> This is because xml2rfc has logic that checks for a month if the year is not the current year.
>> There's an existing issue recorded for this to cover this to a warning [1].
>>
>> Cheers,
>> Kesara
>>
>> [1] https://github.com/ietf-tools/xml2rfc/issues/704
>>
>> On 6/05/22 1:18 am, David R. Oran wrote:
>>> I mistakenly typed the year “2016” into the date field for a draft update and it crashed xml2rfc rather than reporting an input error:
>>>
>>> oran@ORAN-M-51B7 icn-pathsteering % xml2rfc --text --pdf --html draft-oran-icnrg-pathsteering-06.xml
>>> Traceback (most recent call last):
>>>     File "/usr/local/bin/xml2rfc", line 8, in <module>
>>>       sys.exit(main())
>>>     File "/usr/local/lib/python3.9/site-packages/xml2rfc/run.py", line 739, in main
>>>       xmlrfc.tree = prep.prep()
>>>     File "/usr/local/lib/python3.9/site-packages/xml2rfc/writers/preptool.py", line 216, in prep
>>>       tree = self.dispatch(self.selectors)
>>>     File "/usr/local/lib/python3.9/site-packages/xml2rfc/writers/base.py", line 1925, in dispatch
>>>       func(e, e.getparent())
>>>     File "/usr/local/lib/python3.9/site-packages/xml2rfc/writers/preptool.py", line 419, in check_attribute_values
>>>       if i and not i.isdigit() and not i==self.get_attribute_defaults(c.tag)[a]:
>>> KeyError: 'year'
>>> oran@ORAN-M-51B7 icn-pathsteering %
>>>
>>> DaveO
>>>
>>> _______________________________________________
>>> xml2rfc mailing list
>>> [e-mail]
>>> https://www.ietf.org/mailman/listinfo/xml2rfc
>>
>> -- 
>> Kesara Rathnayake
>> Senior Software Development Engineer - IETF LLC
>> [e-mail]
> DaveO

-- 
Kesara Rathnayake
Senior Software Development Engineer - IETF LLC
[e-mail]