[yang-doctors] Yangdoctors early review of draft-ietf-rtgwg-routing-types-02
Radek Krejčí <rkrejci@cesnet.cz> Tue, 25 April 2017 14:33 UTC
Return-Path: <rkrejci@cesnet.cz>
X-Original-To: yang-doctors@ietf.org
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id A257913166C; Tue, 25 Apr 2017 07:33:34 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Radek Krejčí <rkrejci@cesnet.cz>
To: yang-doctors@ietf.org
Cc: rtgwg@ietf.org, draft-ietf-rtgwg-routing-types.all@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.50.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <149313081463.20674.12248799201489075415@ietfa.amsl.com>
Date: Tue, 25 Apr 2017 07:33:34 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/KljznQR23UvGrFJKcIaDOdLcwFc>
Subject: [yang-doctors] Yangdoctors early review of draft-ietf-rtgwg-routing-types-02
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.22
List-Id: email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Apr 2017 14:33:35 -0000
Reviewer: Radek Krejčí Review result: Ready with Nits YANG module: - add reference to import statements (both imports are from RFC 6021) - use IETF boilerplate with contact and description with copyright - cleanup unnecessary comments (such as "address-family" before the address-family identity, in general those starting with // in typedefs section) - keep blank lines before and _after_ section comments (/*** ***/) to be consistent with other ietf-*-types documents - timer-multiplier - think about renaming this type. According to the description, the value should be interpreted as a kind of limit or threshold, multiplier is not commonly understood as kind of restriction/limitation, but maybe this is just my personal feeling, handle this as an input from a reader, not a YANG doctor. draft: - section 7.1 Normative references MUST contain references to all the imported modules, so you are missing references to RFC 6021. You also SHOULD/MAY add the references to the documents referenced in the module (such as RFC 4360 and others) to the appropriate Reference section in the draft. Radek
- [yang-doctors] Yangdoctors early review of draft-… Radek Krejčí
- Re: [yang-doctors] Yangdoctors early review of dr… Martin Bjorklund
- Re: [yang-doctors] Yangdoctors early review of dr… Acee Lindem (acee)
- Re: [yang-doctors] Yangdoctors early review of dr… Acee Lindem (acee)
- Re: [yang-doctors] Yangdoctors early review of dr… Jeff Tantsura