Re: [yang-doctors] Yangdoctors early review of draft-ietf-i2rs-rib-data-model-09
Ebben Aries <exa@juniper.net> Sat, 24 February 2018 02:31 UTC
Return-Path: <exa@juniper.net>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 04A061201F2; Fri, 23 Feb 2018 18:31:34 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=juniper.net
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kpLIaBGpBK3G; Fri, 23 Feb 2018 18:31:30 -0800 (PST)
Received: from mx0b-00273201.pphosted.com (mx0b-00273201.pphosted.com [67.231.152.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 77FE012422F; Fri, 23 Feb 2018 18:31:30 -0800 (PST)
Received: from pps.filterd (m0108162.ppops.net [127.0.0.1]) by mx0b-00273201.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w1O2VREJ024561; Fri, 23 Feb 2018 18:31:27 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=PPS1017; bh=uGFQwk9SBJADt6Y+4xSG+6ldwVhvqQfpx1g9k+NiRuU=; b=RDlzQ2NcwB9rLjqQfaJqvgmLJKyHUxIGbB09y3sAujZRF8FBk4+MgICa5aiqBb0b+Upn ZFWJZKzoBMrPbjvWyZSQwEW0wV9l8GSYBSIy3gF3zT5G9VXbEUd9ajnQg0AGFxhhRXbT ErUf5BybEJvRwkUhWlcAOfb8QnQ6iMCB4C4Bcfb86KZ1QCRfZJsRvcIv0eG8/D/AxCK7 v/mZA5jioGQZDQpju3GofKqhyatUHbsjCeeD0W9fZYjJmcuIkNTDXoK3fL7kopDGyvJt S17owBSq0itxn99CcU7TAXziiaRK9AKtY/UYzqXfy95tRfNSKYQR47l30zJmPRJlyNvk 9A==
Received: from nam01-by2-obe.outbound.protection.outlook.com (mail-by2nam01lp0177.outbound.protection.outlook.com [216.32.181.177]) by mx0b-00273201.pphosted.com with ESMTP id 2gayamg015-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 23 Feb 2018 18:31:27 -0800
Received: from BLUPR05CA0062.namprd05.prod.outlook.com (10.141.20.32) by BY2PR05MB582.namprd05.prod.outlook.com (10.141.219.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.527.6; Sat, 24 Feb 2018 02:31:23 +0000
Received: from BY2NAM05FT042.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e52::201) by BLUPR05CA0062.outlook.office365.com (2a01:111:e400:855::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.548.6 via Frontend Transport; Sat, 24 Feb 2018 02:31:22 +0000
Received-SPF: SoftFail (protection.outlook.com: domain of transitioning juniper.net discourages use of 66.129.239.12 as permitted sender)
Received: from p-emfe01a-sac.jnpr.net (66.129.239.12) by BY2NAM05FT042.mail.protection.outlook.com (10.152.100.179) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.548.7 via Frontend Transport; Sat, 24 Feb 2018 02:31:22 +0000
Received: from p-mailhub01.juniper.net (10.47.226.20) by p-emfe01a-sac.jnpr.net (172.24.192.21) with Microsoft SMTP Server (TLS) id 14.3.123.3; Fri, 23 Feb 2018 18:31:22 -0800
Received: from smtp.juniper.net (contrail-ubm-exa.svec.juniper.net [10.163.2.159]) by p-mailhub01.juniper.net (8.14.4/8.11.3) with ESMTP id w1O2VEml002376; Fri, 23 Feb 2018 18:31:20 -0800 (envelope-from exa@juniper.net)
Date: Fri, 23 Feb 2018 19:31:14 -0700
From: Ebben Aries <exa@juniper.net>
To: Amit Dass <amit.dass@ericsson.com>
CC: "yang-doctors@ietf.org" <yang-doctors@ietf.org>, "i2rs@ietf.org" <i2rs@ietf.org>, "draft-ietf-i2rs-rib-data-model.all@ietf.org" <draft-ietf-i2rs-rib-data-model.all@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>
Message-ID: <20180224023114.hvp3qkqlva27ntio@smtp.juniper.net>
References: <151626438402.10775.7250014155413667607@ietfa.amsl.com> <HE1PR0702MB3580F99E1E4BBB98E84D1DF593CF0@HE1PR0702MB3580.eurprd07.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <HE1PR0702MB3580F99E1E4BBB98E84D1DF593CF0@HE1PR0702MB3580.eurprd07.prod.outlook.com>
X-EOPAttributedMessage: 0
X-MS-Office365-Filtering-HT: Tenant
X-Forefront-Antispam-Report: CIP:66.129.239.12; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10019020)(2980300002)(199004)(189003)(13464003)(6246003)(7696005)(5660300001)(105596002)(6306002)(966005)(86362001)(575784001)(81156014)(8676002)(106466001)(4326008)(23726003)(76176011)(68736007)(50466002)(8936002)(97756001)(1076002)(54906003)(336011)(6666003)(186003)(2950100002)(6916009)(47776003)(6346003)(46406003)(59450400001)(53546011)(77096007)(26005)(69596002)(53416004)(229853002)(5890100001)(16586007)(305945005)(97736004)(42262002); DIR:OUT; SFP:1102; SCL:1; SRVR:BY2PR05MB582; H:p-emfe01a-sac.jnpr.net; FPR:; SPF:SoftFail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en;
X-Microsoft-Exchange-Diagnostics: 1; BY2NAM05FT042; 1:X5ISSf2d0dduztkpDQ610bV7mb6NMzIaijf3IYkT5yEwvF/nustLB3pWdVQNf0gBdbzN12VOhQNhEGhdl+J414DOaE+/RFnJR31sz7p2pMAcVHCP3xpfWiScVyQTi6+N
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7bdc1d56-0e6f-4d87-1c7c-08d57b2eb1dc
X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060); SRVR:BY2PR05MB582;
X-Microsoft-Exchange-Diagnostics: 1; BY2PR05MB582; 3:+oBHg5hA9KB7bAZeyquc426nVa5fehtt9Yu6MbgOI2oByePFNMb2xz0eoPpyNHxGTYXCTy4gfQxxyPtISHnbaOq4LoJebWs6+AC0B+4BlyHrQGcVHoRsOgn7yQS1L/GQI2vPy6jMonKE9ealegy4guYd4gMRakCXhv/HYbs9dau0xyHnukC7rkHIVE3XlIzD7ZlgDYP0aYM40erdBAI1Jftv4GALjmi8DSkE/EuqWjg1/AbmmMTD52Z5FKl47InohqXGwRwGFQRK8csF19iMuAJxQT7arnS/KVuAlRpnj+veLKMCUOaxcZit1cKcxCud7GGPYBhWXUXHUvSXtlK1odUbXi9i+unPW9zqQOQKhGk=; 25:+wlr6v3dCZHXNp/wosnaVR2W6g9qtKSgjwm9JVzg0JBSoPUdC6WWq7MlgZ+DPoE6arU/PcWO30xt0/LPsdaMzI9vxkYIgTs8ccQRo7AwwXfbixFktjHNedIFeVciAjZYvG4kHl8W/X814Pzdn5vD2VbHZYWBMp7Ny3KnKIRA8ba7Rw9q12Ex37ukuYrLDY38bx2ixg5G5uoSVjHmRmfI2qqlDrTPXNgx74BtbykfLiU2IK5hkJghQjnsMVIC4ClQa+MAwgC7pzdGo/RmULiAMWZZ032SrBSctBYPfbzAJoXRHBWXPG7JeTRoD21QMR8v/3+BFlbA0z6U04LbspqznQ==
X-MS-TrafficTypeDiagnostic: BY2PR05MB582:
X-Microsoft-Exchange-Diagnostics: 1; BY2PR05MB582; 31:kIPK6p8oma7rbSuSMJXcqN2IufKodbEwtnvggcA9LWs4NecGtJCn8XnYXiaMJAHjaNQkr3vmhiWLO3pLYzRTl0GklD7TRFBWL1Z6Dx4cW8XhgSfNpn6FEbNRDTu9GtSw2WGdzcR9QLxeBfUl6uwP6VA5YVs8W+oKyXudGcWh/P55YIO051y/Y65JNOF4BuZi3YXtja/wpEcNF4PQ+a7tiqRNfBd7YDomBZ7qc9yKisY=; 20:LnCYQb2akYyGhPRRv7ITcTa6uu6zhFdljVNkksIrHH2+sblqVjORIxG0wXMnbbUaZ3tY0lnNyiu2DA7b3kbpzQKu/1ZAuWp79DhMh8jZj+ih4KoUAg+vUuZrlDXxTlHeClUpJjrET71QmWSVTuXD8wqSe+U96TEjZCt00jPPCs7cyogcPXu139x0Lnab7qI35aZ7Q+Q3OEwM90H7FxCexjYl05+ft+Z33pJu9jDmyyc8s8Y6I4MRyN/IL7P7zh584HKevweaz8/ICJ35UioobTNlmfWNSfiZl98BvBW46DEGWAp4+oguAdc3CF+FvV0S8wBrY9ZFuoplpjRbfcLJ0jhk+q2Ve4nNg4rBaruI5Mq6a1C4OYh8v5AFYZfbkDoxREYJmbUcXCIX+fz42fRoc9cqlH+TOoWKtdCUeR2z+PXFqowpYjOtEnsHI+/hXWMoKGdjZHOLH8evQD41Lm4i3NacXed5oN7iHjN7OOg9zPequhWAgUBxMn4sOllWLZnP
X-Forefront-PRVS: 0593E261C4
X-Microsoft-Exchange-Diagnostics: 1; BY2PR05MB582; 23:cOJytIuiAhyNavJEcXdyOZ0pXY4r0TtaGqMAhdL9KIHBlyvr/pr1ya5Dm2x+6lQp9iQs56Sdz3oHbJ9w3Sr8VioeAuiXPds1fq8VRSMJVqqTRtyic7LST3gj2LvvwjsxTZLNICCyyiEAizFasa3KGsu9LaSQcPedRpt578XyxFw+y+XIhw3pE2Bmjd1zM3Eub2xoXUqds/Y25HRFOmkN/ml6u5KCsY0fwzzwtm1ioLKQbZkxE34FHZDKq3ncoXmbsT+u+LaRCRm+DS0t8u/yiunbxlE65S/fOrCNCBa1hg4ZyV7F8g/q/5vAow1HvMM+fkio/qbF0opy9s9ykFJH73HRw6eAlFNexmWnuEmckUMR5wQM67fztJC+4SoNNzpwYyzEI/WYkuXKc4xpupLqHQ8EAn1MlE+/ZH50xMHlOY68LNsHsCtfndTuEnPOLiAse2r8LU+uAa2ldJe17YBVH8oUMEvEczcyWI0E9w9s24xlfqb+LbtCekOMKd/NzPuRxvKuwqU73on779YwZsmCOqrWhMi1VzLnBQywQo/ekBHy2qVQEuCefbqnEaW5vws/FqWHRk8xjGQY99xWGg7ESLv6/Uh1JrkkBwqGPA+YwbOpU4TqU8r8/gNv/mtnORDyzRNZithVJifEzGpgo2ukxgX2z7CF8qAm0poSr/j7gu5tsNB51J99NpctolqWtWjGC97+WsXsMn0PD2uTDlBE8bfkB5sn7WQsHAYNVQy3/GyXf4qhCstYoRl7ijEqaIm5TC1nBOLnDJWCbuUNT3AGDtZTvfqs0oe7hmytUF1/N7bM/Oz4K415epohoK5CCnE4XrzfECH0qcgV5Nb21gGsFf27dc6tAQ4sN1pOX2t2F8RQEd8RyLRCqC1xHo2mSIyupd15cfJ3jDL9CUxAIOnLeAFh35fr/y+mx5gEt0j7kO93to14HQVNh/Eu6LMndx6eJjTTPuxVJjH8O1gb0owXz2iTnHCIxjVD9am2s4ovuipSv51TxDNkcbUUuOAM3cZ00c74AHZ/wPAHpfB1ARKLHA==
X-Microsoft-Exchange-Diagnostics: 1; BY2PR05MB582; 6:X7jJ9pnCKd7SItu6BKdVe6vehWYz0rxi3iGdb2ZMRohU6+CLK0cnlgJ6QO4QydOfslK4wFYKRmxxTrMKuvEMY87wRKZD79ZV9LadFvrkq9lwkSR08mlKIT8XiV29WItTVcjTAzmv944+u/zH0p20jUPj1E+fULAvYeaGSNti3vGcCjZ0WpJCOM4wETLXyVhYTc6HczmrtHCN9pB/eOOILUtTfyQQ+L8UfF3fxwf4SRRDDjYhzEQXDuPWbugR1uQb72FARdCX5uxc7F6oEbbjVzeEhg4b4A6A6QNsWz4CQdot6DZQDykZqYEsrzyIxx73qQEHCunvyVRoNjQZOcnkO9N3bj5bkRCA2ZGhMwTy2jY=; 24:FUdqgpN9QMMAhZCmcR1WwuQe0vN3RoCdfT4oBsNrcl5qkQ8U2f4Mr2X8hyacqMuCdvD/akb4LAQWTIdVeDCS+3wO3I0YtpIlZyK675a3jyE=; 7:iOQEn4pb5CtQexlxu0zh50d+5LtQu5+7/ajcG4/NV+PwGeaf6ho+DvBlHNZ58//r57BdavLUExCf3h/X9QR4Vg5DNTl64eVOMOxWTOJ5RAUkx8JngKgp7Uytmo20DK79SCJSXA6Pt9Eb96tyIKnksIlGiaY1R9xcQnMzoFCLy4mL1pzSzB0W68lwzooZOGlOKCAaY7CJltuyzg4Q3PeMFVoFeflJ7CgNezWd6UKSr44pkRitmI2dt1Q4r83ffTp9
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-OriginatorOrg: juniper.net
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2018 02:31:22.3153 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 7bdc1d56-0e6f-4d87-1c7c-08d57b2eb1dc
X-MS-Exchange-CrossTenant-Id: bea78b3c-4cdb-4130-854a-1d193232e5f4
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bea78b3c-4cdb-4130-854a-1d193232e5f4; Ip=[66.129.239.12]; Helo=[p-emfe01a-sac.jnpr.net]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR05MB582
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2018-02-23_10:, , signatures=0
X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1802240027
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/MWaTTIQkM2MwqV4eBE8LXoLUGNc>
Subject: Re: [yang-doctors] Yangdoctors early review of draft-ietf-i2rs-rib-data-model-09
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Feb 2018 02:31:34 -0000
Amit, I took your latest pre -11 .xml revision that you attached so below is a re-review against -10 and pre (-11). Comments below Compilation error that was introduced between -10 and -11 - ietf-i2rs-rib@2017-12-05.yang:1224: error: unexpected keyword "range" leaf hop-limit { type uint8; range "1..255"; description "The path hop limit header."; } - Also, by introducing a range on a uint8, are you saying that a hop-limit=0 would never be in use for any use-case here? There are formatting and alignment issues all throughout the document that need fixing (Mahesh pointed this out as well) 'ietf-interfaces' import carries the wrong RFC reference (RFC 7227) - This should rather be RFC 7277 There are still ongoing discussions among yang-doctors on how references in imports should be treated. At a minimum for now, lets carry the expanded syntax w/ the title of the RFC as such: (As Mahesh previous mentioned, this is subject to change pending further discussion) - reference "RFC 6991: Common YANG Data Types"; - reference "RFC 7277: A YANG Data Model for IP Management"; - reference "RFC 6991: Common YANG Data Types"; Module description still does not carry full copyright/distribution section as specified in: https://tools.ietf.org/html/draft-ietf-netmod-rfc6087bis-15#appendix-C There still appears to be one remaining 'Rib' reference - s/Routing Instance and Rib/Routing Instance and RIB/ Section 1.2 - Tree Diagrams - The text here is an instruction template rather than what the actual text should be. It should rather read: A simplified graphical representation of the data model is used in this document. The meaning of the symbols in these diagrams is defined in [I-D.ietf-netmod-yang-tree-diagrams]. You did not address my previous comment/question re: NMDA (Tom mentioned this as well) You did not address my previous comment/question re: Section 2.5 (route-add RPC) I still have concern to modules introducing large amounts of features/if-features as previously noted but will defer to other's comments on this as well Formatting nits: - L3605: s/route:A/route: A/ - L3610: s/from\/to RIB/from\/to a RIB/ - L3610: s/lead to suboptimal/lead to a suboptimal/ - L3611: s/possibly/possible/ - L3626: s/his/their/ Tom's previous comment re: ENABLE_IP_RPF_CHECK has not been addressed and exists in both -10 and (pre) -11 versions Thx /ebben On Feb 20 15:24 PM, Amit Dass wrote: > Hi Ebben, > > I have updated the draft based on your comments. Could you please have a look at the same and provide your feedback? > > https://urldefense.proofpoint.com/v2/url?u=https-3A__datatracker.ietf.org_doc_draft-2Dietf-2Di2rs-2Drib-2Ddata-2Dmodel_&d=DwIGaQ&c=HAkYuh63rsuhr6Scbfh0UjBXeMK-ndb3voDTXcWzoCI&r=GIehbDpQlo31lSi6WbnEkA&m=Bd9RZ2mCWMYNPyhFBtSbqwApeVo8_SOmuA3FNG3trxA&s=h0scwYvh7UsfradRz7u1meraj47zZhr6vH3qiHJXiZ4&e= > > Best regards, > Amit > > -----Original Message----- > From: Ebben Aries [mailto:exa@juniper.net] > Sent: Thursday, January 18, 2018 9:33 AM > To: yang-doctors@ietf.org > Cc: i2rs@ietf.org; draft-ietf-i2rs-rib-data-model.all@ietf.org; ietf@ietf.org > Subject: Yangdoctors early review of draft-ietf-i2rs-rib-data-model-09 > > Reviewer: Ebben Aries > Review result: On the Right Track > > 1 module in this draft: > - ietf-i2rs-rib@2017-12-05.yang > > No YANG validation errors or warnings (from pyang 1.7.3 and yanglint 0.14.59) > > 0 examples are provided in this draft (section 3.12 of > draft-ietf-netmod-rfc6087bis-15) > > Module ietf-i2rs-rib@2017-12-05.yang: > - yang-version statement missing - should be 1.1 > - prefix 'iir' is recommended for this module, would 'rib' suffice better? > - import "ietf-inet-types" should reference RFC 6991 per (not as a comment) > https://urldefense.proofpoint.com/v2/url?u=https-3A__tools.ietf.org_html_draft-2Dietf-2Dnetmod-2Drfc6087bis-2D15-23section-2D4.7&d=DwIGaQ&c=HAkYuh63rsuhr6Scbfh0UjBXeMK-ndb3voDTXcWzoCI&r=GIehbDpQlo31lSi6WbnEkA&m=Bd9RZ2mCWMYNPyhFBtSbqwApeVo8_SOmuA3FNG3trxA&s=dYhxw9bO0Uk78WJ5uTBmc5ZcElOT446ETFp7DXU546s&e= > - import "ietf-interfaces" should reference RFC 7223 per > https://urldefense.proofpoint.com/v2/url?u=https-3A__tools.ietf.org_html_draft-2Dietf-2Dnetmod-2Drfc6087bis-2D15-23section-2D4.7&d=DwIGaQ&c=HAkYuh63rsuhr6Scbfh0UjBXeMK-ndb3voDTXcWzoCI&r=GIehbDpQlo31lSi6WbnEkA&m=Bd9RZ2mCWMYNPyhFBtSbqwApeVo8_SOmuA3FNG3trxA&s=dYhxw9bO0Uk78WJ5uTBmc5ZcElOT446ETFp7DXU546s&e= > - import "ietf-yang-types" should reference RFC 6991 per > https://urldefense.proofpoint.com/v2/url?u=https-3A__tools.ietf.org_html_draft-2Dietf-2Dnetmod-2Drfc6087bis-2D15-23section-2D4.7&d=DwIGaQ&c=HAkYuh63rsuhr6Scbfh0UjBXeMK-ndb3voDTXcWzoCI&r=GIehbDpQlo31lSi6WbnEkA&m=Bd9RZ2mCWMYNPyhFBtSbqwApeVo8_SOmuA3FNG3trxA&s=dYhxw9bO0Uk78WJ5uTBmc5ZcElOT446ETFp7DXU546s&e= > - Since this module imports "ietf-interfaces", a normative references must be > added per > https://urldefense.proofpoint.com/v2/url?u=https-3A__tools.ietf.org_html_draft-2Dietf-2Dnetmod-2Drfc6087bis-2D15-23section-2D3.9&d=DwIGaQ&c=HAkYuh63rsuhr6Scbfh0UjBXeMK-ndb3voDTXcWzoCI&r=GIehbDpQlo31lSi6WbnEkA&m=Bd9RZ2mCWMYNPyhFBtSbqwApeVo8_SOmuA3FNG3trxA&s=IaSTmgPV-jaH8vLp0nasBDWLSQ9-dDRqYwAkIvsNfkY&e= > - prefix "if" in the import "ietf-interfaces" can remove quotes to remain > consistent with other imports > - Remove WG Chairs from contact information per > https://urldefense.proofpoint.com/v2/url?u=https-3A__tools.ietf.org_html_draft-2Dietf-2Dnetmod-2Drfc6087bis-2D15-23appendix-2DC&d=DwIGaQ&c=HAkYuh63rsuhr6Scbfh0UjBXeMK-ndb3voDTXcWzoCI&r=GIehbDpQlo31lSi6WbnEkA&m=Bd9RZ2mCWMYNPyhFBtSbqwApeVo8_SOmuA3FNG3trxA&s=1U0JCnUyX_pqexjCB9KgzvhWsdLDQMN_iOgkNv29dEs&e= > - Module description must contain most recent copyright notice per > https://urldefense.proofpoint.com/v2/url?u=https-3A__tools.ietf.org_html_draft-2Dietf-2Dnetmod-2Drfc6087bis-2D15-23appendix-2DC&d=DwIGaQ&c=HAkYuh63rsuhr6Scbfh0UjBXeMK-ndb3voDTXcWzoCI&r=GIehbDpQlo31lSi6WbnEkA&m=Bd9RZ2mCWMYNPyhFBtSbqwApeVo8_SOmuA3FNG3trxA&s=1U0JCnUyX_pqexjCB9KgzvhWsdLDQMN_iOgkNv29dEs&e= > - Module description should contain note to RFC Ed. and placeholder reference > to RFC when assigned > https://urldefense.proofpoint.com/v2/url?u=https-3A__tools.ietf.org_html_draft-2Dietf-2Dnetmod-2Drfc6087bis-2D15-23appendix-2DC&d=DwIGaQ&c=HAkYuh63rsuhr6Scbfh0UjBXeMK-ndb3voDTXcWzoCI&r=GIehbDpQlo31lSi6WbnEkA&m=Bd9RZ2mCWMYNPyhFBtSbqwApeVo8_SOmuA3FNG3trxA&s=1U0JCnUyX_pqexjCB9KgzvhWsdLDQMN_iOgkNv29dEs&e= > - Add placeholder reference and note to RFC Ed. for RFC when assigned > https://urldefense.proofpoint.com/v2/url?u=https-3A__tools.ietf.org_html_draft-2Dietf-2Dnetmod-2Drfc6087bis-2D15-23appendix-2DC&d=DwIGaQ&c=HAkYuh63rsuhr6Scbfh0UjBXeMK-ndb3voDTXcWzoCI&r=GIehbDpQlo31lSi6WbnEkA&m=Bd9RZ2mCWMYNPyhFBtSbqwApeVo8_SOmuA3FNG3trxA&s=1U0JCnUyX_pqexjCB9KgzvhWsdLDQMN_iOgkNv29dEs&e= > - Security Considerations should be updated to reflect new template at > https://urldefense.proofpoint.com/v2/url?u=https-3A__trac.ietf.org_trac_ops_wiki_yang-2Dsecurity-2Dguidelines&d=DwIGaQ&c=HAkYuh63rsuhr6Scbfh0UjBXeMK-ndb3voDTXcWzoCI&r=GIehbDpQlo31lSi6WbnEkA&m=Bd9RZ2mCWMYNPyhFBtSbqwApeVo8_SOmuA3FNG3trxA&s=tfCcnSFoI3jjNNzCj6pgkp94JZ-quOQEqMlv9hITBog&e= > - Section 1.2 should be replaced with reference to > draft-ietf-netmod-yang-tree-diagrams-02 rather (as-is in other i2rs YANG > drafts in progress) per > https://urldefense.proofpoint.com/v2/url?u=https-3A__tools.ietf.org_html_draft-2Dietf-2Dnetmod-2Drfc6087bis-2D15-23section-2D2.5.1&d=DwIGaQ&c=HAkYuh63rsuhr6Scbfh0UjBXeMK-ndb3voDTXcWzoCI&r=GIehbDpQlo31lSi6WbnEkA&m=Bd9RZ2mCWMYNPyhFBtSbqwApeVo8_SOmuA3FNG3trxA&s=DjKFw7t6_CU_2_03rwIHxgvz5_oC5mjX_rMUC5UuV6M&e= > - This module contains '12' features. While it is understood the purpose of > these features in the module, take precaution as to complexity for clients > if they need to understand >= quantity of features per module in use on a > network-element. > - A few comments exist that are either unecessary or redundant. Encode the > comment intent rather in description fields if need be. > - Per NMDA, which datastores are targeted for the module? Will all RPC > operations be acting upon the dynamic/ephemeral datastore? It is not clear > to me if the intention is to be persistent or ephemeral > > General comments/Nits: > - references to 'def' could be expanded out to 'definition' > - references to 'decap' could be expanded out to 'decapsulation' for > readability (across definitions and descriptions) > - Follow consistent capitalization of 'RIB' throughout document text. Mixed > use of 'Rib' and 'rib' exists (Outside of YANG node lowercase definitions). > - Is it necessary to prefix all nodes under the nexthop container with > "nexthop-"? > - Section 2.5 - route-add RPC - text mentions it is required that the nh-add > RPC be called as a pre-requisite however if the nh already exists and the > nexthop-id is known, this should not be necessary. In addition, the text > reads 'or return' which should rather be a result of querying the > appropriate node in the data tree. > - In 'IANA Considerations' - s/This document requests to register/This > document registers/ >
- [yang-doctors] Yangdoctors early review of draft-… Ebben Aries
- Re: [yang-doctors] Yangdoctors early review of dr… Amit Dass
- Re: [yang-doctors] Yangdoctors early review of dr… Susan Hares
- Re: [yang-doctors] Yangdoctors early review of dr… Amit Dass
- Re: [yang-doctors] Yangdoctors early review of dr… Amit Dass
- Re: [yang-doctors] Yangdoctors early review of dr… Mahesh Jethanandani
- Re: [yang-doctors] [i2rs] Yangdoctors early revie… t.petch
- Re: [yang-doctors] Yangdoctors early review of dr… Ebben Aries
- Re: [yang-doctors] Yangdoctors early review of dr… Ebben Aries
- Re: [yang-doctors] Yangdoctors early review of dr… Reshad Rahman (rrahman)