IETF Logo Mail Archive

Re: [yang-doctors] Yangdoctors last call review of draft-ietf-opsawg-yang-vpn-service-pm-07

"Wubo (lana)" <lana.wubo@huawei.com> Thu, 05 May 2022 12:32 UTC

Return-Path: <lana.wubo@huawei.com>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AFE68C15E6C4; Thu, 5 May 2022 05:32:10 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.9
X-Spam-Level:
X-Spam-Status: No, score=-6.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Nx7xT1Bzr3ej; Thu, 5 May 2022 05:32:07 -0700 (PDT)
Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DF89BC15E41D; Thu, 5 May 2022 05:32:06 -0700 (PDT)
Received: from fraeml742-chm.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4KvCgM32fsz6H772; Thu, 5 May 2022 20:29:19 +0800 (CST)
Received: from kwepemi100014.china.huawei.com (7.221.188.106) by fraeml742-chm.china.huawei.com (10.206.15.223) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 5 May 2022 14:32:03 +0200
Received: from kwepemi500014.china.huawei.com (7.221.188.232) by kwepemi100014.china.huawei.com (7.221.188.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 5 May 2022 20:32:01 +0800
Received: from kwepemi500014.china.huawei.com ([7.221.188.232]) by kwepemi500014.china.huawei.com ([7.221.188.232]) with mapi id 15.01.2375.024; Thu, 5 May 2022 20:32:01 +0800
From: "Wubo (lana)" <lana.wubo@huawei.com>
To: Radek Krejčí <radek.krejci@gmail.com>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>
CC: "draft-ietf-opsawg-yang-vpn-service-pm.all@ietf.org" <draft-ietf-opsawg-yang-vpn-service-pm.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "opsawg@ietf.org" <opsawg@ietf.org>
Thread-Topic: Yangdoctors last call review of draft-ietf-opsawg-yang-vpn-service-pm-07
Thread-Index: AQHYWhPz1ARoi9voTkWq6BfPiyeU3K0QQXkA
Date: Thu, 05 May 2022 12:32:01 +0000
Message-ID: <8237cfa06f334233931c1c72a9fd08cb@huawei.com>
References: <165104936951.1514.14609727937060271565@ietfa.amsl.com>
In-Reply-To: <165104936951.1514.14609727937060271565@ietfa.amsl.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.136.98.73]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/Ocwq1p9TDNfkM6QGY_zACfqNcig>
Subject: Re: [yang-doctors] Yangdoctors last call review of draft-ietf-opsawg-yang-vpn-service-pm-07
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 05 May 2022 12:32:10 -0000

Hi Radek,

Thanks for your helpful comments. We agree with your analysis and suggestions. It is acceptable to configure both PM types, although using both PM types is redundant. 
We have updated the YANG model as you suggested. 
Please see the diff: https://www.ietf.org/rfcdiff?url2=draft-ietf-opsawg-yang-vpn-service-pm-08.

Thanks,
Bo
-----Original Message-----
From: Radek Krejčí via Datatracker [mailto:noreply@ietf.org] 
Sent: Wednesday, April 27, 2022 4:49 PM
To: yang-doctors@ietf.org
Cc: draft-ietf-opsawg-yang-vpn-service-pm.all@ietf.org; last-call@ietf.org; opsawg@ietf.org
Subject: Yangdoctors last call review of draft-ietf-opsawg-yang-vpn-service-pm-07

Reviewer: Radek Krejčí
Review result: Ready with Nits

The draft addresses/fixes previous comments.

The draft, as well as the module, is well written and the only issue I've found is kind of unclear use for the /nw:networks/nw:network/nt:link/pm-attributes/vpn-pm-type choice. I don't understand the logic of having one case config true and the second one config false. Does it mean that the second one is the default? Then it should be stated in the choice. I'm not an expert in the area, but I understand the choice as a way for clients to select the type of performance monitoring. Then it is kind of confusing that I can actually select only one of the available types. What about having config true presence container in the second case and holding config false leaf(s) there, wouldn't it be more clear?

v2.41.0 | Report a Bug | By Email | System Status