[yang-doctors] Features and must-condition

"Reshad Rahman (rrahman)" <rrahman@cisco.com> Wed, 10 January 2018 21:04 UTC

Return-Path: <rrahman@cisco.com>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3CBBB12D950 for <yang-doctors@ietfa.amsl.com>; Wed, 10 Jan 2018 13:04:28 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.53
X-Spam-Level:
X-Spam-Status: No, score=-14.53 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xHqP8eJAqRjg for <yang-doctors@ietfa.amsl.com>; Wed, 10 Jan 2018 13:04:26 -0800 (PST)
Received: from alln-iport-1.cisco.com (alln-iport-1.cisco.com [173.37.142.88]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 83A341273E2 for <yang-doctors@ietf.org>; Wed, 10 Jan 2018 13:04:26 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=10108; q=dns/txt; s=iport; t=1515618266; x=1516827866; h=from:to:subject:date:message-id:mime-version; bh=L2g7a+IHtuydoODYDjugBbmJTAAl1mtkzfzI+KOJmDY=; b=GnVWGjadJWAPRftD6Bt3t6LPR8rnv9oVyF2MinC35io2YCZsoUW+0aBc H6fG7qQX0v436aI0c/FQ+Vm2Nb70JXMn069luRXPkIB8MWkR5jrVRUlMp 5ih5Wc5JxdSaBkCfJiigEtQO8Oj9kYu+d+Aaj5frCgjxy+jD+4FvIrvuc g=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0AEAgBzflZa/51dJa1eGgEBAQEBAgEBAQEIAQEBAYJKd2Z0LoQAiiSOXpNghVGCFgqFV4QsPxgBAQEBAQEBAQFrHQuFTWgBSgIEMCcEiWJkr1eCJyaKGQEBAQEBAQQBAQEBAQEBAQEfhCCCFYFXghKLPjGCNAWZcolyAoF8k0eUDpZ0AhEZAYE7AR85JYErbxVnAYIAhFaLQQGBFgEBAQ
X-IronPort-AV: E=Sophos; i="5.46,342,1511827200"; d="scan'208,217"; a="54946390"
Received: from rcdn-core-6.cisco.com ([173.37.93.157]) by alln-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2018 21:04:25 +0000
Received: from XCH-RCD-004.cisco.com (xch-rcd-004.cisco.com [173.37.102.14]) by rcdn-core-6.cisco.com (8.14.5/8.14.5) with ESMTP id w0AL4PiJ028724 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL) for <yang-doctors@ietf.org>; Wed, 10 Jan 2018 21:04:25 GMT
Received: from xch-rcd-005.cisco.com (173.37.102.15) by XCH-RCD-004.cisco.com (173.37.102.14) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Wed, 10 Jan 2018 15:04:24 -0600
Received: from xch-rcd-005.cisco.com ([173.37.102.15]) by XCH-RCD-005.cisco.com ([173.37.102.15]) with mapi id 15.00.1320.000; Wed, 10 Jan 2018 15:04:25 -0600
From: "Reshad Rahman (rrahman)" <rrahman@cisco.com>
To: "yang-doctors@ietf.org" <yang-doctors@ietf.org>
Thread-Topic: Features and must-condition
Thread-Index: AQHTilaYFa81RoW2ZUea0h9DxiIyiQ==
Date: Wed, 10 Jan 2018 21:04:25 +0000
Message-ID: <9E242E7E-E87D-41C7-BFED-EB8185195F26@cisco.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/f.27.0.171010
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [161.44.212.183]
Content-Type: multipart/alternative; boundary="_000_9E242E7EE87D41C7BFEDEB8185195F26ciscocom_"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/QGerwNLiuzmE-GU2bToF7CJYcF8>
Subject: [yang-doctors] Features and must-condition
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Jan 2018 21:04:28 -0000

Hi,

I am doing YD review of draft-ietf-pim-msdp-yang-01. The YANG module is small but relatively speaking there’s a big number of features 17. Basically each config knob has an if-feature.

However keepalive-interval has  a dependency on holdtime-interval via must statement. Is the only way to enforce this to add “if-feature peer-timer-holdtime” to leaf keepalive-internal?

Regards,
Reshad.

         leaf holdtime-interval {
           if-feature peer-timer-holdtime;
           type uint16;
           units seconds;
           must ". > 3";
           default 75;
           description "The SA-Hold-Down-Period of this msdp peer.";
         }
         leaf keepalive-interval {
           if-feature peer-timer-keepalive;
           type uint16;
           units seconds;
           must ". > 1 and . < ../holdtime-interval";
           default 60;
           description "The keepalive timer of this msdp peer.";
         }