Re: [yang-doctors] [Netconf] Yangdoctors last call review of draft-ietf-netconf-subscribed-notifications-10

"Eric Voit (evoit)" <evoit@cisco.com> Mon, 26 March 2018 06:09 UTC

Return-Path: <evoit@cisco.com>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 142631270FC; Sun, 25 Mar 2018 23:09:34 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.51
X-Spam-Level:
X-Spam-Status: No, score=-14.51 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qjEmVfsuYHcF; Sun, 25 Mar 2018 23:09:32 -0700 (PDT)
Received: from alln-iport-2.cisco.com (alln-iport-2.cisco.com [173.37.142.89]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 54F9D126E01; Sun, 25 Mar 2018 23:09:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=14814; q=dns/txt; s=iport; t=1522044572; x=1523254172; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=bBQZwe2JxEKvN27dE+B4FZoBzGj92ZaYxJQx5dpfrDg=; b=bQLJgKAVb6NqlZHGxRfq7lVPzVNZOK0i5ALOBzeIubnMwWHLubzT8/Ys YbPtwNqAqW1JZr7mhP22/wWB3kjX8jh6/iHeHSDI+wN3bm5ZrZIb2CN8B f7lL6pzWVMMpeIqFx6EXMSNsAYvRG4t6Dq/T8H16gNlNkPa3ZGtEFrBhV 8=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0DyAADMjbha/4gNJK1eGQEBAQEBAQEBA?= =?us-ascii?q?QEBAQcBAQEBAYJNdGFwKAqDUogAjQ2BdIERjWyEZRSBcgslhGACGoNeITQYAQI?= =?us-ascii?q?BAQEBAQECayiFJQEBAQMBIwpKAgULAgEIFQMnAwICAjAUEQIEAQ0FCIQiXAgPq?= =?us-ascii?q?z+CIIg+ghUFh1iBVECBDIJZLoMTAoFGHwcoAoJJgjQgA5BKhnUIAoVQiFeBOIs?= =?us-ascii?q?JhyaBbYY8AhETAYEkARw4JoEscBWCfYJLjgVvjw2BFwEB?=
X-IronPort-AV: E=Sophos; i="5.48,363,1517875200"; d="scan'208,217"; a="89361560"
Received: from alln-core-3.cisco.com ([173.36.13.136]) by alln-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Mar 2018 06:09:31 +0000
Received: from XCH-RTP-015.cisco.com (xch-rtp-015.cisco.com [64.101.220.155]) by alln-core-3.cisco.com (8.14.5/8.14.5) with ESMTP id w2Q69UaD013676 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Mon, 26 Mar 2018 06:09:31 GMT
Received: from xch-rtp-013.cisco.com (64.101.220.153) by XCH-RTP-015.cisco.com (64.101.220.155) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Mon, 26 Mar 2018 02:09:30 -0400
Received: from xch-rtp-013.cisco.com ([64.101.220.153]) by XCH-RTP-013.cisco.com ([64.101.220.153]) with mapi id 15.00.1320.000; Mon, 26 Mar 2018 02:09:30 -0400
From: "Eric Voit (evoit)" <evoit@cisco.com>
To: Andy Bierman <andy@yumaworks.com>, Martin Bjorklund <mbj@tail-f.com>
CC: YANG Doctors <yang-doctors@ietf.org>, "draft-ietf-netconf-subscribed-notifications.all@ietf.org" <draft-ietf-netconf-subscribed-notifications.all@ietf.org>, "IETF discussion list" <ietf@ietf.org>, Netconf <netconf@ietf.org>
Thread-Topic: [Netconf] Yangdoctors last call review of draft-ietf-netconf-subscribed-notifications-10
Thread-Index: AQHTvKkZ2yiLu7ZmNEq3xAG94gtXV6PX23yQgAYbqoCAABCvgIADtY2A
Date: Mon, 26 Mar 2018 06:09:30 +0000
Message-ID: <8442444cf8434c3b9e0251185307a0e2@XCH-RTP-013.cisco.com>
References: <152115125179.4495.9379808208471040239@ietfa.amsl.com> <3447e37fe75441c59923a13ee609bdc4@XCH-RTP-013.cisco.com> <20180323.120427.640110344192892955.mbj@tail-f.com> <CABCOCHQWrmODuuiFHRfdyADsWSRAAS7ER=7wOZOmMsas6f8tbQ@mail.gmail.com>
In-Reply-To: <CABCOCHQWrmODuuiFHRfdyADsWSRAAS7ER=7wOZOmMsas6f8tbQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.24.107.151]
Content-Type: multipart/alternative; boundary="_000_8442444cf8434c3b9e0251185307a0e2XCHRTP013ciscocom_"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/XO4HGyPML5GkHtEkKo6eDCUTce8>
Subject: Re: [yang-doctors] [Netconf] Yangdoctors last call review of draft-ietf-netconf-subscribed-notifications-10
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Mar 2018 06:09:34 -0000

From: Andy Bierman, March 23, 2018 8:04 AM

On Fri, Mar 23, 2018 at 4:04 AM, Martin Bjorklund <mbj@tail-f.com<mailto:mbj@tail-f.com>> wrote:
Hi,

One comment below.


"Eric Voit (evoit)" <evoit@cisco.com<mailto:evoit@cisco.com>> wrote:
> Hi Andy,
>
>
>
> Thanks very much for the excellent comments.   Thoughts in-line...
>
>
>
> Also where changes were made, you can see them in the working copy at:
>
> https://github.com/netconf-wg/rfc5277bis/blob/master/draft-ietf-netconf-subscribed-notifications-11.txt
>
> (there are two agreed changes from the WG session to be embedded, but
> the comments below are in there.)
>
>
>
>
>
> > From: Andy Bierman, March 15, 2018 6:01 PM
>
> >
>
> > Reviewer: Andy Bierman
>
> > Review result: Almost Ready
>
> >
>
> >
>
> > 1.2 Terminology
>
> >
>
> >    Notification message: A set of transport encapsulated information
>
> >    intended for a receiver indicating that one or more event(s) have
>
> >    occurred.  A notification message may bundle multiple event records.
>
> >    This includes the bundling of multiple, independent RFC 7950 YANG
>
> >    notifications.
>
> >
>
> >   >> Cannot find any text that supports this claim; find the contrary:
>
> >     from 2.6:
>
> >        This notification
>
> >        message MUST be encoded as one-way notification element
>
> >        of [RFC5277]
>
>
>
> The reason for this more inclusive term is to permit future
> notification messages which allowing bundling.  This is as per adopted
> NETCONF draft:
>
> draft-ietf-netconf-notification-messages
>
>
>
> I believe there are advantages in using the more inclusive term now,
> rather than doing a future retrofit to this draft when
> notification-messages completes.

But later in this draft you state that there will be an update to this
document when the notification messages draft is done.

> I.e., I don't see it harming
> anything in the specification with the expansive term.

I think it will be confusing to readers to see the statement that this
document support bundling, then it says that notifs MUST be encoded as
5277 notifications.

I suggest you remove:

  A notification message may bundle multiple event records.  This
  includes the bundling of multiple, independent RFC 7950 YANG
  notifications.

+1

There is no need for this spec to say anything about different notification headers.
It is trivial to add a new parameter later to allow the client to request a different message
format.


<Eric> I have removed this part of the notification message definition.

Eric

[...]

Andy




/martin