[yang-doctors] Yangdoctors last call review of draft-ietf-netconf-tls-client-server-03

Andy Bierman <andy@yumaworks.com> Fri, 28 July 2017 22:14 UTC

Return-Path: <andy@yumaworks.com>
X-Original-To: yang-doctors@ietf.org
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id F297B1321BC; Fri, 28 Jul 2017 15:14:56 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Andy Bierman <andy@yumaworks.com>
To: yang-doctors@ietf.org
Cc: draft-ietf-netconf-tls-client-server.all@ietf.org, netconf@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.57.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <150128009697.20678.11905105517795192@ietfa.amsl.com>
Date: Fri, 28 Jul 2017 15:14:56 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/cFsXXuRvleYD6bW6Mv1oF3qfGEs>
Subject: [yang-doctors] Yangdoctors last call review of draft-ietf-netconf-tls-client-server-03
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Jul 2017 22:14:57 -0000

Reviewer: Andy Bierman
Review result: Ready with Nits

Review: draft-ietf-netconf-tls-client-server-03

Modules:
 (M1) ietf-tls-client@2017-06-13.yang
 (M2) ietf-tls-common@2017-06-13.yang
 (M3) ietf-tls-server@2017-06-13.yang


YANG Usage:

 I did not find anything wrong in either module.
 pyang and yangdump-pro do not report any errors or warnings.

Comments:

C1:

(M2) identity tls-1.2

Why are there no identities defined for tls-1.0 and tls-1.1?


C2:

Sec 1.2 Tree Diagrams

Old text should be replaced with reference to
draft-ietf-netmod-yang-tree-diagrams-01

C3:

 (M1) IETF copyright says 2014; change to 2017
 (M3) IETF copyright says 2014; change to 2017