IETF Logo Mail Archive

Re: [yang-doctors] Yangdoctors last call review of draft-ietf-netconf-ssh-client-server-03

Kent Watsen <kwatsen@juniper.net> Mon, 31 July 2017 20:23 UTC

Return-Path: <kwatsen@juniper.net>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6887A131CAE; Mon, 31 Jul 2017 13:23:26 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.021
X-Spam-Level:
X-Spam-Status: No, score=-2.021 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=juniper.net
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xJwpm4AiMhPZ; Mon, 31 Jul 2017 13:23:24 -0700 (PDT)
Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0128.outbound.protection.outlook.com [104.47.37.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 42B821318A2; Mon, 31 Jul 2017 13:23:21 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=1yL8cCtW+8FO7saFKNTOa/J9azJA8wCllC3pv6YuUeg=; b=EMReJvmHGhQfnE1Dd4YQgEUFhKajdvveftfg8RHbcDNwTOFmUt+9YWaoha6StJplIZqK0rvkm49EZWJWIDEuCYv0Ih+DO/X3dap629Q/rr+bEeIqiDGeX6zm7iymxcgyJLSm1XQ9s1z5u3dtrN6JX4efJUO1CM+DAXlx+Kc5y/w=
Received: from BN3PR0501MB1442.namprd05.prod.outlook.com (10.160.117.151) by BN3PR0501MB1139.namprd05.prod.outlook.com (10.160.113.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1320.10; Mon, 31 Jul 2017 20:23:19 +0000
Received: from BN3PR0501MB1442.namprd05.prod.outlook.com ([10.160.117.151]) by BN3PR0501MB1442.namprd05.prod.outlook.com ([10.160.117.151]) with mapi id 15.01.1320.010; Mon, 31 Jul 2017 20:23:19 +0000
From: Kent Watsen <kwatsen@juniper.net>
To: Andy Bierman <andy@yumaworks.com>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>
CC: "draft-ietf-netconf-ssh-client-server.all@ietf.org" <draft-ietf-netconf-ssh-client-server.all@ietf.org>, "netconf@ietf.org" <netconf@ietf.org>
Thread-Topic: Yangdoctors last call review of draft-ietf-netconf-ssh-client-server-03
Thread-Index: AQHTB+7XpHet5xsav0edrpS7s+2HaaJuIsUA
Date: Mon, 31 Jul 2017 20:23:19 +0000
Message-ID: <C7ABD900-ACB9-4BFC-B30D-3A7274DDB657@juniper.net>
References: <150128005005.20715.8994557350330588925@ietfa.amsl.com>
In-Reply-To: <150128005005.20715.8994557350330588925@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/f.20.0.170309
x-originating-ip: [66.129.241.11]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; BN3PR0501MB1139; 6:BujRTBRs6X3NTUpAz9SlgQcRTJnf1AfYS1O5MnvkPGc1ho7lq0W6XkLbv9ThjANTL6vuUuZEz0XjmFqVetKlCDPWk/dmaFqNJl3CbaGSF+IEE0pzsiTqbfcc6QAc6DNpBjbxwVUr1PuzzzPQqwIJgZO6QbFzexwxC6YZaFNxiphZsBKtbMU1EfXrc0yY/fd21tNy26PBpLNKczVlwfyvndZZogDuA/j7z7HakBPkjOa4y/h0smR0ZmRgMTgDolEzvkjHO0aTRsh6zLiwj9rO08wTKmsulLri2zWKfSAJY82HyPE+ra6cALL4oSqxpjnEHy6xfU4F0lmauT2oyWXxgA==; 5:r/GEUJvsAUOtvL/G5vzONyEwwIdg2At1ra7jNqVKPJSGJr40+0lvUHNm72Rg9TCWB2mA/kj0deZGc6uwX5SkG5f+Lijjc8agRgrANMEfxiiuxDQnJsA95LH/9Uj81L9zkNH7nWXg9oD2PHeUykCp5A==; 24:LQPCQ4f3FUwq0JTaR7Ym1J6szG59ypDuysfZxPwMetUOFQa1RwOK/1ETBnxxTxzsQ3kevEcOjUjBjgYzkL+KNN7cbLKKxJ6B1hB8wkPdpfk=; 7:c4rcoGepMLnc5lDqsp1i0kSyI/kslO4PX1aRJFF2kRhdJcUk+zhv+J/dPKVuZQnvU+b5eQKzCv7+7y3RumlT+KNs+iY7ZYVRHNdHUYR79BAX15jb/XPq7nv9wAZ25lt5fj5qbDnq+gqnI2h7jcrBPyYy51pEOFjvfr9XAhtrp6bAkDfq/Hyo6Ms1uyz065OQdf5QepfnQULbiRLPC85GYcpLEBa1WpfFgoeLIV2sbg4=
x-ms-office365-filtering-correlation-id: 57b2a684-80bd-428c-5c77-08d4d851fbe9
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:BN3PR0501MB1139;
x-ms-traffictypediagnostic: BN3PR0501MB1139:
x-exchange-antispam-report-test: UriScan:(166708455590820);
x-microsoft-antispam-prvs: <BN3PR0501MB1139C9057D22A92ECE4C6361A5B20@BN3PR0501MB1139.namprd05.prod.outlook.com>
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(20161123564025)(20161123560025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123555025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN3PR0501MB1139; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN3PR0501MB1139;
x-forefront-prvs: 03853D523D
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(39850400002)(39450400003)(39860400002)(39400400002)(39410400002)(39840400002)(199003)(189002)(189998001)(14454004)(2950100002)(86362001)(478600001)(66066001)(99286003)(38730400002)(2501003)(6246003)(101416001)(50986999)(53936002)(6436002)(105586002)(230783001)(82746002)(106356001)(4326008)(54356999)(76176999)(77096006)(6486002)(6512007)(54906002)(8936002)(36756003)(5660300001)(25786009)(6306002)(81166006)(8676002)(102836003)(81156014)(6116002)(229853002)(3846002)(83716003)(4001350100001)(3660700001)(305945005)(2900100001)(83506001)(966005)(33656002)(7736002)(3280700002)(68736007)(2906002)(6506006)(97736004); DIR:OUT; SFP:1102; SCL:1; SRVR:BN3PR0501MB1139; H:BN3PR0501MB1442.namprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en;
received-spf: None (protection.outlook.com: juniper.net does not designate permitted sender hosts)
authentication-results: spf=none (sender IP is ) smtp.mailfrom=kwatsen@juniper.net;
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
Content-ID: <4F6D1BE78C67104297ABF2559F38654C@namprd05.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: juniper.net
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jul 2017 20:23:19.5157 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: bea78b3c-4cdb-4130-854a-1d193232e5f4
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0501MB1139
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/cGydPrnepmAkb9YR8Uf4WBJJhIg>
Subject: Re: [yang-doctors] Yangdoctors last call review of draft-ietf-netconf-ssh-client-server-03
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 31 Jul 2017 20:23:26 -0000

Hi Andy, 

Thanks for your review.  Below are my responses to your comments.

Thanks,
Kent


--

Reviewer: Andy Bierman
Review result: Ready with Nits

Review: draft-ietf-netconf-ssh-client-server-03

Modules:
 (M1) ietf-ssh-client@2017-06-13.yang
 (M2) ietf-ssh-common@2017-06-13.yang
 (M3) ietf-ssh-server@2017-06-13.yang


YANG Usage:

 I did not find anything wrong in either module.
 pyang and yangdump-pro do not report any errors or warnings.

Comments:

C1:

 (M3) transport-params leafrefs

 Example of <transport-params> in sec. 4.2 shows ietf-ssh-common
 as the module namespace but this will never happen in real usage.

 People will copy the various identityref examples in this section
 and not encode the identityref prefix correctly.


<KENT> I added prefixes to the example.  

<KENT> This would've been caught earlier (via validation) had the
transport-params grouping contained some mandatory values, as then
the identities would have to show up in other examples (e.g., 
ex-netconf-server.xml), which would then have to encode the 
identities from another namespace.  I sent email to Gary asking
him about if any of these values are mandatory.

<KENT> Also related, I notice that there are a ton of algorithm
identities here that I'd forgotten about.  Going back to Juergen's
comment about factoring these out into another module, now it
seems more prudent than ever! I just filed an issue to track
this:  https://github.com/netconf-wg/keystore/issues/8


C2:

Sec 1.2 Tree Diagrams

Old text should be replaced with reference to
draft-ietf-netmod-yang-tree-diagrams-01

<KENT> Is this safe?  I've resisted doing this so far because I
wasn't sure if the tree-diagrams draft might break syntax...



C3:

 (M1) IETF copyright says 2014; change to 2017
 (M3) IETF copyright says 2014; change to 2017


<KENT> done!

v2.23.0 | Report a Bug | By Email