IETF Logo Mail Archive

Re: [yang-doctors] Yangdoctors last call review of draft-ietf-i2nsf-sdn-ipsec-flow-protection-08

Gabriel Lopez <gabilm@um.es> Thu, 17 September 2020 14:45 UTC

Return-Path: <gabilm@um.es>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C5C5D3A0CC4; Thu, 17 Sep 2020 07:45:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=um.es
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id haEz2eCp2RNt; Thu, 17 Sep 2020 07:45:57 -0700 (PDT)
Received: from mx01.puc.rediris.es (outbound3mad.lav.puc.rediris.es [130.206.19.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DA24B3A0CA8; Thu, 17 Sep 2020 07:45:54 -0700 (PDT)
Received: from xenon44.um.es (xenon44.um.es [155.54.212.171]) by mx01.puc.rediris.es with ESMTP id 08HEjmgu017100-08HEjmgv017100; Thu, 17 Sep 2020 16:45:48 +0200
Received: from localhost (localhost [127.0.0.1]) by xenon44.um.es (Postfix) with ESMTP id 60EDC21FE0; Thu, 17 Sep 2020 16:45:48 +0200 (CEST)
X-Virus-Scanned: by antispam in UMU at xenon44.um.es
Received: from xenon44.um.es ([127.0.0.1]) by localhost (xenon44.um.es [127.0.0.1]) (amavisd-new, port 10024) with LMTP id l4uaDxU0l5gx; Thu, 17 Sep 2020 16:45:48 +0200 (CEST)
Received: from [192.168.8.101] (18.red-79-149-253.dynamicip.rima-tde.net [79.149.253.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: gabilm@um.es) by xenon44.um.es (Postfix) with ESMTPSA id 29ECA21FC5; Thu, 17 Sep 2020 16:45:45 +0200 (CEST)
From: Gabriel Lopez <gabilm@um.es>
Message-Id: <25E0845F-72A4-4835-B195-1691CAACCF1A@um.es>
Content-Type: multipart/alternative; boundary="Apple-Mail=_B2816908-E492-4E5A-8CEB-90C3EE778638"
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\))
Date: Thu, 17 Sep 2020 16:45:43 +0200
In-Reply-To: <159827985531.30993.17722282912726281276@ietfa.amsl.com>
Cc: Gabriel Lopez <gabilm@um.es>, yang-doctors@ietf.org, last-call@ietf.org, draft-ietf-i2nsf-sdn-ipsec-flow-protection.all@ietf.org, i2nsf@ietf.org
To: Martin Björklund <mbj+ietf@4668.se>
References: <159827985531.30993.17722282912726281276@ietfa.amsl.com>
X-Mailer: Apple Mail (2.3608.120.23.2.1)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; d=um.es; s=DKIM; c=relaxed/relaxed; h=from:message-id:content-type:mime-version:subject:date:cc:to:references; bh=1wSjN28gE4f4uPMwMS1VaIpS6WiW12Cl8Mss34FnhcU=; b=q9FFE9sGqQlICmn4Rf+hXsuQYUXK9tqPszcxmVNGT7GRBcuNB4lLSxOPUREszPif1mymdoim+HdU 1CLuwglgrSwmP4DxU175Ih0OHlMoF+7U4er05CrtqmGlcqZQ79iILzKQq38k+QYlVuGFaTuQuGOv ShNOuIKlEelJOtxe0luUAdtsk/TVm+EUW5oGOyMpeK3Bp98zNGBCy8wWapBM4hmsSLo/hhKe7RRB SgU4V/BtKnNRP8PucQVLP4v2W9mThvoVpkZ4Mkxx1I51AqudCrpFVjAXnUTpcR5RJH+7gY7P8qc6 0ZjSYNZZku0q5xCiftdVNFGecqTxVqcLyZFqfQ==
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/edvlkP6yv3I1DyPMu5qDetobYf0>
Subject: Re: [yang-doctors] Yangdoctors last call review of draft-ietf-i2nsf-sdn-ipsec-flow-protection-08
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Sep 2020 14:46:00 -0000

Hi Martin.

Thank you for the review and sorry for the late response.

> El 24 ago 2020, a las 16:37, Martin Björklund via Datatracker <noreply@ietf.org> escribió:
> 
> Reviewer: Martin Björklund
> Review result: Ready with Nits
> 
> I did an early YANG Doctor's review of this draft.  Most of my
> comments then have been addressed in this version.
> 
> Comments:
> 
> o  As I wrote in my early review, the RFC editor enforces a common
>   format of YANG modules, so it is better to adhere to this format
>   before sending the draft to the RFC editor.  Use
> 
>     pyang -f yang --yang-line-length 69 <FILE>


mmm, we already applied the pyang command as you suggest, anyway, we will apply it again for the next version.


> 
>   to get a consistent look-and-feel for your module.
> 
>   (You will have to manually re-flow description statements after
>   this.)
> 
> 
> o  There are some leafs that are optional in the model, but w/o a
>   default value and w/o an explanation of what happens if that leaf
>   is not set.  You should find those and either make them mandatory,
>   add a default value, or explain what it means when it isn't set.
>   As an example,
>   /ipsec-ike/pad/pad-entrypeer-authenticatin/pre-shared/secret
>   is optional.  I suspect that this leaf needs to be mandatory.
>   Another example is the leaf espencap.


You are right. We are reviewing the text.

Best regards, Gabi.
> 
> 
> /martin
> 
> 

-----------------------------------------------------------
Gabriel López Millán
Departamento de Ingeniería de la Información y las Comunicaciones
University of Murcia
Spain
Tel: +34 868888504
Fax: +34 868884151
email: gabilm@um.es

v2.23.0 | Report a Bug | By Email