Re: [yang-doctors] Yangdoctors last call review of draft-ietf-netconf-rfc6536bis-04

Andy Bierman <andy@yumaworks.com> Mon, 11 September 2017 21:05 UTC

Return-Path: <andy@yumaworks.com>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C64921331F7 for <yang-doctors@ietfa.amsl.com>; Mon, 11 Sep 2017 14:05:58 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.599
X-Spam-Level:
X-Spam-Status: No, score=-2.599 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=yumaworks-com.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sk5nkljXCpU2 for <yang-doctors@ietfa.amsl.com>; Mon, 11 Sep 2017 14:05:56 -0700 (PDT)
Received: from mail-lf0-x235.google.com (mail-lf0-x235.google.com [IPv6:2a00:1450:4010:c07::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 955381331FD for <yang-doctors@ietf.org>; Mon, 11 Sep 2017 14:05:55 -0700 (PDT)
Received: by mail-lf0-x235.google.com with SMTP id 80so21677789lfy.4 for <yang-doctors@ietf.org>; Mon, 11 Sep 2017 14:05:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yumaworks-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=qwYEHx/IgCa+mzCK5kqEA36Zxdx1h5WHTH+25/mgf9A=; b=Tg7bf46sEWcRUV+M1QjJSDy5nthoxlvftDXwZ1HirL/5tp4hih/3JZx6gsfpI53cnK Dr0YZqXc2vBtTsXIx1ePD7BMoxZvEyv8jjX+PWc0YVc/f3WPuDTdZwH+RrbD67a89sZx Jf9Or0t0ezUQo6SxP34QrysLEqDkmEncMCWpK5IMnhQxY4gHsX7fsKqEIMR6Kvm29WuL F8X4xTceJQDxcfNjP6FKboV68nt59wG9qyv1YW5oHMXtYsuZGCaVSURzA3G1FJfvol8F GfUbH9pRn1rBReP7dKPIV1vgJi7fli9GgwFMotjlMONjLbwU5MkueJB3k66iIglOc9LG XUhg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=qwYEHx/IgCa+mzCK5kqEA36Zxdx1h5WHTH+25/mgf9A=; b=od6xtx9cC7AYl72FQS9qo/OrtnFCArQJc4pnZqjmR/LITEMFRj6o6jpNQbGTgOpoal aoEu66FLqDw8oSfRxvL7JG6cE5sX9SmEeSpS+TvBm6XnEcpFTDIKRZ8EmR/uqkYGHuMH 5DMad57EvUqcJx/iKq3FzDBndIFWZAKB5acot65TfXzH7LBqaJtq7vtdl+HD/2ZtllXS t21fveU0oBreR7HvyvDIgOD+9yqrUt4nyaPh/Hxdc1qsL+fzCgFtSGEfyblp5OmktF+n 1og8w0tXBbSaGO/8lf+C6UXydpH2/2g9qe3UE8zUFG10+ohT3vn7sUs59756huDMgIGi xgcg==
X-Gm-Message-State: AHPjjUhX6R7TBqnv0qtJ0H0OtNXAekQBDhl7b/uprXKmMZK9wNa5BF71 aX8wjhJVLMQ1yOjvZ3UlCew4OXXykThQ
X-Google-Smtp-Source: AOwi7QB7GDf8oV0eiwPskSMYMB76Z9/AGeRICJx4awn5BF9+5wFwMGl5/v2vhTk7tiWsuQH6eimf9g+i9Zoxh9rGV+U=
X-Received: by 10.25.204.198 with SMTP id c189mr5106286lfg.49.1505163953782; Mon, 11 Sep 2017 14:05:53 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.25.18.41 with HTTP; Mon, 11 Sep 2017 14:05:53 -0700 (PDT)
In-Reply-To: <150514212825.9627.4482318729492694955@ietfa.amsl.com>
References: <150514212825.9627.4482318729492694955@ietfa.amsl.com>
From: Andy Bierman <andy@yumaworks.com>
Date: Mon, 11 Sep 2017 14:05:53 -0700
Message-ID: <CABCOCHS7vRVBrytLdh0DD52Us=DcVxwOjhvuPOcQ5LBhtJ5HmA@mail.gmail.com>
To: Radek Krejčí <rkrejci@cesnet.cz>
Cc: YANG Doctors <yang-doctors@ietf.org>, draft-ietf-netconf-rfc6536bis.all@ietf.org, Netconf <netconf@ietf.org>
Content-Type: multipart/alternative; boundary="94eb2c1a07fecb5e450558f04a6e"
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/fidoCpeUmizl7KzArerr1OVw-ek>
Subject: Re: [yang-doctors] Yangdoctors last call review of draft-ietf-netconf-rfc6536bis-04
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Sep 2017 21:05:59 -0000

On Mon, Sep 11, 2017 at 8:02 AM, Radek Krejčí <rkrejci@cesnet.cz> wrote:

> Reviewer: Radek Krejčí
> Review result: Ready with Nits
>
> Hi,
> I have been assigned to review draft-ietf-netconf-rfc6536bis as YANG
> Doctor.
> The document is almost ready to publish, I have just the following few
> comments:
>
> - section 1.1 Terminology - access control rule: s/protocol
> operation/access
> operation/
>
>
fixed



> - "NETCONF transport" is mentioned at several places within the draft and
> model
> in connection with information about the user. What about the RESTCONF
> transport, shouldn't it be also mentioned or (better) shouldn't it be
> changed
> to a general transport of the protocols accessing the datastore?
>
>

changed all NETCONF transport layer to just transport layer,
which was already used in several places



> - /nacm/rule-list/rule/rule-type in schema: I would consider to explicitely
> state into which case the action and notification defined in data subtree
> belong to. Especially the notification placement can be confusing at the
> first
> sight since there is the "notification" case.
>
>
not sure what text this is about.
Do you have section, para or page/para info?


Andy