[yang-doctors] review of IEEE P802.1Qcp
Juergen Schoenwaelder <j.schoenwaelder@jacobs-university.de> Sun, 05 March 2017 10:38 UTC
Return-Path: <j.schoenwaelder@jacobs-university.de>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BE897129440 for <yang-doctors@ietfa.amsl.com>; Sun, 5 Mar 2017 02:38:40 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.2
X-Spam-Level:
X-Spam-Status: No, score=-4.2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HRyTQjPQa6XX for <yang-doctors@ietfa.amsl.com>; Sun, 5 Mar 2017 02:38:38 -0800 (PST)
Received: from atlas3.jacobs-university.de (atlas3.jacobs-university.de [212.201.44.18]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 441BA128AC9 for <yang-doctors@ietf.org>; Sun, 5 Mar 2017 02:38:38 -0800 (PST)
Received: from localhost (demetrius5.irc-it.jacobs-university.de [10.70.0.222]) by atlas3.jacobs-university.de (Postfix) with ESMTP id C65717EB; Sun, 5 Mar 2017 11:38:36 +0100 (CET)
X-Virus-Scanned: amavisd-new at jacobs-university.de
Received: from atlas3.jacobs-university.de ([10.70.0.205]) by localhost (demetrius5.jacobs-university.de [10.70.0.222]) (amavisd-new, port 10030) with ESMTP id NeQnDtWZ9rWh; Sun, 5 Mar 2017 11:38:30 +0100 (CET)
Received: from hermes.jacobs-university.de (hermes.jacobs-university.de [212.201.44.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "hermes.jacobs-university.de", Issuer "Jacobs University CA - G01" (verified OK)) by atlas3.jacobs-university.de (Postfix) with ESMTPS; Sun, 5 Mar 2017 11:38:33 +0100 (CET)
Received: from localhost (demetrius3.jacobs-university.de [212.201.44.48]) by hermes.jacobs-university.de (Postfix) with ESMTP id F331220039; Sun, 5 Mar 2017 11:38:32 +0100 (CET)
X-Virus-Scanned: amavisd-new at jacobs-university.de
Received: from hermes.jacobs-university.de ([212.201.44.23]) by localhost (demetrius3.jacobs-university.de [212.201.44.32]) (amavisd-new, port 10024) with ESMTP id rHxYojvH0tdq; Sun, 5 Mar 2017 11:38:29 +0100 (CET)
Received: from elstar.local (elstar.jacobs.jacobs-university.de [10.50.231.133]) by hermes.jacobs-university.de (Postfix) with ESMTP id DB62120037; Sun, 5 Mar 2017 11:38:28 +0100 (CET)
Received: by elstar.local (Postfix, from userid 501) id 557323E96400; Sun, 5 Mar 2017 11:38:34 +0100 (CET)
Date: Sun, 05 Mar 2017 11:38:34 +0100
From: Juergen Schoenwaelder <j.schoenwaelder@jacobs-university.de>
To: yang-doctors@ietf.org
Message-ID: <20170305103834.GA5354@elstar.local>
Mail-Followup-To: yang-doctors@ietf.org, Janos Farkas <Janos.Farkas@ericsson.com>, "mholness@ciena.com" <mholness@ciena.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="gBBFr7Ir9EOA20Yy"
Content-Disposition: inline
User-Agent: Mutt/1.6.0 (2016-04-01)
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/yZ_rKQHjp1_rKf8OTmPl7HwZa6A>
Cc: Janos Farkas <Janos.Farkas@ericsson.com>, "mholness@ciena.com" <mholness@ciena.com>
Subject: [yang-doctors] review of IEEE P802.1Qcp
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
Reply-To: Juergen Schoenwaelder <j.schoenwaelder@jacobs-university.de>
List-Id: email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 05 Mar 2017 10:38:40 -0000
Hi, attached is my review of P802.1Qcp. As usual, there are things related to YANG usage (is the YANG usage correct and proper?) and there are things related to the data model of the bridge technology (is the YANG model correct and proper?). Since I am not an expert on bridge technology, I can't really judge the later but from the way the data model is written it seems not everything is a correct model. If you want to substantially improve the model and the trust in the model being correct, here is what I recommend you to do: - Find volunteers familiar with bridg technology (not editors of the YANG data model) and let them write configurations and state data according to the YANG data model, ideally a few simple bridge configs and a few more complex ones. We sometimes call these configs instance documents. There are tools to validate instance documents against the data model. - Usually the volunteers writing instance documents spot bugs where the model is wrong (I do not know how I configure XYZ in the model) and they spot points where instance documents are unnecessarily verbose or complex. - Get the YANG data model editor and the volunteers writing instance documents together to resolve all conflicts until the instance documents are all nice and complete. Sounds like a lot of work and yes it is a lot of work. But it is essential to do this exercise if you want to have a high quality product. /js -- Juergen Schoenwaelder Jacobs University Bremen gGmbH Phone: +49 421 200 3587 Campus Ring 1 | 28759 Bremen | Germany Fax: +49 421 200 3103 <http://www.jacobs-university.de/>
- [yang-doctors] review of IEEE P802.1Qcp Juergen Schoenwaelder
- Re: [yang-doctors] review of IEEE P802.1Qcp Holness, Marc
- Re: [yang-doctors] review of IEEE P802.1Qcp János Farkas
- Re: [yang-doctors] review of IEEE P802.1Qcp Juergen Schoenwaelder
- Re: [yang-doctors] review of IEEE P802.1Qcp Holness, Marc
- Re: [yang-doctors] review of IEEE P802.1Qcp Holness, Marc
- Re: [yang-doctors] review of IEEE P802.1Qcp Benoit Claise
- Re: [yang-doctors] review of IEEE P802.1Qcp Holness, Marc