Re: [Ace] Shepard comments draft-ietf-ace-coap-est-08

Peter van der Stok <stokcons@bbhmail.nl> Mon, 18 February 2019 14:13 UTC

Return-Path: <stokcons@bbhmail.nl>
X-Original-To: ace@ietfa.amsl.com
Delivered-To: ace@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7F605130F0D; Mon, 18 Feb 2019 06:13:58 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=bbhmail.nl
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HsZv5zWKHlkq; Mon, 18 Feb 2019 06:13:56 -0800 (PST)
Received: from smtprelay.hostedemail.com (smtprelay0133.hostedemail.com [216.40.44.133]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F30ED128B01; Mon, 18 Feb 2019 06:13:55 -0800 (PST)
Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay01.hostedemail.com (Postfix) with ESMTP id 89C8A100E86C1; Mon, 18 Feb 2019 14:13:54 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bbhmail.nl; h= mime-version:content-type:date:from:to:cc:subject:reply-to :in-reply-to:references:message-id; s=key; bh=BjxtegEdrsJUG9lvMQ sFDfutJNtJtgEoaiTDDDfkkag=; b=CWX1MVVshu+6+ZVyjV3Sy7sXnuXD8Vr+45 uDryrzaEb87YmuuVp4IUgK5d5+qCh6DwIyn/eLssE+ZJn53/liJI2euTKIrGdMMu i3sWsb3eIEPY6/aB29wXVwz15NvOqFexQEGO9P7LE0OxtwOyNdENXBvgQdfoptfu rMV4HF9fY=
X-Session-Marker: 73746F6B636F6E73406262686D61696C2E6E6C
X-Spam-Summary: 2, 0, 0, , d41d8cd98f00b204, stokcons@bbhmail.nl, :::::, RULES_HIT:41:152:355:379:582:599:960:962:967:968:973:983:988:989:1152:1189:1208:1221:1260:1313:1314:1345:1359:1436:1437:1516:1517:1518:1535:1543:1575:1588:1589:1592:1594:1711:1712:1730:1776:1792:2198:2199:2528:2559:2562:2691:2693:2911:3138:3139:3140:3141:3142:3354:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4117:4250:4321:4362:4425:5007:6117:6119:6261:6657:6659:6678:7875:7903:8603:10004:10400:10848:11232:11657:11658:11914:12043:12109:12114:12295:12555:12740:12895:12986:13071:13139:13141:13149:13230:13439:13870:13972:14093:14096:14180:14181:14721:21060:21080:21324:21433:21451:21611:21627:21740:30029:30054:30070, 0, RBL:216.40.42.5:@bbhmail.nl:.lbl8.mailshell.net-62.8.55.100 66.201.201.201, CacheIP:none, Bayesian:0.5, 0.5, 0.5, Netcheck:none, DomainCache:0, MSF:not bulk, SPF:fn, MSBL:0, DNSBL:none, Custom_rules:0:0:0, LFtime:27, LUA_SUMMARY:none
X-HE-Tag: corn87_2212ce2ac7654
X-Filterd-Recvd-Size: 6678
Received: from mail.bbhmail.nl (imap-ext [216.40.42.5]) (Authenticated sender: webmail@stokcons@bbhmail.nl) by omf06.hostedemail.com (Postfix) with ESMTPA; Mon, 18 Feb 2019 14:13:54 +0000 (UTC)
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="=_edfe27aee81a2160c5807ada817220d9"
Date: Mon, 18 Feb 2019 15:13:53 +0100
From: Peter van der Stok <stokcons@bbhmail.nl>
To: Jim Schaad <ietf@augustcellars.com>
Cc: draft-ietf-ace-coap-est@ietf.org, ace@ietf.org
Organization: vanderstok consultancy
Reply-To: consultancy@vanderstok.org
Mail-Reply-To: consultancy@vanderstok.org
In-Reply-To: <00fb01d4c631$94657040$bd3050c0$@augustcellars.com>
References: <00fb01d4c631$94657040$bd3050c0$@augustcellars.com>
Message-ID: <23d5cef825bc463976b9635e9a0038e4@bbhmail.nl>
X-Sender: stokcons@bbhmail.nl
User-Agent: Roundcube Webmail/1.2.7
X-Originating-IP: [83.201.249.173]
Archived-At: <https://mailarchive.ietf.org/arch/msg/ace/6oNx_rA0QCW_khzFWA358G8DgRs>
Subject: Re: [Ace] Shepard comments draft-ietf-ace-coap-est-08
X-BeenThere: ace@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Authentication and Authorization for Constrained Environments \(ace\)" <ace.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ace>, <mailto:ace-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ace/>
List-Post: <mailto:ace@ietf.org>
List-Help: <mailto:ace-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ace>, <mailto:ace-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Feb 2019 14:13:58 -0000

Hi Jim,

thanks for the review.
see below.

Peter
Jim Schaad schreef op 2019-02-16 20:55:

> 1.  In section 10.1 the last sentence of the first paragraph and the first
> sentence of the last paragraph duplicate each other.  This should be cleaned
> up.
> 
> <pvds>removed the 2nd instance </pvds>
> 
> 2.  Correct the grammar in the first sentence of section 10.2 -  s/registers
> a new/registers new/
> <pvds> done </pvds>
> 
> 3.  The correct example DNS name is est-coaps.example.org not
> est-coaps.example.ietf.org.   Please correct this.  (See RFC 2606)
> 
> <pvds> sorry about that, corrected that everywhere </pvds>
> 
> 4.  The query in section 5.1 to a resource directory is not correct.  It
> would not go to /.well-known/core but to /rd-lookup (or what ever name is
> used by the RD).   If this is not intended to be an RD query, then the
> sentence about it above can be omitted.  
> 
> <pvds> removed anchor because query to server and not RD </pvds>
> 
> 5.  Please remove the "anchor" target attribute from the response from the
> RD.  I believe that this is no longer required and it is just adding noise
> without adding value.  If this is intended to be from well-known then it is
> sufficient to have the anchor but not to  have the authority section in the
> href.  
> 
> </est>;rt="ace.est";anchor="coaps://2001:db8::123]:61617"
> 
> <pvds> Removed anchor, see above, but left the authority section because of port example. </pvds>
> 
> 6.  You have registered 282 and 283 as content types, however you also do
> not define anything that uses these types.  Either some text about the
> content types needs to exist or potentially the registrations should be
> abandoned.
> 
> <pvds>are needed for other future anima documents, but have them removed </pvds>
> 
> 7.  There is an outstanding review from Klaus that needs to be addressed.
> 
> <pvds> we are working on it. will discuss answers to-morrow between authors </pvds>
> 
> 8.  There is still an open issue dealing with content types.  I have
> requested that this be added to the agenda for the next CoRE interim
> meeting.
> 
> <pvds> Absolutely. we hope for additional text elsewhere </pvds>
> 
> Jim