Re: [Add] I-D Action: draft-ietf-add-dnr-04.txt

Hi Ben,

No problem to list the IP addresses first as both are variable-length.

For the length vs. count, this is something we considered in the past. I have reported at that time that we depend on the dhc recommendations. As a reminder, the discussion we had with Bernie (dhc wg Chair) triggered https://mailarchive.ietf.org/arch/msg/dhcwg/gZ_EbiPVOt-3tARDeQHYLHbh8R8/.

Cheers,
Med

De : Ben Schwartz <bemasc@google.com>
Envoyé : jeudi 9 décembre 2021 22:37
À : BOUCADAIR Mohamed INNOV/NET <mohamed.boucadair@orange.com>
Cc : add@ietf.org
Objet : Re: [Add] I-D Action: draft-ietf-add-dnr-04.txt

Now that the SvcPriority is included in the payload, I would suggest moving the IP addresses to the beginning of the payload.  That would allow the remainder to be syntactically identical to SVCB RDATA, so it can be synthesized and parsed using the exact same code used for SVCB records.  (It would also save one byte.)

As I mentioned previously I would also prefer to provide the _count_ of IP addresses, rather than the _length_ of the IP address field.  This avoids the potential for memory safety vulnerabilities when Addr Length is impossible (e.g. 13) and saves one byte for IPv6.

On Thu, Dec 9, 2021 at 1:59 AM <mohamed.boucadair@orange.com<mailto:mohamed.boucadair@orange.com>> wrote:
Hi all,

This version fixes an issue about DHCP option ordering: we used to rely upon the options appearance but this is against RFC7227.

We also made some editorial changes to clean the reference to the deployment I-D.

Looking forward seeing the I-D in WGLC.

Cheers,
Med

> -----Message d'origine-----
> De : Add <add-bounces@ietf.org<mailto:add-bounces@ietf.org>> De la part de internet-drafts@ietf.org<mailto:internet-drafts@ietf.org>
> Envoyé : jeudi 9 décembre 2021 07:52
> À : i-d-announce@ietf.org<mailto:i-d-announce@ietf.org>
> Cc : add@ietf.org<mailto:add@ietf.org>
> Objet : [Add] I-D Action: draft-ietf-add-dnr-04.txt
>
>
> A New Internet-Draft is available from the on-line Internet-Drafts
> directories.
> This draft is a work item of the Adaptive DNS Discovery WG of the IETF.
>
>         Title           : DHCP and Router Advertisement Options for the
> Discovery of Network-designated Resolvers (DNR)
>         Authors         : Mohamed Boucadair
>                           Tirumaleswar Reddy
>                           Dan Wing
>                           Neil Cook
>                           Tommy Jensen
>       Filename        : draft-ietf-add-dnr-04.txt
>       Pages           : 21
>       Date            : 2021-12-08
>
> Abstract:
>    The document specifies new DHCP and IPv6 Router Advertisement options
>    to discover encrypted DNS servers (e.g., DNS-over-HTTPS, DNS-over-
>    TLS, DNS-over-QUIC).  Particularly, it allows to learn an
>    authentication domain name together with a list of IP addresses and a
>    set of service parameters to reach such encrypted DNS servers.
>
>
> The IETF datatracker status page for this draft is:
> https://datatracker.ietf.org/doc/draft-ietf-add-dnr/
>
> There is also an htmlized version available at:
> https://datatracker.ietf.org/doc/html/draft-ietf-add-dnr-04
>
> A diff from the previous version is available at:
> https://www.ietf.org/rfcdiff?url2=draft-ietf-add-dnr-04
>
>
> Internet-Drafts are also available by rsync at rsync.ietf.org::internet-
> drafts
>
>
> --
> Add mailing list
> Add@ietf.org<mailto:Add@ietf.org>
> https://www.ietf.org/mailman/listinfo/add

_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.

--
Add mailing list
Add@ietf.org<mailto:Add@ietf.org>
https://www.ietf.org/mailman/listinfo/add

_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.