Re: [alto] AD review of draft-ietf-alto-incr-update-sse-19

Mirja Kuehlewind <ietf@kuehlewind.net> Fri, 21 February 2020 11:02 UTC

Return-Path: <ietf@kuehlewind.net>
X-Original-To: alto@ietfa.amsl.com
Delivered-To: alto@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AACEF120219; Fri, 21 Feb 2020 03:02:00 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.897
X-Spam-Level:
X-Spam-Status: No, score=-1.897 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kZVe8DF5yFi0; Fri, 21 Feb 2020 03:01:58 -0800 (PST)
Received: from wp513.webpack.hosteurope.de (wp513.webpack.hosteurope.de [IPv6:2a01:488:42:1000:50ed:8223::]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C92591200CD; Fri, 21 Feb 2020 03:01:57 -0800 (PST)
Received: from mue-88-130-61-043.dsl.tropolys.de ([88.130.61.43] helo=[192.168.178.42]); authenticated by wp513.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) id 1j5649-0005jG-38; Fri, 21 Feb 2020 12:01:53 +0100
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
From: Mirja Kuehlewind <ietf@kuehlewind.net>
In-Reply-To: <CANUuoLpn6V-NHBhdRgjyj3Be0=NFw7AK-6UVpr1BELpN3t4DFw@mail.gmail.com>
Date: Fri, 21 Feb 2020 12:01:52 +0100
Cc: draft-ietf-alto-incr-update-sse.all@ietf.org, IETF ALTO <alto@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <2E0B7D9C-DA2C-4413-B3AD-F587B9F02FF5@kuehlewind.net>
References: <02F985BC-F6A2-4A2C-A2B7-F348D659BFDE@kuehlewind.net> <CANUuoLr3EWWaOmO5LBWwMKub4-dQ+Lrkr1aU9QiJCRqCRuNe=w@mail.gmail.com> <59E63194-3AF2-4601-92AD-439E80982F65@kuehlewind.net> <CANUuoLoLWQrYibrOMsAv_VNNDq0qC_D1D-=drNigw1uvVY3A5g@mail.gmail.com> <993A509C-70B7-45B1-A1ED-44B4458A80C7@kuehlewind.net> <CANUuoLqrtf-=0A94QT0iqBa0UiPqU8+qmXTCW1=3Z9uxpr_Wiw@mail.gmail.com> <CANUuoLpn6V-NHBhdRgjyj3Be0=NFw7AK-6UVpr1BELpN3t4DFw@mail.gmail.com>
To: "Y. Richard Yang" <yry@cs.yale.edu>
X-Mailer: Apple Mail (2.3445.104.11)
X-bounce-key: webpack.hosteurope.de;ietf@kuehlewind.net;1582282917;5379ec35;
X-HE-SMSGID: 1j5649-0005jG-38
Archived-At: <https://mailarchive.ietf.org/arch/msg/alto/ujW6OH_yrwmjc8UXJJxCy_sz7Po>
Subject: Re: [alto] AD review of draft-ietf-alto-incr-update-sse-19
X-BeenThere: alto@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Application-Layer Traffic Optimization \(alto\) WG mailing list" <alto.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/alto>, <mailto:alto-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/alto/>
List-Post: <mailto:alto@ietf.org>
List-Help: <mailto:alto-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/alto>, <mailto:alto-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Feb 2020 11:02:01 -0000

Hi Richard,

Thanks for the update! I just request IETF last call which should start today. You can still update the document but you might want to wait until the end of the IETF last call in order to also address potential last call comments (mainly be SECDIR, GENART, and OPSDIR reviews.)

I believe there are also some small open points from my review (probably points 5, 6, and 7) which you might want to consider. And please also consider shortening the abstract. You can also look at Vijay’s summary in the shepherd-write as an example.

One more editorial comment on the latest changes: Based on the intro text in section 3 and the title heading of section 3.3, I actual got confused if you proposed now to use HTTP/2. Maybe clarify early on in that section that HTTP/1.1. is used.

Thanks!
Mirja



> On 21. Feb 2020, at 07:53, Y. Richard Yang <yry@cs.yale.edu> wrote:
> 
> Hi Mirja,
> 
> We have submitted a new version. If you need to move on forward this week,
> please use the submitted version. If you can do so by Monday morning, then
> we plan to take a couple reads during this weekend.
> 
> Your reviews helped greatly and we greatly appreciate them!
> 
> Richard
> 
> On Tue, Feb 18, 2020 at 6:46 PM Y. Richard Yang <yry@cs.yale.edu> wrote:
> 
>> Hi Mirja,
>> 
>> I believe that we have a grasp of all of your feedback. We will submit in
>> the next couple days, a new version directly to the data tracker, as you
>> suggested.
>> 
>> Thank you so much! Really appreciate it!
>> 
>> Richard
>> 
>> On Tue, Feb 18, 2020 at 4:32 AM Mirja Kuehlewind <ietf@kuehlewind.net>
>> wrote:
>> 
>>> Hi Richard,
>>> 
>>> Please see inline.
>>> 
>>>> On 17. Feb 2020, at 21:03, Y. Richard Yang <yry@cs.yale.edu> wrote:
>>>> 
>>>> Hi Mirja,
>>>> 
>>>> Thanks a lot for the ultra-fast response. Please see below.
>>>> 
>>>> On Mon, Feb 17, 2020 at 4:21 AM Mirja Kuehlewind <ietf@kuehlewind.net>
>>> wrote:
>>>> Hi Richard,
>>>> 
>>>> Please see below.
>>>> 
>>>>> On 17. Feb 2020, at 05:44, Y. Richard Yang <yry@cs.yale.edu> wrote:
>>>>> 
>>>>> Hi Mirja,
>>>>> 
>>>>> Please see below.
>>>>> 
>>>>> On Fri, Feb 14, 2020 at 4:32 PM Mirja Kuehlewind <ietf@kuehlewind.net>
>>> wrote:
>>>>> Hi authors,
>>>>> 
>>>>> I reviewed draft-ietf-alto-incr-update-sse in order to potentially
>>> get this document through the process before I step down as AD in March. I
>>> have a couple of technical questions below that I would some feedback about
>>> before we move on to IETF last call and some fully editorial point that can
>>> be updated anytime before final publication (e.g. also after IETF last call
>>> has ended).
>>>>> 
>>>>> However, I have one high level question that I would like to at least
>>> understand to justify it in the IESG before we moved on. Sorry that I have
>>> not raised this earlier in the working group but I realised it just now:
>>>>> 
>>>>> HTTP/2 (and HTTP/3) support multiplexing, why is a separate service
>>> needed for stream control, instead of just using a different stream on the
>>> same HTTP connection?
>>>>> Also note that I don’t find the justification, why HTTP/2 Server Push
>>> is not used, not very convincing and I’m afraid to get push-back from the
>>> ART ADs. Especially given the problems describes in section 9.5. However,
>>> we can give it a try. I think I would recommend to have the justification
>>> in section 13.1 earlier in the document, e.g. in section 3.
>>>>> 
>>>>> 
>>>>> We are indeed designing an ALTO incremental based on HTTP/2 (/3). For
>>> now, we plan to clarify that the design is for earlier HTTP and move 13.1
>>> to Sec. 3. How does this sound?
>>>> 
>>>> It’s okay.
>>>> 
>>>> 
>>>> However as you are already working on a design for HTTP/2 or HTTP/3,
>>> would it be better to finish this work up now and specify it from the
>>> beginning over this more modern protocols? Or is there a goos reason why
>>> HTTP/1 support is needed?
>>>> 
>>>> Thanks. We will finish this work now, for HTTP/1/1.1, as it is mostly
>>> done and HTTP/1/1.1 is widely adopted. . HTTP/2 is definitely gaining
>>> momentum (https://w3techs.com/technologies/details/ce-http2 states 43.3%
>>> in Feb. 2020) and we will do the work during the next phase as soon as we
>>> are done with this one.
>>> 
>>> I don’t think that is a relevant number for alto because that's about
>>> Webservers already offering http/2. And I would assume an alto server is
>>> usually not co-located with another Webserver. For alto the most important
>>> question would be if the http sever implementation you are using is
>>> supporting http/2 and I think in terms of implementation most platforms do.
>>> So if you run an alto server and want to use SSE with http/2 you need to be
>>> willing to update you server; that’s it.
>>> 
>>> Anyway, I think you need a bit more justification in the draft why this
>>> is http/1.1 based.
>>> 
>>>> 
>>>> 
>>>>> 
>>>>> And one more request before we move on, please add the actual
>>> Content-Length values to the examples and confirm that you did run the
>>> examples though a syntax checker!
>>>>> 
>>>>> 
>>>>> Yes. All fixed.
>>>> 
>>>> Thanks!
>>>> 
>>>>> 
>>>>> 
>>>>> Here are my other technical questions/comments:
>>>>> 
>>>>> 1) In section 3.2.1
>>>>> "This document adopts
>>>>>   the JSON merge patch message format to encode incremental changes,
>>>>>   but uses a different HTTP method, i.e., it uses POST instead of
>>>>>   PATCH.”
>>>>> I don’t quite understand this sentence. As you use SSE, I guess you
>>> are using neither POST nor PATCH. The point here is that SSE has a quite
>>> different communication model than otherwise in HTTP, so I’m not sure what
>>> this statement actually tells me.
>>>>> 
>>>>> 
>>>>> Excellent review. We have revised the paragraph to be the following:
>>>>> 
>>>>> "JSON merge patch is intended to allow applications to update server
>>> resources by sending only incremental changes. <xref target="RFC7396"/>
>>> defines the encoding of incremental changes (called JSON merge patch
>>> objects)  to be used by the HTTP PATCH method <xref target="RFC5789"/>