Re: [Anima] Ben Campbell's No Objection on draft-ietf-anima-grasp-12: (with COMMENT)

Brian E Carpenter <brian.e.carpenter@gmail.com> Mon, 29 May 2017 04:16 UTC

Return-Path: <brian.e.carpenter@gmail.com>
X-Original-To: anima@ietfa.amsl.com
Delivered-To: anima@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 77FF5128BA2; Sun, 28 May 2017 21:16:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q-ZAVxBKShHN; Sun, 28 May 2017 21:16:30 -0700 (PDT)
Received: from mail-pg0-x233.google.com (mail-pg0-x233.google.com [IPv6:2607:f8b0:400e:c05::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 458EA1272E1; Sun, 28 May 2017 21:16:30 -0700 (PDT)
Received: by mail-pg0-x233.google.com with SMTP id x64so17098171pgd.3; Sun, 28 May 2017 21:16:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aGyKHSMFnUPSHla5ZeI3dY0uivgCfPb4Bu2dTLKaHN4=; b=a3nud3sVmemVX3ikmLb+H1bC+c/Nd/yGfomIRebSmZL4AbEhvqAPtmtkG8ibkokCOO e3+jg8VJxsHci+u7iCd8ZIDpIfSv1EJ54fv48JTlH4Ph/Gh7VH1sv2Woon4cu+5JRaY9 w6JRwseSKprua0kH0Hkcpfgbex37ie49nocKjc50YhMOfka1c80OUq3EfnYw6h3b3y/q vHmSwkk8ZCjvAQXtR6O+IYvCBX/BfbbpzfRU/3ShXrSv4EbrYfDSfil+sT9lz9KcES6d cXJUgcLzUomZl2NIDE/BDDhH1AwIRl7yU/QDKE+Z0qE5yVVtf97MVBwTuojkdjm9lo/O /3PA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=aGyKHSMFnUPSHla5ZeI3dY0uivgCfPb4Bu2dTLKaHN4=; b=P4YADJ1A3flLIGu3cJ1Gf3SBa+43ZHUTmmj9Lt5cx+djaqppYTQRyx1KGRVM6v/fqC e0+0T5D4aWqAFVx/yLYRhelpffQdwafCQOPJ/A0pNPNZ3JF741UWbJ+3sJbRW9Ee2Os8 ELVe0qrHEsD7wgcNw1mm99Z5URf9bhzzi9HZST662gEWHg+gWMQ2OIL5Rodqo21/FN0L Cg6fYG2WmOEIhTT54Qxw34dyY5fFdeVY4Bhn5XVgfpglyRnWTee6lie8/nkXwXNwz2c5 B4IM9oCR6XMqtFhG2x3aF8I5Jn3qOjT9dbMz1GNVfsZLqpOIuUdH1i6TGC3hkU9vZcnQ Todg==
X-Gm-Message-State: AODbwcA/QPZuCyQJD35i+YHLpPPtqVN4pQu2Y6/Xb+iYWTaBwHYsuSru WoKOAzVl7yFm/Q==
X-Received: by 10.84.176.3 with SMTP id u3mr56189418plb.119.1496031389894; Sun, 28 May 2017 21:16:29 -0700 (PDT)
Received: from [192.168.178.21] (139.25.255.123.static.snap.net.nz. [123.255.25.139]) by smtp.gmail.com with ESMTPSA id p13sm15495337pfl.52.2017.05.28.21.16.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 28 May 2017 21:16:29 -0700 (PDT)
To: Ben Campbell <ben@nostrum.com>, The IESG <iesg@ietf.org>
Cc: draft-ietf-anima-grasp@ietf.org, Sheng Jiang <jiangsheng@huawei.com>, anima-chairs@ietf.org, anima@ietf.org
References: <149550272234.507.6666100470577050600.idtracker@ietfa.amsl.com>
From: Brian E Carpenter <brian.e.carpenter@gmail.com>
Organization: University of Auckland
Message-ID: <5905c0d9-f664-1207-aa28-d4d45d5d8528@gmail.com>
Date: Mon, 29 May 2017 16:16:24 +1200
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <149550272234.507.6666100470577050600.idtracker@ietfa.amsl.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/anima/QGu1pBr34V9lhzCyRlcn8-AGPbc>
Subject: Re: [Anima] Ben Campbell's No Objection on draft-ietf-anima-grasp-12: (with COMMENT)
X-BeenThere: anima@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Autonomic Networking Integrated Model and Approach <anima.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/anima>, <mailto:anima-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/anima/>
List-Post: <mailto:anima@ietf.org>
List-Help: <mailto:anima-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/anima>, <mailto:anima-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 29 May 2017 04:16:31 -0000

Comments on some more of Ben's comments:

On 23/05/2017 13:25, Ben Campbell wrote:
...
> - 3.10.5: "SHOULD NOT be used in
>    unmanaged networks such as home networks."
> Why not MUST?

Yes, that is more logical.
> 
> -5, Privacy and Confidentiality: Did people consider IP Addresses and
> other potentially persistent identifiers as impacting privacy?

Here we are dealing with the addresses of network elements, not user
devices, so there don't seem to to be personal privacy issues.

> -7, Grasp Message and Options table: Why "Standards Action"? Would you
> expect some harm to be done if this were only Spec Required?

I have asked the WG's opinion.

> Editorial:
> 
> - Is section 2 expected to be useful to implementers once this is
> published as an RFC? Unless there's a reason otherwise, I would suggest
> moving this to an appendix, or even removing it entirely. As it is, you
> have to wade through an unusual amount of front material before you get
> to the meat of the protocol.

I have asked the WG's opinion.

> - Along the lines of the previous comment, I found the organization a bit
> hard to follow. I didn't find actual protocol details until around page
> 21. Procedures are split (and sometimes repeated) between the procedure
> sections and the message format sections. I think that will make this
> more difficult and error prone than necessary for implementors to read
> and reference.  I fear readers will read one section and think they
> understand the procedures, and miss a requirement in the other.

I understand the problem but I don't have a solution; there is an attempt
to give an overview before getting into message formats, but that leads
to some repetition as well.

> - 3.5.2.2: First bullet:
> Please consider a "MUST NOT construction. "MUST only" can be ambiguous.
> It would be helpful to explain why the loop count must not be more than
> one. I can infer that from the later sections on relays, but it was not
> obvious when reading this section. And unless I missed something, there's
> no text that puts the two ideas together.

OK

> 
> - 3.5.4.5: This section seems redundant to the similar sections under
> negotiation . Since those sections have more information, would it make
> sense to consolidate them there?

It makes sense to condense it. I think the forward reference is useful.

Regards
     Brian