[Anima] Review comments on draft-ietf-anima-jws-voucher-09

Mahesh Jethanandani <mjethanandani@gmail.com> Tue, 13 February 2024 20:43 UTC

Return-Path: <mjethanandani@gmail.com>
X-Original-To: anima@ietfa.amsl.com
Delivered-To: anima@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7E081C151098; Tue, 13 Feb 2024 12:43:21 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.106
X-Spam-Level:
X-Spam-Status: No, score=-2.106 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8P-2MER-TGDt; Tue, 13 Feb 2024 12:43:19 -0800 (PST)
Received: from mail-yw1-x1133.google.com (mail-yw1-x1133.google.com [IPv6:2607:f8b0:4864:20::1133]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 762E2C15107E; Tue, 13 Feb 2024 12:43:16 -0800 (PST)
Received: by mail-yw1-x1133.google.com with SMTP id 00721157ae682-6077a1d441eso16648517b3.1; Tue, 13 Feb 2024 12:43:16 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707856995; x=1708461795; darn=ietf.org; h=to:cc:date:message-id:subject:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=Abw6dyL72fS51COLWMMHCZIpwHGJ8QOk6/ClZVVZIPg=; b=EyfykdIjLU+aYjsyhnvjLL6Mh12SzT/Ra+LccSKakiV0blsAeLOqRDcfn2uS24Xk0+ 3m3pA+euKD1LxWjSq0caCtBRHJvNT6YlJ9s5SZsiT3vkJBmqJS15PCrKjjFqDd52djTH 58IUJ6viILD9McvIpKeRO8UgjsM+PN8U9wbKedwi9wsfLg9f+KfMs4MURT4XDxIkOkSy VCGFBZKVqsRNJeBXR7yBQuvGkxUwmE/J2TewgeNyabNy1fecErrdWZWy99TIhovrwMKx uqRpT8bRKAS5e77smYC2elLV+uKQVi/G7PbrWlh8BlhRQiN3i+qB5N5u75s5zkcp9SG8 PlSA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707856995; x=1708461795; h=to:cc:date:message-id:subject:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Abw6dyL72fS51COLWMMHCZIpwHGJ8QOk6/ClZVVZIPg=; b=C14LgPQpnmqbpYghbsGF0VbOUrkXlclLlaHfDFKz7yalMZDGrOBpUql1/MjOb7CNRW Xk+SC9EE6QkRZJtpXYk9VH//LPgONXf6s7K6e8nWX67e5DwULlBEHAISlScC5sg38kLd 6ml6RmDtV31hdJl4KAevW49RDCMglP2I/ToSuApkKPCiU6+PwRYmovKHWVFPSWD9k0uu AEtN/cFj6KULkim7Mpl28a/Ou5jpmWjTW0+fNiWag5j+mFTiXWWghExRqFVRf+jRKvTf mZ1PR1+SLKvn+WIiaSNNwzzGDuJ5wYiaL7PSEO6MJ+HEhaMIVmW+FMYa6NvGkGuElVnV BWeA==
X-Forwarded-Encrypted: i=1; AJvYcCU/fiG5BXjliYGGRF1PmoPv/d6AyIDfYf83TBcDX7x2J6z5Jjh2Jg3fFi0WfQYGMhCb7yOdr00SMVAH9GfBiA==
X-Gm-Message-State: AOJu0Yzr3Re+3xX+Uf7nJu1zIU7sxC3QydSJDA6sw0X4zaLx3mLet5hW ZJv6QZPFc8UJn+55Nt498SX+ltwIxm2W6G8+Ct3UZ0U0hY7NH69nbe3PALAK
X-Google-Smtp-Source: AGHT+IHUZf+Usf3aVF7SbXXslsh6wI6lXXijuCDSDgmzgEp7YjDGvabcNZ57reporJZM+QWsm0A+JQ==
X-Received: by 2002:a0d:d40f:0:b0:607:804e:36d1 with SMTP id w15-20020a0dd40f000000b00607804e36d1mr494729ywd.26.1707856994318; Tue, 13 Feb 2024 12:43:14 -0800 (PST)
X-Forwarded-Encrypted: i=1; AJvYcCWShcvHIEP5Yv/FSeJQiDNhmNOkk5tKLnmArS6tzud0YOM624PaLfG+zxDWVpHeXaOv6JCu6W3GBtpboMxpvQ==
Received: from smtpclient.apple (070-063-102-158.biz.spectrum.com. [70.63.102.158]) by smtp.gmail.com with ESMTPSA id m17-20020a819c11000000b006040d34e58csm1842358ywa.74.2024.02.13.12.43.12 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Feb 2024 12:43:12 -0800 (PST)
From: Mahesh Jethanandani <mjethanandani@gmail.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_8CAA6002-9954-4FFE-A2EE-29153D2D13E6"
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\))
Message-Id: <1206E48C-0A05-47E7-8832-F43DF9EF18CC@gmail.com>
Date: Tue, 13 Feb 2024 15:43:12 -0500
Cc: Robert Wilton <rwilton@cisco.com>, anima@ietf.org
To: draft-ietf-anima-jws-voucher@ietf.org
X-Mailer: Apple Mail (2.3654.120.0.1.15)
Archived-At: <https://mailarchive.ietf.org/arch/msg/anima/qTOgnlrvyAJaaiEmHw16n4N8V2g>
Subject: [Anima] Review comments on draft-ietf-anima-jws-voucher-09
X-BeenThere: anima@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Autonomic Networking Integrated Model and Approach <anima.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/anima>, <mailto:anima-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/anima/>
List-Post: <mailto:anima@ietf.org>
List-Help: <mailto:anima-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/anima>, <mailto:anima-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Feb 2024 20:43:21 -0000

Here are my comments on draft-ietf-anima-jws-voucher-09 draft.

Overall the draft is short, and easy to understand. There are a few issues categorized under Overall, Major, Minor, and Nits, in order of importance.

Overall:

Please resolve all the TODOs in the document.

Major:

None.

Minor:

- The document makes the following statement, but it is not clear the purpose of the paragraph. Neither voucher data for CBOR or its signature format, COSE is referenced or discussed in the document. The paragraph should be removed.

[I-D.ietf-anima-constrained-voucher] provides a serialization of the voucher data to CBOR [RFC8949] with the signature format of COSE [RFC8812] and the media type "application/voucher-cose+cbor”.

- The term “Voucher Artifact” is referenced multiple times in the document, sometimes with mixed capitalization. The terminology section has definition for other terms, but not for "Voucher Artifact”. draft-ietf-anima-rfc8366bis, which defines the term does not use any capitalization. 

- draft-kuehlewind-update-tag-04 has expired and archived. Do you want to continue referencing it?

Nit:

Section 3.3

- Am I missing a “\” in backslashes(“). Looks like the backslash got eaten by whatever was rendering the HTML. You might want to escape the backslash.

- This sentence did not parse for me.

"Note, a trust anchor SHOULD be provided differently to be trusted. This is consistent with Section 5.5.2 of [BRSKI].” 

Did you mean to say “SHOULD be provided separately, for it to be trusted”?

Thanks


Mahesh Jethanandani
mjethanandani@gmail.com