Re: [apps-discuss] [Technical Errata Reported] RFC6902 (4419)
Mark Nottingham <mnot@mnot.net> Tue, 21 July 2015 14:47 UTC
Return-Path: <mnot@mnot.net>
X-Original-To: apps-discuss@ietfa.amsl.com
Delivered-To: apps-discuss@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 60A831B2E4E for <apps-discuss@ietfa.amsl.com>; Tue, 21 Jul 2015 07:47:08 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.602
X-Spam-Level:
X-Spam-Status: No, score=-2.602 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id z0r1p2VTspsV for <apps-discuss@ietfa.amsl.com>; Tue, 21 Jul 2015 07:47:00 -0700 (PDT)
Received: from mxout-07.mxes.net (mxout-07.mxes.net [216.86.168.182]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8F7951B2DD9 for <apps-discuss@ietf.org>; Tue, 21 Jul 2015 07:47:00 -0700 (PDT)
Received: from dhcp-b3db.meeting.ietf.org (unknown [31.133.179.219]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.mxes.net (Postfix) with ESMTPSA id 7594F22E272; Tue, 21 Jul 2015 10:46:55 -0400 (EDT)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2102\))
From: Mark Nottingham <mnot@mnot.net>
In-Reply-To: <CAC4RtVALyk=AK=cDD0ounE323BEDAagHd8SsN=UbWouZcfeP=A@mail.gmail.com>
Date: Tue, 21 Jul 2015 16:46:52 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <C3DDB4EC-0C7B-48A6-B102-84371302F052@mnot.net>
References: <20150717193624.EF72218046E@rfc-editor.org> <02FCD555-BC2F-48DB-8D7D-C494FCAC202D@mnot.net> <CAC4RtVALyk=AK=cDD0ounE323BEDAagHd8SsN=UbWouZcfeP=A@mail.gmail.com>
To: Barry Leiba <barryleiba@computer.org>
X-Mailer: Apple Mail (2.2102)
Archived-At: <http://mailarchive.ietf.org/arch/msg/apps-discuss/k3UcZ5998LcPq4NI8WViD-Xlbo4>
Cc: brettz9@yahoo.com, Paul Bryan <pbryan@anode.ca>, "apps-discuss@ietf.org" <apps-discuss@ietf.org>, RFC Errata System <rfc-editor@rfc-editor.org>
Subject: Re: [apps-discuss] [Technical Errata Reported] RFC6902 (4419)
X-BeenThere: apps-discuss@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: General discussion of application-layer protocols <apps-discuss.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/apps-discuss>, <mailto:apps-discuss-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/apps-discuss/>
List-Post: <mailto:apps-discuss@ietf.org>
List-Help: <mailto:apps-discuss-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/apps-discuss>, <mailto:apps-discuss-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Jul 2015 14:47:08 -0000
I think it's the case that it's a correct — but not necessarily the clearest — example. > On 21 Jul 2015, at 4:28 pm, Barry Leiba <barryleiba@computer.org> wrote: > > (Re-sending this with what I presume is the correct email address for Brett.) > >> This seems reasonable to me, although it does seem more like a text >> improvement than a strict errata - Barry, any thoughts? > > Was it an error in the spec that the example makes a patch that > doesn't actually make any change to the JSON? > > If that was a mistake, then this report (or some edited version of it) > should be "verified". > > If that was intentional, showing an example of a valid patch that > makes no changes, then this report should be "rejected". > > In either case... > >> I've raised an issue here: >> https://github.com/json-patch/json-patch-tests/issues/22 >> … as that's where most of the JSON Patch implementer community >> pays attention. > > ...that's a good thing to do, as that's the right place to record > comments about the clarity of the document, which might be considered > if we ever do another version. > >>> On 17 Jul 2015, at 9:36 pm, RFC Errata System <rfc-editor@rfc-editor.org> wrote: >>> >>> The following errata report has been submitted for RFC6902, >>> "JavaScript Object Notation (JSON) Patch". >>> >>> -------------------------------------- >>> You may review the report below and at: >>> http://www.rfc-editor.org/errata_search.php?rfc=6902&eid=4419 >>> >>> -------------------------------------- >>> Type: Technical >>> Reported by: Brett Zamir <brettz9@yaho.com> >>> >>> Section: A.14 >>> >>> Original Text >>> ------------- >>> An example target JSON document: >>> >>> { >>> "/": 9, >>> "~1": 10 >>> } >>> >>> A JSON Patch document: >>> >>> [ >>> {"op": "test", "path": "/~01", "value": 10} >>> ] >>> >>> The resulting JSON document: >>> >>> { >>> "/": 9, >>> "~1": 10 >>> } >>> >>> Corrected Text >>> -------------- >>> Proper JSON Pointer escaping should occur when resolving >>> paths for application to the target document. >>> >>> An example target JSON document: >>> >>> { >>> "/": 9, >>> "~1": 10 >>> } >>> >>> A JSON Patch document: >>> >>> [ >>> {"op": "add", "path": "/~01", "value": 11} >>> ] >>> >>> The resulting JSON document: >>> >>> { >>> "/": 9, >>> "~1": 11 >>> } >>> >>> Notes >>> ----- >>> At http://tools.ietf.org/html/rfc6902#appendix-A.14 , I have a few issues: >>> >>> 1. Even though JSON Pointer is referenced elsewhere, I think reference ought to be made here to JSON Pointer in order to clarify what meaning "escape ordering" has here. >>> 2. The operation indicated in this section is "test" which is not documented in its respective sections as returning any kind of document at all. I believe "add" or "replace" must have been the intended operation instead. And to make clear that the value of key "~1" would have actually been affected by such a modifying operation, the value in the result ought to differ from that in the original document. >>> >>> Instructions: >>> ------------- >>> This erratum is currently posted as "Reported". If necessary, please >>> use "Reply All" to discuss whether it should be verified or >>> rejected. When a decision is reached, the verifying party (IESG) >>> can log in to change the status and edit the report, if necessary. >>> >>> -------------------------------------- >>> RFC6902 (draft-ietf-appsawg-json-patch-10) >>> -------------------------------------- >>> Title : JavaScript Object Notation (JSON) Patch >>> Publication Date : April 2013 >>> Author(s) : P. Bryan, Ed., M. Nottingham, Ed. >>> Category : PROPOSED STANDARD >>> Source : Applications Area Working Group APP >>> Area : Applications >>> Stream : IETF >>> Verifying Party : IESG >>> >> >> -- >> Mark Nottingham https://www.mnot.net/ >> >> >> >> >> _______________________________________________ >> apps-discuss mailing list >> apps-discuss@ietf.org >> https://www.ietf.org/mailman/listinfo/apps-discuss -- Mark Nottingham https://www.mnot.net/
- [apps-discuss] [Technical Errata Reported] RFC690… RFC Errata System
- Re: [apps-discuss] [Technical Errata Reported] RF… Mark Nottingham
- Re: [apps-discuss] [Technical Errata Reported] RF… Manger, James
- Re: [apps-discuss] [Technical Errata Reported] RF… Barry Leiba
- Re: [apps-discuss] [Technical Errata Reported] RF… Barry Leiba
- Re: [apps-discuss] [Technical Errata Reported] RF… Mark Nottingham
- [apps-discuss] [Errata Rejected] RFC6902 (4419) RFC Errata System