Re: [aqm] Warren Kumari's Yes on draft-ietf-aqm-codel-07: (with COMMENT)

"Mirja Kuehlewind (IETF)" <ietf@kuehlewind.net> Fri, 07 April 2017 18:02 UTC

Return-Path: <ietf@kuehlewind.net>
X-Original-To: aqm@ietfa.amsl.com
Delivered-To: aqm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 977DA1294E4 for <aqm@ietfa.amsl.com>; Fri, 7 Apr 2017 11:02:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.902
X-Spam-Level:
X-Spam-Status: No, score=-1.902 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RP_MATCHES_RCVD=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rVMfeApqA0RC for <aqm@ietfa.amsl.com>; Fri, 7 Apr 2017 11:02:42 -0700 (PDT)
Received: from kuehlewind.net (kuehlewind.net [83.169.45.111]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 20C2512950A for <aqm@ietf.org>; Fri, 7 Apr 2017 11:02:40 -0700 (PDT)
Received: (qmail 11556 invoked from network); 7 Apr 2017 20:02:39 +0200
Received: from unknown (HELO ?172.17.52.46?) (66.171.166.114) by kuehlewind.net with ESMTPSA (DHE-RSA-AES256-SHA encrypted, authenticated); 7 Apr 2017 20:02:39 +0200
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\))
From: "Mirja Kuehlewind (IETF)" <ietf@kuehlewind.net>
In-Reply-To: <149158704960.11211.6016773961643040981.idtracker@ietfa.amsl.com>
Date: Fri, 7 Apr 2017 14:02:36 -0400
Cc: The IESG <iesg@ietf.org>, wes@mti-systems.com, aqm@ietf.org, draft-ietf-aqm-codel@ietf.org, aqm-chairs@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <6A67DED7-961E-4966-BA3D-FD465CBF32EE@kuehlewind.net>
References: <149158704960.11211.6016773961643040981.idtracker@ietfa.amsl.com>
To: Warren Kumari <warren@kumari.net>
X-Mailer: Apple Mail (2.3259)
Archived-At: <https://mailarchive.ietf.org/arch/msg/aqm/7mSR6P0CAd01zUlIvyhe_cz6U2s>
Subject: Re: [aqm] Warren Kumari's Yes on draft-ietf-aqm-codel-07: (with COMMENT)
X-BeenThere: aqm@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Discussion list for active queue management and flow isolation." <aqm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/aqm>, <mailto:aqm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/aqm/>
List-Post: <mailto:aqm@ietf.org>
List-Help: <mailto:aqm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/aqm>, <mailto:aqm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Apr 2017 18:02:44 -0000

Hi Warren,

thanks for your comments. There will probably be another version so it should be easy to incorporate your comments! Also the comment to have section 5 earlier was made several times; so probably that will happen as well. Thanks!

Mirja


> Am 07.04.2017 um 13:44 schrieb Warren Kumari <warren@kumari.net>et>:
> 
> Warren Kumari has entered the following ballot position for
> draft-ietf-aqm-codel-07: Yes
> 
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
> 
> 
> Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
> for more information about IESG DISCUSS and COMMENT positions.
> 
> 
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-aqm-codel/
> 
> 
> 
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> I think that this is a useful document - I also think that it would make
> a good introductory document to describe queuing for e.g a collage class.
> 
> 
> I do have some readability suggestions to make it even better; these do
> not need any action, but if the authors happen to edit the document for
> any other reason, they may want to address them.
> 
> 1: I found the overall structure of the document a little odd -- I'm
> assuming that this is an artifact of its history, or merging multiple
> documents into one, or similar. It starts off with a nice description of
> queuing and CoDel. It then gets all technical with the pseudo-code (which
> was really helpful). Where it feels a little odd is that it then suddenly
> goes back to being much more introductory feeling (Section 5 - ), and
> feels like it repeats some of the earlier material. Reformatting it all
> to address this seems like overkill, but perhaps a readers note to
> suggest people who want more background should skip ahead then come
> back.
> 
> 2: Section 1.  Introduction
> - "determined set point derived from maximizing the network power metric"
> -- I'd suggest referencing Section 5.2 where power is explained (or, if
> we assume readers understand this, section 5.2 can be dropped).
> 
> 3: Section 3.  Overview of the Codel AQM
> Sojourn time is a really important concept in this document, but it isn't
> really defined - Section 5.1 is closest to defining it, but still not
> great.
> 
> 4: Section 3.1
> "The MTU size can be set adaptively to the largest packet seen so far or
> can be read from the driver."
> It was unclear what driver -- perhaps "interface driver" or simply
> "interface"?
> 
> 5: Section 3.2 has an opening parens but no closing one ("known or
> measure (though ...").
> This is a tiny nit, but set off my OCD tendencies :-)
> 
> 6: Section 5.1
> "We use this insight in the  pseudo-code for CoDel later in the draft.)
> - earlier in the draft...
> 
> Section 5.2: 
> AIMD TCP could use a reference.
> 
> 
> _______________________________________________
> aqm mailing list
> aqm@ietf.org
> https://www.ietf.org/mailman/listinfo/aqm