Re: [aqm] Warren Kumari's Yes on draft-ietf-aqm-codel-07: (with COMMENT)

Jana Iyengar <jri@google.com> Sun, 09 April 2017 19:06 UTC

Return-Path: <jri@google.com>
X-Original-To: aqm@ietfa.amsl.com
Delivered-To: aqm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 22A6C1243F6 for <aqm@ietfa.amsl.com>; Sun, 9 Apr 2017 12:06:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=google.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sf3zB9PVH6XV for <aqm@ietfa.amsl.com>; Sun, 9 Apr 2017 12:06:54 -0700 (PDT)
Received: from mail-pf0-x22d.google.com (mail-pf0-x22d.google.com [IPv6:2607:f8b0:400e:c00::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DEE02126DC2 for <aqm@ietf.org>; Sun, 9 Apr 2017 12:06:51 -0700 (PDT)
Received: by mail-pf0-x22d.google.com with SMTP id i5so23535940pfc.2 for <aqm@ietf.org>; Sun, 09 Apr 2017 12:06:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=QvIGLrpVz9kD97Zrf2RshT/leDo8atNgvxKkEWT49CE=; b=Yy1Vz930RMnfaZDk/HzXQFhKYVCdaIQkI8oqlfNjzjBINWjgpmHE8RjT6rn/2SmTrr pPeKWYYLUF3+6pOuEb+StnmgT6z/knRnbsOvubS9scFx7QEuWWgZdpON0jm3QlrXB6e/ XoZ8b6f3dKrUAJt9C/j+CClf/J5NFt3d8PkkpQoT49D4yvEiH4Ma7H1JGNG8YykgW4Et fhuMTwExWMdS8RgVKsy2W2Yk7VdDdiLEFTCZv6mBTtIOuhmxXN+oHopPRMe9L9DZxPqP kn3fKjbGZ79uCEw0DmLkcxU37V7yIBh+ed4kAzmW5vRNWByn3kW+2hSmdt65ZoPoSiDp Heqg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=QvIGLrpVz9kD97Zrf2RshT/leDo8atNgvxKkEWT49CE=; b=f2ZBYDuMEqoYypnu77bWn7NmhHNrh6btN5UI+bTJNCJmT4Hsp/wyZHXEnzOK1OCLPA Auv6Dd2DJHmNuzAoVY6dFTCCcX4pxWCb8bWFdFSnRllWTC6uch/QZyUjHPHIU3sXJVpK PKNgvvP2rc04r6tSCPSIcHuqioUnuFSHDSB0Vrxge3KjRGriCeaFDmtR6lobDBi1jg0+ Ru6mBYgOmZr4GNyhfAUhQlekxn5jhNqolHRcFREMU6+5ReUaxEmogAZQsHGmLgfGP9no m9XxZcr4VwpVhSWoX6sQ65wmcfpoL2UQ2Fy4ygt/DcvKrbEjPVaquPooYpEXkzlSF9Vh WqXQ==
X-Gm-Message-State: AN3rC/5n7+5MqVoTAqjNYO9xw/J9EHFYZuqGaHWAPnnWGAuyQivUrROvrCfNQC2dIQWE20Bn7MM4m8d9b6VSLTjM
X-Received: by 10.98.75.152 with SMTP id d24mr7662155pfj.107.1491764811237; Sun, 09 Apr 2017 12:06:51 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.100.164.209 with HTTP; Sun, 9 Apr 2017 12:06:50 -0700 (PDT)
In-Reply-To: <6A67DED7-961E-4966-BA3D-FD465CBF32EE@kuehlewind.net>
References: <149158704960.11211.6016773961643040981.idtracker@ietfa.amsl.com> <6A67DED7-961E-4966-BA3D-FD465CBF32EE@kuehlewind.net>
From: Jana Iyengar <jri@google.com>
Date: Sun, 9 Apr 2017 12:06:50 -0700
Message-ID: <CAGD1bZaYLToswSafJ+sR5dQbNHAuzAGB-558uoGRU-o9wqe=Tw@mail.gmail.com>
To: "Mirja Kuehlewind (IETF)" <ietf@kuehlewind.net>
Cc: Warren Kumari <warren@kumari.net>, The IESG <iesg@ietf.org>, Wesley Eddy <wes@mti-systems.com>, aqm@ietf.org, draft-ietf-aqm-codel@ietf.org, "aqm-chairs@ietf.org" <aqm-chairs@ietf.org>
Content-Type: multipart/alternative; boundary=001a113555e0aa00ae054cc08fbe
Archived-At: <https://mailarchive.ietf.org/arch/msg/aqm/wn_R2nvZmvuqxozS69COeiqbsZI>
Subject: Re: [aqm] Warren Kumari's Yes on draft-ietf-aqm-codel-07: (with COMMENT)
X-BeenThere: aqm@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Discussion list for active queue management and flow isolation." <aqm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/aqm>, <mailto:aqm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/aqm/>
List-Post: <mailto:aqm@ietf.org>
List-Help: <mailto:aqm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/aqm>, <mailto:aqm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 09 Apr 2017 19:06:56 -0000

+1 to Mirja's response. I'll do some restructuring. Thanks for your
comments!

On Fri, Apr 7, 2017 at 11:02 AM, Mirja Kuehlewind (IETF) <
ietf@kuehlewind.net> wrote:

> Hi Warren,
>
> thanks for your comments. There will probably be another version so it
> should be easy to incorporate your comments! Also the comment to have
> section 5 earlier was made several times; so probably that will happen as
> well. Thanks!
>
> Mirja
>
>
> > Am 07.04.2017 um 13:44 schrieb Warren Kumari <warren@kumari.net>et>:
> >
> > Warren Kumari has entered the following ballot position for
> > draft-ietf-aqm-codel-07: Yes
> >
> > When responding, please keep the subject line intact and reply to all
> > email addresses included in the To and CC lines. (Feel free to cut this
> > introductory paragraph, however.)
> >
> >
> > Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.
> html
> > for more information about IESG DISCUSS and COMMENT positions.
> >
> >
> > The document, along with other ballot positions, can be found here:
> > https://datatracker.ietf.org/doc/draft-ietf-aqm-codel/
> >
> >
> >
> > ----------------------------------------------------------------------
> > COMMENT:
> > ----------------------------------------------------------------------
> >
> > I think that this is a useful document - I also think that it would make
> > a good introductory document to describe queuing for e.g a collage class.
> >
> >
> > I do have some readability suggestions to make it even better; these do
> > not need any action, but if the authors happen to edit the document for
> > any other reason, they may want to address them.
> >
> > 1: I found the overall structure of the document a little odd -- I'm
> > assuming that this is an artifact of its history, or merging multiple
> > documents into one, or similar. It starts off with a nice description of
> > queuing and CoDel. It then gets all technical with the pseudo-code (which
> > was really helpful). Where it feels a little odd is that it then suddenly
> > goes back to being much more introductory feeling (Section 5 - ), and
> > feels like it repeats some of the earlier material. Reformatting it all
> > to address this seems like overkill, but perhaps a readers note to
> > suggest people who want more background should skip ahead then come
> > back.
> >
> > 2: Section 1.  Introduction
> > - "determined set point derived from maximizing the network power metric"
> > -- I'd suggest referencing Section 5.2 where power is explained (or, if
> > we assume readers understand this, section 5.2 can be dropped).
> >
> > 3: Section 3.  Overview of the Codel AQM
> > Sojourn time is a really important concept in this document, but it isn't
> > really defined - Section 5.1 is closest to defining it, but still not
> > great.
> >
> > 4: Section 3.1
> > "The MTU size can be set adaptively to the largest packet seen so far or
> > can be read from the driver."
> > It was unclear what driver -- perhaps "interface driver" or simply
> > "interface"?
> >
> > 5: Section 3.2 has an opening parens but no closing one ("known or
> > measure (though ...").
> > This is a tiny nit, but set off my OCD tendencies :-)
> >
> > 6: Section 5.1
> > "We use this insight in the  pseudo-code for CoDel later in the draft.)
> > - earlier in the draft...
> >
> > Section 5.2:
> > AIMD TCP could use a reference.
> >
> >
> > _______________________________________________
> > aqm mailing list
> > aqm@ietf.org
> > https://www.ietf.org/mailman/listinfo/aqm
>
>