Re: [art] Artart last call partial review of draft-ietf-oauth-iss-auth-resp-02

Julian Reschke <julian.reschke@gmx.de> Mon, 15 November 2021 17:25 UTC

Return-Path: <julian.reschke@gmx.de>
X-Original-To: art@ietfa.amsl.com
Delivered-To: art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DCC853A0EAC for <art@ietfa.amsl.com>; Mon, 15 Nov 2021 09:25:30 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.751
X-Spam-Level:
X-Spam-Status: No, score=-3.751 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-1.852, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=gmx.net
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hfWP415N5Pwm for <art@ietfa.amsl.com>; Mon, 15 Nov 2021 09:25:24 -0800 (PST)
Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E90CE3A0F3A for <art@ietf.org>; Mon, 15 Nov 2021 09:25:23 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1636997121; bh=NoFz5Ig6NkflvUkTMt10IU4orcu6gBzQil5b/FN2U+8=; h=X-UI-Sender-Class:Date:Subject:To:References:From:In-Reply-To; b=AePaMrdCCTwwi+1IoC5G/7Iqdkao0hZpIBfMGHLfiFHPJp5uyOP2Lwgfn3iLChr+c dMu1H1y4E420rUr/z+S63d1f4bG0WrcyfodJUR+Sml4zxeKMXvzD1fVEcKwT9tRKvb c1g2vuFvVZnkiqnc2IznFTQIexStFyjlpfZ0uRe8=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from [192.168.178.20] ([91.61.56.224]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MYNJq-1n8D2J1bes-00VMO5 for <art@ietf.org>; Mon, 15 Nov 2021 18:25:21 +0100
Message-ID: <148562e9-4eaf-dc55-3c19-b822e0b430ec@gmx.de>
Date: Mon, 15 Nov 2021 18:25:20 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0
To: art@ietf.org
References: <163576279118.23946.14747101192871915313@ietfa.amsl.com> <7c515322-b19f-a1a6-e36a-100ff8d8ef58@hackmanit.de>
From: Julian Reschke <julian.reschke@gmx.de>
In-Reply-To: <7c515322-b19f-a1a6-e36a-100ff8d8ef58@hackmanit.de>
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Transfer-Encoding: quoted-printable
X-Provags-ID: V03:K1:IJjyrdb4H6SBue9bfHZfNsmMOh8LTlLi8QdSRKDzyviILM0VBlj bekVgsb3yt1HxAAJvKINr+AKFMVp0yU/6smjWSBCllgqEW5d/1iUVkpeaVXRSkjDaChVJlM XI+CpWXXFXHSofFDOwAVHSirvKzB47G7Q54zgIx0CLeBTZDDr4aJppzVGUEXuFaSc8s3/Pw ypnGzBcrGC8pGzUxvaiig==
X-UI-Out-Filterresults: notjunk:1;V03:K0:doxB44eu55U=:+iBBHtBANy1/Ra9h8TAmuk WLE2NEybLRN9spvz5mn8IYMXbLDx5q0uVRXwamfT9twBFsCd3dWLY+X1jzRIXPuopNNhCZfAD WuF4Ei2GGMvEVLllsR3NN0JXxf+4Scd6dfziKsTxo5lEtlqetRLk+AkPkjCVek0BMJDcaX0Aw aFZN1IgIXlo4krnZxUKiTskppLQrdtn5mXx9nOvJIK6/BbeapS749zGLK9yxSWNOBhh77xtqh nnF51Vydou5dCki3Ztr+RYtYp/OBky0qxMgjH9jVw3wydmj19E72xh9LqvaI/BQYuAxWrPVZH AYndhXTdIdE8MHB9isr3Plj++RIzbRL34jxQm6gAXVDYjgshHAOf4ECIF3AxkmgjzAZxKEtMz XhJZrpbNoYnJovnNpQmmnvIOtwol0PVCV2Sviz5yE/Pu3X4IA/QybhkvZ7EQNfktawtNj4lwn inpoYwBPiaTm/s5UPdQQbeEoOHUGr6GDLlD8h+QqgBgQr58Fwvy8vr7u9ktj0zX+v6dNSUHbG Uy5XmJJwv0qD0yLYIkk2zfMUFSmwaW+m+Ogw0U+IzHXc4wqrfnTwj85pbelALEucE/Om9P6D7 vXg2xvNHLy4Z+0Tw4TInforj1rGknPkuu4MYd47n4qYVKrCtsAm90sGrlFtJrWgsHfpl+CLBr AesQHYB8O1YXOwPk2pGjS0mDxfo2RVOZ65wgBSpziPhbbJMkcwl0piWPiovLr9IkM57ji4HIy 8vFYK+R9mRY43HUMJpzTLHBLr+dYtsEhf0Ll9d2Ahbm+UaWfwPcRn0cbYio4axGpR4XZFE4Te b9AeaixO9Th9qawMy3NiXG/DEZ8F38IvYBqi0z/D1UYdKdbjkMTYWgfdkbaSvUN+cebh7+q6j eeLuK343Znwi5AgJMXOKVhDBjPuTBnQ/yqVIlQUV+94DmGUK0RcSuND0TcqZbznEmbCFVUjkQ EnjgvcGS28DiTxU3UXbZ8j4A2BJXQCKktEC7fuOfc9LcdPka7zj9zlYQNSH0y/p48Vdm3hpWN NvmdLpV5u/wEXexBiA7DhmLKyieRbZHgZZiqmLWbaMg4G2b3FJYo2jpVyszd3tJLQA0oN6Oil IjKStPatDB6bjo=
Archived-At: <https://mailarchive.ietf.org/arch/msg/art/t0ED_m2MKkOM07yWecj7FlGM89o>
Subject: Re: [art] Artart last call partial review of draft-ietf-oauth-iss-auth-resp-02
X-BeenThere: art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Applications and Real-Time Area Discussion <art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/art>, <mailto:art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/art/>
List-Post: <mailto:art@ietf.org>
List-Help: <mailto:art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/art>, <mailto:art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Nov 2021 17:25:31 -0000

Am 15.11.2021 um 15:58 schrieb Karsten Meyer zu Selhausen:
> ...
>> Major issues:
>>
>> 2.4
>>
>> "Clients MUST compare the extracted and URL-decoded value to the issuer
>> identifier of the authorization server where the authorization request was sent
>> to."
>>
>> I'm not sure that "URL-decoded" is correct with respect to decoding query
>> parameters. Consider URLs containing "+" or "=". You probably need the encoding
>> rules for application/x-www-form-urlencoded instead.
> Good point. We changed the text to refer to
> application/x-www-form-urlencoded.

You may also want to add an example where the difference matters (such
as when the URI contains a plus sign).

>> Section links to external documents do not appear to be marked up as such (and
>> use a trailing dot in the section number which they should not)
> I am acutally not sure how to fix this. I removed the trailing dot
> (thanks for the hint) but when converting markdown to XML the section is
> not automatically recognized.
> My markdown looks like this:
> The authorization response as specified in Section 4.1.2 of [@!RFC6749]
>
> The XML file like this:
> The authorization response as specified in Section 4.1.2 of <xref
> target="RFC6749"></xref>
>
> Is there some example how to link the sections in external RFCs or
> should we create the links manually?

In XML yes, and kramdown will generate those for you. Dunno about mmark.

> ...

Best regards, Julian