Re: [Asap] Genart last call review of draft-ietf-asap-siptrunkingcapability-link-03
Dan Romascanu <dromasca@gmail.com> Mon, 10 April 2023 18:55 UTC
Return-Path: <dromasca@gmail.com>
X-Original-To: asap@ietfa.amsl.com
Delivered-To: asap@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4EB7AC15153D; Mon, 10 Apr 2023 11:55:42 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.094
X-Spam-Level:
X-Spam-Status: No, score=-2.094 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kJm7B9oRi98Q; Mon, 10 Apr 2023 11:55:41 -0700 (PDT)
Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 67501C14CE5D; Mon, 10 Apr 2023 11:55:33 -0700 (PDT)
Received: by mail-lf1-x12c.google.com with SMTP id t20so7489999lfd.5; Mon, 10 Apr 2023 11:55:33 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1681152930; x=1683744930; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=NsZNffpg/JITAcUTNLB8wJKp74DeVBu/x/303oMCxLw=; b=P0Xy7icp/hdoTrJ3sTxnuoTa4KeP94WeRPh4FoDpXDEgeLPyziQVSBah5+/9oIvC+r HBVMxrawY4gwHN+xs0udEtTe06AtYx2m+6rShwDIl/mHAc5PIg5diT6j5hqCE06Gr8E+ ILMeZoNDVFflFunlFNGlMQeKrtuuindF9/7NwccjNCoe20QPfwfkhHEXfrhLaQU9C2YS J8kCt/YIZh2pFHaZJJQmYOF57cax1hc2LO4u8D6PaS15Fgu+bU06Zu7sN2g5IA9z00v6 At+Ndkhk8kq6Sj6bfNFk/krHT6VDmsApoqRfN71bzcrPp2KcRouCLyBuJkwDxz8aRJyZ oLZQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681152930; x=1683744930; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NsZNffpg/JITAcUTNLB8wJKp74DeVBu/x/303oMCxLw=; b=eO79u4ZLNa/kZmbmdO5o61/8GQM9IXoN7VDyTXqAdSbpfcv8+Dm7SUVJ+VO2V78lqO kxuxCvwaKKHgXeeDvEHqhZIkYLaBYTSxeDq/Ulo3G6cbD+48uru7OUrQjnm9ax3FRTcT NV5yhLv5cvDqy8CfCWjEw7pWr+V0dWCWkg0aVSmZT9bv3vxrsDduI4Dr9ltNmSGzOaef SGMNDCmNCkLR+Or+43MhNhkMgdC2xOfQSVR5b5maay9lbOuulK/E4XFfeVkvXUCL+mTW 46MdwhZB89lStGosoAbOHI3wy4eL5UEUpprS+s0+sTaYFis4bB9kI6vXpof+1+0zWqeX TPcg==
X-Gm-Message-State: AAQBX9edNVG4zZq2/16UBRPH8oQU4/fxZg3to6Mlh4uLA0KcDjuactJy Lp5R+ZG3Fs0UajPMdL+iZM+OcTrmK/HsjXVBb4g=
X-Google-Smtp-Source: AKy350a0Lj2tYj9IoYilHJQ+N11tRfNycHKmpTkIsmXLU8kSfbLXmQHX8MRIPl1tdI99cLV30papyduerum9t6ceJQE=
X-Received: by 2002:a05:6512:b0c:b0:4ec:7e11:7760 with SMTP id w12-20020a0565120b0c00b004ec7e117760mr3749193lfu.6.1681152930303; Mon, 10 Apr 2023 11:55:30 -0700 (PDT)
MIME-Version: 1.0
References: <167912859037.33679.2612983847284088869@ietfa.amsl.com> <DS7PR11MB603850B6698BF9AE3E62AFA9C4959@DS7PR11MB6038.namprd11.prod.outlook.com>
In-Reply-To: <DS7PR11MB603850B6698BF9AE3E62AFA9C4959@DS7PR11MB6038.namprd11.prod.outlook.com>
From: Dan Romascanu <dromasca@gmail.com>
Date: Mon, 10 Apr 2023 21:55:18 +0300
Message-ID: <CAFgnS4Xp8magU2-34kbaiCCAwQgMjxVce6ENAysw9ackjaTbgQ@mail.gmail.com>
To: "Derek Engi (deengi)" <deengi@cisco.com>
Cc: "gen-art@ietf.org" <gen-art@ietf.org>, "asap@ietf.org" <asap@ietf.org>, "draft-ietf-asap-siptrunkingcapability-link.all@ietf.org" <draft-ietf-asap-siptrunkingcapability-link.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>
Content-Type: multipart/alternative; boundary="00000000000039539505f8ffebc5"
Archived-At: <https://mailarchive.ietf.org/arch/msg/asap/0l7Vq2ecluSd6WkUA8uP_ZGZy7c>
Subject: Re: [Asap] Genart last call review of draft-ietf-asap-siptrunkingcapability-link-03
X-BeenThere: asap@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Automatic SIP trunking And Peering WG <asap.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/asap>, <mailto:asap-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/asap/>
List-Post: <mailto:asap@ietf.org>
List-Help: <mailto:asap-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/asap>, <mailto:asap-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Apr 2023 18:55:42 -0000
Hi Derek, Thank you for responding and addressing the comments in my review. As stated these were 'Nits' level comments, so I have no problems with your resolutions. This is a good document and can go ahead, from my perspective. Regards, Dan On Mon, Apr 10, 2023 at 7:43 PM Derek Engi (deengi) <deengi@cisco.com> wrote: > Hi Dan, thanks so much for taking the time to review, here are our > comments: > > > > >> I would consider mentioning explicitly 'SIP trunking' in the > Description of the 'sip-trunking-capability' link relation in the registry. > > > > We went back and forth with how best to incorporate an explicit call out > to SIP trunking in the IANA description. We felt that “automated peering > and communication channel negotiation” gave a broader context rather than > using trunking explicitly, where we then may have to explain nuance of what > trunking is and where it occurs. Our preference would be to leave the > definition as is since we feel it is intentionally broad. > > > > >> Should not [I-D.ietf-asap-sip-auto-peer] be a Normative Reference? > > > > We intentionally left this as informative because the link type > registration itself is not dependent on the ASAP draft. Since this > registration does not have any implementation actions and is purely > informational, we believe the ASAP draft that defines the capability set > document will make a normative reference to this registration document. > > > > Thanks again for all the feedback and comments. > > Derek > > > > -- > > Derek Engi > > deengi@cisco.com > > > > > > *From: *Dan Romascanu via Datatracker <noreply@ietf.org> > *Date: *Saturday, March 18, 2023 at 4:36 AM > *To: *gen-art@ietf.org <gen-art@ietf.org> > *Cc: *asap@ietf.org <asap@ietf.org>, > draft-ietf-asap-siptrunkingcapability-link.all@ietf.org < > draft-ietf-asap-siptrunkingcapability-link.all@ietf.org>, > last-call@ietf.org <last-call@ietf.org>, dromasca@gmail.com < > dromasca@gmail.com> > *Subject: *Genart last call review of > draft-ietf-asap-siptrunkingcapability-link-03 > > Reviewer: Dan Romascanu > Review result: Ready with Nits > > I am the assigned Gen-ART reviewer for this draft. The General Area > Review Team (Gen-ART) reviews all IETF documents being processed > by the IESG for the IETF Chair. Please treat these comments just > like any other last call comments. > > For more information, please see the FAQ at > > <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>. > > Document: draft-ietf-asap-siptrunkingcapability-link-03 > Reviewer: Dan Romascanu > Review Date: 2023-03-18 > IETF LC End Date: 2023-03-22 > IESG Telechat date: Not scheduled for a telechat > > Summary: > > This is a short and clear document describing the usage of the > 'sip-trunking-capability' link relation type by an enterprise SIP network > to > retrieve a SIP trunking capability set document containing the > capabilities and > configuration requirements of an ITSP. > > Major issues: > > Minor issues: > > Nits/editorial comments: > > 1. The description of the 'sip-trunking-capability' link relation by IANA > does > not seem to be fully consistent with the scope of the document as defined > in > Section 1. > > In Section 1: > > The capability set document > [I-D.ietf-asap-sip-auto-peer] encapsulates a set of characteristics > of an ITSP, which when retrieved by enterprise telephony network > devices allows for automated establishment of SIP [RFC3261] trunking > between the two telephony networks. > > Description: Refers to a capability set document that defines > parameters or configuration requirements for automated peering and > communication channel negotiation of the Session Initiation > Protocol (SIP). > > I would consider mentioning explicitly 'SIP trunking' in the Description > of the > 'sip-trunking-capability' link relation in the registry. > > 2. Should not [I-D.ietf-asap-sip-auto-peer] be a Normative Reference? > > >
- [Asap] Genart last call review of draft-ietf-asap… Dan Romascanu via Datatracker
- Re: [Asap] Genart last call review of draft-ietf-… Derek Engi (deengi)
- Re: [Asap] Genart last call review of draft-ietf-… Dan Romascanu
- Re: [Asap] [Gen-art] Genart last call review of d… Lars Eggert