Re: [Asap] I-D Action: draft-ietf-asap-sip-auto-peer-05.txt

Marc Petit-Huguenin <marc@petit-huguenin.org> Sun, 03 July 2022 13:22 UTC

Return-Path: <marc@petit-huguenin.org>
X-Original-To: asap@ietfa.amsl.com
Delivered-To: asap@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4B381C15C122 for <asap@ietfa.amsl.com>; Sun, 3 Jul 2022 06:22:55 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.783
X-Spam-Level:
X-Spam-Status: No, score=-8.783 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, NICE_REPLY_A=-1.876, RCVD_IN_DNSWL_HI=-5, SPF_HELO_FAIL=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q56bsLMzuucz for <asap@ietfa.amsl.com>; Sun, 3 Jul 2022 06:22:51 -0700 (PDT)
Received: from implementers.org (implementers.org [92.243.22.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2D9CCC15BED3 for <asap@ietf.org>; Sun, 3 Jul 2022 06:22:50 -0700 (PDT)
Received: from [IPV6:2601:204:e600:411:d250:99ff:fedf:93cd] (unknown [IPv6:2601:204:e600:411:d250:99ff:fedf:93cd]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "Marc Petit-Huguenin", Issuer "implementers.org" (verified OK)) by implementers.org (Postfix) with ESMTPS id D8853AE232 for <asap@ietf.org>; Sun, 3 Jul 2022 15:22:47 +0200 (CEST)
Message-ID: <5ac6478c-9a6c-c840-5d92-f1a489edca1d@petit-huguenin.org>
Date: Sun, 03 Jul 2022 06:22:43 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0
Content-Language: en-US
To: asap@ietf.org
References: <165052938186.9368.4452445111975154485@ietfa.amsl.com>
From: Marc Petit-Huguenin <marc@petit-huguenin.org>
In-Reply-To: <165052938186.9368.4452445111975154485@ietfa.amsl.com>
Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="------------QSERNXID36w9a19CDvlS80OV"
Archived-At: <https://mailarchive.ietf.org/arch/msg/asap/5Fojdkthow4JEWzmACLuJZBgs14>
Subject: Re: [Asap] I-D Action: draft-ietf-asap-sip-auto-peer-05.txt
X-BeenThere: asap@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Automatic SIP trunking And Peering WG <asap.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/asap>, <mailto:asap-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/asap/>
List-Post: <mailto:asap@ietf.org>
List-Help: <mailto:asap-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/asap>, <mailto:asap-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 03 Jul 2022 13:22:55 -0000

Hi,

I did a review of this drafts and have a few comments;

- Section 2:  Substitute RFC 2119 with BCP 14.

- Section 4, second example: the JSON grammar in RFC 7149  clearly states that commas are only used between elements of an array ("s/],/]/").

- Section 4, last paragraph: Add a reference to and capitalize Oauth2 (s/Oauth2/OAuth 2.0/)

- Section 5: the link relation is not yet registered so until it is actually done, change "IANA has registered..." with "IANA is instructed to register..."

Thanks.

On 4/21/22 01:23, internet-drafts@ietf.org wrote:
> 
> A New Internet-Draft is available from the on-line Internet-Drafts directories.
> This draft is a work item of the Automatic SIP trunking And Peering WG of the IETF.
> 
>          Title           : Automatic Peering for SIP Trunks
>          Authors         : Kaustubh Inamdar
>                            Sreekanth Narayanan
>                            Cullen Jennings
> 	Filename        : draft-ietf-asap-sip-auto-peer-05.txt
> 	Pages           : 39
> 	Date            : 2022-04-21
> 
> Abstract:
>     This draft specifies a configuration workflow to enable enterprise
>     Session Initiation Protocol (SIP) networks to solicit the capability
>     set of a SIP service provider network.  The capability set can
>     subsequently be used to configure features and services on the
>     enterprise edge element, such as a Session Border Controller (SBC),
>     to ensure smooth peering between enterprise and service provider
>     networks.
> 
> 
> The IETF datatracker status page for this draft is:
> https://datatracker.ietf.org/doc/draft-ietf-asap-sip-auto-peer/
> 
> There is also an HTML version available at:
> https://www.ietf.org/archive/id/draft-ietf-asap-sip-auto-peer-05.html
> 
> A diff from the previous version is available at:
> https://www.ietf.org/rfcdiff?url2=draft-ietf-asap-sip-auto-peer-05
> 
> 
> Internet-Drafts are also available by rsync at rsync.ietf.org::internet-drafts
> 
> 


-- 
Marc Petit-Huguenin
Email: marc@petit-huguenin.org
Blog: https://marc.petit-huguenin.org
Profile: https://www.linkedin.com/in/petithug