Re: [AVTCORE] Genart last call review of draft-ietf-payload-rtp-jpegxs-12

Russ Housley <housley@vigilsec.com> Fri, 07 May 2021 14:58 UTC

Return-Path: <housley@vigilsec.com>
X-Original-To: avt@ietfa.amsl.com
Delivered-To: avt@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C5C1F3A2515 for <avt@ietfa.amsl.com>; Fri, 7 May 2021 07:58:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.898
X-Spam-Level:
X-Spam-Status: No, score=-1.898 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=unavailable autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MUAlZHVNEdA6 for <avt@ietfa.amsl.com>; Fri, 7 May 2021 07:58:37 -0700 (PDT)
Received: from mail.smeinc.net (mail.smeinc.net [209.135.209.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9BED73A2517 for <avt@ietf.org>; Fri, 7 May 2021 07:58:37 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by mail.smeinc.net (Postfix) with ESMTP id 69A12300B10 for <avt@ietf.org>; Fri, 7 May 2021 10:58:35 -0400 (EDT)
X-Virus-Scanned: amavisd-new at mail.smeinc.net
Received: from mail.smeinc.net ([127.0.0.1]) by localhost (mail.smeinc.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id aDPdSD7Tl2Pa for <avt@ietf.org>; Fri, 7 May 2021 10:58:29 -0400 (EDT)
Received: from a860b60074bd.fios-router.home (pool-141-156-161-153.washdc.fios.verizon.net [141.156.161.153]) by mail.smeinc.net (Postfix) with ESMTPSA id 4ADEC300B38; Fri, 7 May 2021 10:58:29 -0400 (EDT)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.20\))
From: Russ Housley <housley@vigilsec.com>
In-Reply-To: <PR3P192MB074899DD70BC031D7D90FB15AC579@PR3P192MB0748.EURP192.PROD.OUTLOOK.COM>
Date: Fri, 7 May 2021 10:58:29 -0400
Cc: IETF Gen-ART <gen-art@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "avt@ietf.org" <avt@ietf.org>, "draft-ietf-payload-rtp-jpegxs.all@ietf.org" <draft-ietf-payload-rtp-jpegxs.all@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <8C0EBAF1-5562-4959-AEEC-894187CA6B49@vigilsec.com>
References: <162032334274.10241.3586337784439040714@ietfa.amsl.com> <PR3P192MB074899DD70BC031D7D90FB15AC579@PR3P192MB0748.EURP192.PROD.OUTLOOK.COM>
To: Tim Bruylants <TBR@intopix.com>
X-Mailer: Apple Mail (2.3445.104.20)
Archived-At: <https://mailarchive.ietf.org/arch/msg/avt/33X-ZzzBWJv7KFcc1xK11jpfcLs>
Subject: Re: [AVTCORE] Genart last call review of draft-ietf-payload-rtp-jpegxs-12
X-BeenThere: avt@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Audio/Video Transport Core Maintenance <avt.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/avt>, <mailto:avt-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/avt/>
List-Post: <mailto:avt@ietf.org>
List-Help: <mailto:avt-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/avt>, <mailto:avt-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 07 May 2021 14:58:42 -0000

Tim:

> Thank you for the review and the comments. Please find the following answers to your comments below. I have modified the draft and uploaded a -13 version.
> 
> 
>> Major Concerns:
>> Section 7.2.1:  Does the SHALL related to [SMPTE-ST2110-10] only apply when TP=2110TPNL or TP=2110TPW?  Please reword to be clear when this SHALL statement applies.
> 
> The short answer is yes, the SHALL only applies when using the RTP specification in combination with SMPTE ST 2110. But, we chose to remove the SHALL sentence about ST 2110. Originally it was trying to say that in the case of using this RTP Payload under a SMPTE ST 2110 system, that the SDP description must then also follow the rules of STMPTE ST 2110-10. But, it is evident that when implementing another standard, the one must follow that standard. It is a concern of a ST 2110 implementer. For this specification it changes nothing specifically (ST 2110-10 mandates some specific SDP fields and values, but this is allowed by the memo). We specifically made these changes to allow the RTP payload to be used also outside of a ST 2110 ecosystem.

That resolves my concern; thanks.

>> Minor Concerns:
>> Section 3.3:  I do not have [ISO21122-2], and obviously an implementer will need that document.  Can a bit more be said about "the profile" and "the level and sublevel used" without making this document too big?  I am able to get a feel for the other things listed here from their names.
> 
> We reworked this section to clarify better the concepts of the profile and level/sublevel fields, without duplicating content from ISO21122-2.

This helps; thanks.

>> Section 3.4:  Can you please provide some explanation of the "frat field"?
> 
> We reformulated the text a bit and added an explicit reference for the frat field to ISO21122-3 where it is defined.

Thanks for adding that context.

>> Nits:
>> Section 3.2:  I do not understand the the last sentence?  Is it the same as: It represents sample values of a single image, without any interpretation relative to a colour space.
> 
> Yes, that is correct. We changed the sentence to use your suggested wording.

That is more clear to me; thanks.

>> Section 5: s/of ST 2110-21 do not /of [SMPTE-ST2110-21] do not /
> 
> We have updated the reference.

Thanks.

Russ