[AVTCORE] Warren Kumari's No Objection on draft-ietf-avtcore-cryptex-06: (with COMMENT)
Warren Kumari via Datatracker <noreply@ietf.org> Mon, 13 June 2022 16:32 UTC
Return-Path: <noreply@ietf.org>
X-Original-To: avt@ietf.org
Delivered-To: avt@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 58FC9C157B50; Mon, 13 Jun 2022 09:32:42 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Warren Kumari via Datatracker <noreply@ietf.org>
To: The IESG <iesg@ietf.org>
Cc: draft-ietf-avtcore-cryptex@ietf.org, avtcore-chairs@ietf.org, avt@ietf.org, bernard.aboba@gmail.com, bernard.aboba@gmail.com
X-Test-IDTracker: no
X-IETF-IDTracker: 8.3.1
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Warren Kumari <warren@kumari.net>
Message-ID: <165513796235.6107.7981185273422289095@ietfa.amsl.com>
Date: Mon, 13 Jun 2022 09:32:42 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/avt/JxqP_J7lt5rDbkwlXgepMSN5a50>
Subject: [AVTCORE] Warren Kumari's No Objection on draft-ietf-avtcore-cryptex-06: (with COMMENT)
X-BeenThere: avt@ietf.org
X-Mailman-Version: 2.1.39
List-Id: Audio/Video Transport Core Maintenance <avt.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/avt>, <mailto:avt-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/avt/>
List-Post: <mailto:avt@ietf.org>
List-Help: <mailto:avt-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/avt>, <mailto:avt-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Jun 2022 16:32:42 -0000
Warren Kumari has entered the following ballot position for draft-ietf-avtcore-cryptex-06: No Objection When responding, please keep the subject line intact and reply to all email addresses included in the To and CC lines. (Feel free to cut this introductory paragraph, however.) Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/ for more information about how to handle DISCUSS and COMMENT positions. The document, along with other ballot positions, can be found here: https://datatracker.ietf.org/doc/draft-ietf-avtcore-cryptex/ ---------------------------------------------------------------------- COMMENT: ---------------------------------------------------------------------- Thank you for writing this document; like Rob I'm far from an RTP expert, but I also found it readable and useful. I do have a question, as well as some nits to try and make if even better. Question: "[RFC8285] defines two values for the "defined by profile" field for carrying one-byte and two-byte header extensions." - RFC8285 defines 0XBEDE, and has a cute justification. This document defines 0xCODE and 0XC2DE... but it was quite hard to figure out what the *other* value that RFC8285 defined -- and that's my issue. Should this document create an IANA registry to track these? Is there already a registry? E.g: If I magically become an RTP expert and write draft-ietf-avtcode-even-more-awesome-protocol how do I know not to use any of these existing numbers? 1: "If BUNDLE is in use and the a=cryptex attribute" - in all of the other instances where you have 'a=cryptex', you have it enclosed in double-quotes. I suggest doing so here too for consistency. 2: Section 5.1: "When the mechanism defined by this specification has been negotiated, sending a RTP packet that has any CSRCs or contains any {RFC8285}} header extensions follows the steps below." - something went kablooie in your formatting / markdown / kramdown / whatever and you have an extra '}' breaking the reference... 3: I got confused when reading "Note that the 4 bytes at the start of the extension block are not encrypted, as required by [RFC8285]." - it seemed ambiguous to me. I'd suggest "Note that, as required by [RFC8285], the 4 bytes at the start of the extension block are not encrypted." I did already mention that these are nits -- this comes from 'nitpick', which dictionary.com says is "to be excessively concerned with or critical of inconsequential details." -- feel free to ignore them :-)
- [AVTCORE] Warren Kumari's No Objection on draft-i… Warren Kumari via Datatracker