Re: [AVTCORE] I-D Action: draft-ietf-payload-vp9-11.txt

Jonathan Lennox <jonathan.lennox@8x8.com> Wed, 03 March 2021 13:52 UTC

Return-Path: <jonathan.lennox@8x8.com>
X-Original-To: avt@ietfa.amsl.com
Delivered-To: avt@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 287993A132D for <avt@ietfa.amsl.com>; Wed, 3 Mar 2021 05:52:46 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=8x8.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7MGfjMYztZwF for <avt@ietfa.amsl.com>; Wed, 3 Mar 2021 05:52:43 -0800 (PST)
Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8C93D3A1329 for <avt@ietf.org>; Wed, 3 Mar 2021 05:52:36 -0800 (PST)
Received: by mail-qt1-x82c.google.com with SMTP id h9so7634977qtq.7 for <avt@ietf.org>; Wed, 03 Mar 2021 05:52:36 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=8x8.com; s=googlemail; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=5MZv6FxISjB1Xjtkwny4C4clDW3XIT6xVgvxk167sX0=; b=UVTZ9vAjdxQNc7J3BFpy/eUufWboWfCzWja6gN+xi+N51esyObBuHt+oVPLv30cwsM keShPbR6bjl9bt15+OD1dohkmBQEunhzY//iqZEB/UpvhopyrQ4TvXKmj+cafX93bi1t Aa8BTSHPd3nSj3Ca48u110zRLcqpkZ8vxx4ug=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=5MZv6FxISjB1Xjtkwny4C4clDW3XIT6xVgvxk167sX0=; b=JcvbLLps9SXDbLJIkmyMNCHj3DOwaBcpZhSsSa6fqC7QMYdeKBHvIMESt5y/HgeR6r lIEBqRnaRoWC5edDsuXMnpRWh2iMIvNBWa7CBp1JRCfXJJML5U5jzl8IyjXnGG8oGJQk y2m89dt7XFv/YUiZfX6MUSm1o8D2QM+0Yb2kJRoivHYncS9xhhIA0DUO2G2uDA6DdFSo VK+dZIDA/3CTwaG3MQkaB1b0USMijEtAc1skQH58pB5iAbvJPQKd489NMyye8xYEBYty Eem9pNoN/hy3DLPmCaMolNH0Q5Y5YAb41oDb/yKfeFBqZ7vCJCs7Wxv2qnJ/HQFsQz+G e08Q==
X-Gm-Message-State: AOAM533/n6kMdsHZUdty4Q4eCF9j4Qqpk2n1LCOR/qG3AnQTrmC+KCBa bi7NoeYq4gJCW9QU2iEB7QcqVA==
X-Google-Smtp-Source: ABdhPJzmp4KCIUXkJDNixpqqwc+8WQBOr38kHn5BRHMjQY6CgZ/ge9jiIr6+XIYsgmr4qJoS1GxKcA==
X-Received: by 2002:ac8:1344:: with SMTP id f4mr2606761qtj.285.1614779554834; Wed, 03 Mar 2021 05:52:34 -0800 (PST)
Received: from [192.168.2.243] (c-24-0-149-15.hsd1.nj.comcast.net. [24.0.149.15]) by smtp.gmail.com with ESMTPSA id w53sm16036238qtb.54.2021.03.03.05.52.34 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Mar 2021 05:52:34 -0800 (PST)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\))
From: Jonathan Lennox <jonathan.lennox@8x8.com>
In-Reply-To: <AM0PR07MB3860DF70547B8CEDBA70675F93999@AM0PR07MB3860.eurprd07.prod.outlook.com>
Date: Wed, 03 Mar 2021 08:52:33 -0500
Cc: Justin Uberti <justin@uberti.name>, IETF AVTCore WG <avt@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <685618B1-A923-4AC5-A1CC-6229F4736D8E@8x8.com>
References: <161227974389.17487.2345810476114650570@ietfa.amsl.com> <90619FEF-19AE-48B0-8C4C-D2A33870AA85@8x8.com> <AM0PR07MB3860C70B1DEA59A39F35375093B59@AM0PR07MB3860.eurprd07.prod.outlook.com> <DA91D9A6-519F-4FD0-8065-C95670D2DD00@8x8.com> <AM0PR07MB386022B8BD3BC62C949DA4B093B39@AM0PR07MB3860.eurprd07.prod.outlook.com> <561BE4F0-351A-41F5-B5EE-857779282637@8x8.com> <AM0PR07MB3860DF70547B8CEDBA70675F93999@AM0PR07MB3860.eurprd07.prod.outlook.com>
To: Christer Holmberg <christer.holmberg@ericsson.com>
X-Mailer: Apple Mail (2.3654.60.0.2.21)
Archived-At: <https://mailarchive.ietf.org/arch/msg/avt/NoY_CLcZp3s5dhzxyk9wLEBAnnI>
Subject: Re: [AVTCORE] I-D Action: draft-ietf-payload-vp9-11.txt
X-BeenThere: avt@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Audio/Video Transport Core Maintenance <avt.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/avt>, <mailto:avt-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/avt/>
List-Post: <mailto:avt@ietf.org>
List-Help: <mailto:avt-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/avt>, <mailto:avt-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Mar 2021 13:52:46 -0000

The use cases I’m thinking about are things like SFUs, or pre-encoded video.

I guess the question is whether the semantics of max-fs and max-fr are “this is the maximum that is useful to me”, or whether they are “this is the maximum I am physically capable of”.

Browser vendors, what do your implementations do if they receive a stream violating the signaled max-fs or max-fr?

> On Mar 2, 2021, at 3:26 PM, Christer Holmberg <christer.holmberg@ericsson.com> wrote:
> 
> Hi,
> 
> Thank you for the reply! You suggestions look good to me.
> 
> Regarding, Q4, I leave it up to you and other payload experts to decide whether it should be "SHOULD NOT" or "MUST NOT".  Is there a valid use case where one would use bigger values than have been indicated by the peer?
> 
> Regards,
> 
> Christer
> 
> -----Original Message-----
> From: Jonathan Lennox <jonathan.lennox@8x8.com> 
> Sent: tiistai 2. maaliskuuta 2021 17.45
> To: Christer Holmberg <christer.holmberg@ericsson.com>
> Cc: Justin Uberti <justin@uberti.name>; IETF AVTCore WG <avt@ietf.org>
> Subject: Re: [AVTCORE] I-D Action: draft-ietf-payload-vp9-11.txt
> 
> Hi, Christer — thanks again for your comments.
> 
> My response here is based on what I personally think would be the ideal solution; however, given that there is substantial amount of running VP9 code, if any of these would cause problems for the existing implementations it may need to be restricted.  If any browser implementors could check how their existing implementations handle SDP parameter updates in remote descriptions, that’d be very helpful.
> 
>> On Feb 4, 2021, at 1:48 PM, Christer Holmberg <christer.holmberg@ericsson.com> wrote:
>> 
>> Hi Jonathan,
>> 
>>>>> Q3:
>>>> 
>>>> Is there a reason why profile-id is optional, since a value will always be assumed?
>>> 
>>> Since profile-id negotiation was developed relatively late in the process of writing the spec, existing implementations don’t always send it.  It seemed best to maintain compatibility here.
>> 
>> Ok. Perhaps it would be useful to add a note indicating that?
> 
> Ok.
> 
>>>> Q2:
>>>> 
>>>> In Section 6.2.1, my understanding is that max-fs and max-fr are optional. Section 6.2.2 says that the answerer must maintain all configuration parameters. Does that apply to max-fs and max-fr too? If so, if the offer does not contain max-fs and max-fr, the answer cannot contain them either?
>> 
>> A little more on this: the draft says that max-fs and max-fr are only used to indicate capabilities. AFAIU, it is not used to negotiate anything, so I see no reason why endpoints would not be able to insert different values.
> 
> Yes, agreed.  I think the spec should say that each side MAY set max-fs and max-fr independently based on their own receiver capabilities, and these two parameters MAY be present in the answer even if they’re not present in the offer.
> 
> [Quoting from your previous e-mail:]
>> Q4:
>> 
>> Section 6.2.2. does not define any restrictions on what can be modified in a subsequent offer, so I guess one can modify max-fs, max-fr and/or profile-id in a subsequent offer?
> 
> I would propose that profile-id MUST be maintained in subsequent offers (i.e., to negotiate a different profile-id, change payload type numbers), but max-fs and max-fr can be changed freely by either side.
> 
>> Also, Section 6.2.1 of the draft says:
>> 
>>  "The parameters "max-fs", and "max-fr", MUST be included in the
>>    "a=fmtp" line of SDP if SDP is used to declare receiver capabilities."
>> 
>> The "if SDP is used to declare receiver capabilities" sounds strange. Do you mean to say "MUST be included if the user wants to declare its receiver capabilities"?
> 
> Yes, that’s better wording.
> 
>> Also, there is no text on what an endpoint does when receiving those values by the peer. I assume the user should not exceed the indicated frame rate/size, but that is not specified anywhere.
> 
> Agreed.  An important question - should this be SHOULD NOT or MUST NOT?