Re: [babel] Intdir telechat review of draft-ietf-babel-rtt-extension-05

Antoine FRESSANCOURT <antoine.fressancourt@huawei.com> Tue, 13 February 2024 09:24 UTC

Return-Path: <antoine.fressancourt@huawei.com>
X-Original-To: babel@ietfa.amsl.com
Delivered-To: babel@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7C09BC14F5EB; Tue, 13 Feb 2024 01:24:20 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.207
X-Spam-Level:
X-Spam-Status: No, score=-4.207 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id c1me6IT7qBfT; Tue, 13 Feb 2024 01:24:19 -0800 (PST)
Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 66C75C14F603; Tue, 13 Feb 2024 01:24:19 -0800 (PST)
Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4TYwlk5Sp3z6J9qF; Tue, 13 Feb 2024 17:20:18 +0800 (CST)
Received: from lhrpeml100004.china.huawei.com (unknown [7.191.162.219]) by mail.maildlp.com (Postfix) with ESMTPS id F22B0140CB9; Tue, 13 Feb 2024 17:24:14 +0800 (CST)
Received: from lhrpeml500003.china.huawei.com (7.191.162.67) by lhrpeml100004.china.huawei.com (7.191.162.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 13 Feb 2024 09:24:14 +0000
Received: from lhrpeml500003.china.huawei.com ([7.191.162.67]) by lhrpeml500003.china.huawei.com ([7.191.162.67]) with mapi id 15.01.2507.035; Tue, 13 Feb 2024 09:24:14 +0000
From: Antoine FRESSANCOURT <antoine.fressancourt@huawei.com>
To: Juliusz Chroboczek <jch@irif.fr>, Antoine Fressancourt <antoine@aft.network>
CC: "int-dir@ietf.org" <int-dir@ietf.org>, "babel@ietf.org" <babel@ietf.org>, "draft-ietf-babel-rtt-extension.all@ietf.org" <draft-ietf-babel-rtt-extension.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>
Thread-Topic: Intdir telechat review of draft-ietf-babel-rtt-extension-05
Thread-Index: AQHaXgniEoqW8i+oXUODcGoh7lcl6rEH/rQw
Date: Tue, 13 Feb 2024 09:24:14 +0000
Message-ID: <93b262d030754455bd1a7a8ba80bfcc0@huawei.com>
References: <170774892985.36817.5107377234736092892@ietfa.amsl.com> <87bk8l1db6.wl-jch@irif.fr>
In-Reply-To: <87bk8l1db6.wl-jch@irif.fr>
Accept-Language: fr-FR, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.206.215.65]
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/babel/37_HJ5m1KcQRxWrYB5IqjUpd8Ck>
Subject: Re: [babel] Intdir telechat review of draft-ietf-babel-rtt-extension-05
X-BeenThere: babel@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "A list for discussion of the Babel Routing Protocol." <babel.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/babel>, <mailto:babel-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/babel/>
List-Post: <mailto:babel@ietf.org>
List-Help: <mailto:babel-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/babel>, <mailto:babel-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Feb 2024 09:24:20 -0000

Hello Juliusz, 

Your answer gives me the opportunity to give a minor remark I forgot to mention in my review: In the acknowledgements, I think you want to thank Jean-Paul Smets (instead of Smetz). 

Regarding my remark on the algorithms, given that the description of said algorithms in the references is 2 or 3 lines of text, I was thinking giving this text directly is not harmful to the whole document. But to be honest, I am quite nit-picking here. If you don't agree I can live with the current text given that I think the draft is already really well written. 

Best regards,

Antoine

-----Original Message-----
From: Juliusz Chroboczek <jch@irif.fr> 
Sent: mardi 13 février 2024 00:19
To: Antoine Fressancourt <antoine@aft.network>
Cc: int-dir@ietf.org; babel@ietf.org; draft-ietf-babel-rtt-extension.all@ietf.org; last-call@ietf.org
Subject: Re: Intdir telechat review of draft-ietf-babel-rtt-extension-05

Thanks, Antoine.

> * In some parts of the draft, the authors personalize their text using 
> "we" or "our" (for instance in section 3.3 or in the introduction of 
> section 4). The authors might want to rephrase those sentences using a more neutral form.

Agreed.

> * In section 4.1, I was frustrated by the use of vague terms like 
> "fairly" or "somewhat" which gives the impression that the phenomenon 
> described is difficult to observe, and may not require the use of a 
> proper smoothing algorithm.

I'll try to find some more serious-looking terms.

> * In section 4.1 and 4.3, the text mentions external references to 
> describe algorithms that the implementer could be using to avoid 
> strong oscillations in the route selection algorithm. I would have 
> appreciated to have a rough intuition of the behavior of those 
> algorithms in the text directly, while keeping the reference to point to more detailed descriptions.

I'm not sure how to do that.  Both "exponential average" and "hysteresis algorithm" are familiar terms, I'm not sure how I can make them more accurate without spelling out the algorithms in detail.

Thanks again,

-- Juliusz