[babel] Intdir telechat review of draft-ietf-babel-rtt-extension-05
Antoine Fressancourt via Datatracker <noreply@ietf.org> Mon, 12 February 2024 14:42 UTC
Return-Path: <noreply@ietf.org>
X-Original-To: babel@ietf.org
Delivered-To: babel@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id D3B4BC15155A; Mon, 12 Feb 2024 06:42:09 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Antoine Fressancourt via Datatracker <noreply@ietf.org>
To: int-dir@ietf.org
Cc: babel@ietf.org, draft-ietf-babel-rtt-extension.all@ietf.org, last-call@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 12.5.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <170774892985.36817.5107377234736092892@ietfa.amsl.com>
Reply-To: Antoine Fressancourt <antoine@aft.network>
Date: Mon, 12 Feb 2024 06:42:09 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/babel/Rr_0IYBG67Wyl37hnVnxTawjAcU>
Subject: [babel] Intdir telechat review of draft-ietf-babel-rtt-extension-05
X-BeenThere: babel@ietf.org
X-Mailman-Version: 2.1.39
List-Id: "A list for discussion of the Babel Routing Protocol." <babel.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/babel>, <mailto:babel-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/babel/>
List-Post: <mailto:babel@ietf.org>
List-Help: <mailto:babel-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/babel>, <mailto:babel-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Feb 2024 14:42:09 -0000
Reviewer: Antoine Fressancourt Review result: Ready with Nits I am an assigned INT directorate reviewer for draft-ietf-babel-rtt-extension in version 05. These comments were written primarily for the benefit of the Internet Area Directors. Document editors and shepherd(s) should treat these comments just like they would treat comments from any other IETF contributors and resolve them along with any other Last Call comments that have been received. For more details on the INT Directorate, see https://datatracker.ietf.org/group/intdir/about/ <https://datatracker.ietf.org/group/intdir/about/>. Based on my review, if I was on the IESG I would ballot this document as YES. The text of the draft is clearly written, and easy to follow. To the best of my understanding, the metric, sub-TLVs and mechanisms described in the draft are consistent with RFC 8966, in particular with the considerations for protocol extensions in Appendix D. The following are minor issues (typos, misspelling, minor text improvements) with the document: * In some parts of the draft, the authors personalize their text using "we" or "our" (for instance in section 3.3 or in the introduction of section 4). The authors might want to rephrase those sentences using a more neutral form. * In section 4.1, I was frustrated by the use of vague terms like "fairly" or "somewhat" which gives the impression that the phenomenon described is difficult to observe, and may not require the use of a proper smoothing algorithm. * In section 4.1 and 4.3, the text mentions external references to describe algorithms that the implementer could be using to avoid strong oscillations in the route selection algorithm. I would have appreciated to have a rough intuition of the behavior of those algorithms in the text directly, while keeping the reference to point to more detailed descriptions.
- [babel] Intdir telechat review of draft-ietf-babe… Antoine Fressancourt via Datatracker
- Re: [babel] Intdir telechat review of draft-ietf-… Juliusz Chroboczek
- Re: [babel] Intdir telechat review of draft-ietf-… Antoine FRESSANCOURT