Re: [babel] Minor format problem in draft-ietf-babel-yang-model-04

Mahesh Jethanandani <mjethanandani@gmail.com> Mon, 06 January 2020 19:07 UTC

Return-Path: <mjethanandani@gmail.com>
X-Original-To: babel@ietfa.amsl.com
Delivered-To: babel@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7F64E1200EB for <babel@ietfa.amsl.com>; Mon, 6 Jan 2020 11:07:14 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.997
X-Spam-Level:
X-Spam-Status: No, score=-0.997 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1ZLk8mykL_Jy for <babel@ietfa.amsl.com>; Mon, 6 Jan 2020 11:07:13 -0800 (PST)
Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2F23B1200B3 for <babel@ietf.org>; Mon, 6 Jan 2020 11:07:13 -0800 (PST)
Received: by mail-pg1-x531.google.com with SMTP id b9so27271128pgk.12 for <babel@ietf.org>; Mon, 06 Jan 2020 11:07:13 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=BngM3faf2c4H5Os+5rcH9IEVY472X1UaUIbQn+LPFUA=; b=FkXWhbokEwydB46ZXgKdL6KZ1+1uEkqP17Klylc6qnDH0y3/MvV38lEhdbOLuzhVHL NWv+7fJrMbK74ahNcL8ZJ2IUmAwMEky/gugUhZ38cKJxYrkqYHSOX1FXMhoZtFizkrLp kC7cJpyZZzHGworRr6yncM3h9qlkQQKF/AMnOtNVtvOhzhYqnTR/SgpyTXQy4Z0y0abL ApefmsVJh4q8QqWyPWqMbYLyjAN85TYjfAWtO6+QiuKEK+W6JkS40XkJ/Qkmxl6bIYhR dTQF/C+p5cRBVbazEeCnLabQc3ANud3SdLA3onog6jGkQSve/fBzKXu6aRK7qBDsbzNi qEcg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=BngM3faf2c4H5Os+5rcH9IEVY472X1UaUIbQn+LPFUA=; b=snyT61kkB4mbYEuTbv0gGXkzqFNUyaGSYFQJvuo+z5ozaqhX5Q2zVMUzzTRccxKoq1 9L2iSd3B29mC17m6x2wbb1ubjh8gQHPeqkctNp3mbEqF052JaTWnw6z51ZKjHmHlYPjH bpCwtivJ4zAanzSKKyH9uCUN1uMqbJJjNytgZHZfjCMoS3Fq6rcT6+x2JLajtV/XReAL oBr9XezjnlSYJk5wjoEKxWIL9r02u6sjdZQlVuy/MlQ/yBDYpHN0I2Pyvo/TCWAVMk68 TQB9ZoZu3UiigyzhIboCJcDTyEd2HtXkEMGifUkAVMfkrXB63KbqUvh2r9LpJ+RyPv5a gs+g==
X-Gm-Message-State: APjAAAWGImWrqYFacpHbDxrN99cyYzny70EuUzhN510j/ChP+ccyfQBw R9hJILvXhTGw79BeMc2s9nw=
X-Google-Smtp-Source: APXvYqx+sXuv9ZO1shwhQ1DgNPjGhtrGfEZLsvbwOAe00M48/1sG11lwQHbCL0/nzepeLBiw0TNxrQ==
X-Received: by 2002:a63:b642:: with SMTP id v2mr110277310pgt.126.1578337632532; Mon, 06 Jan 2020 11:07:12 -0800 (PST)
Received: from [10.33.123.65] ([66.170.99.2]) by smtp.gmail.com with ESMTPSA id a9sm51282235pfn.38.2020.01.06.11.07.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Jan 2020 11:07:12 -0800 (PST)
From: Mahesh Jethanandani <mjethanandani@gmail.com>
Message-Id: <1149EE36-765D-449B-BF23-A68DFB55E3B2@gmail.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_3BA2C757-E924-47AE-B4EF-20926A113488"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Date: Mon, 6 Jan 2020 11:07:11 -0800
In-Reply-To: <2D09D61DDFA73D4C884805CC7865E61153729C3E@GAALPA1MSGUSRBF.ITServices.sbc.com>
Cc: Donald Eastlake <d3e3e3@gmail.com>, Babel at IETF <babel@ietf.org>
To: "STARK, BARBARA H" <bs7652@att.com>
References: <CAF4+nEF2enPsrNk+RvDRBJiycpjKe17W50=OJV2XOK7rKdjgfA@mail.gmail.com> <CC940348-5659-4FF3-9ECD-BA67043EB02B@gmail.com> <CAF4+nEGmi3nOBw+CrNdQpg8rQsu3GOdX2KG0tmzOw1Hi3VEgGg@mail.gmail.com> <98799C32-6591-475E-B9F3-B6E31D828154@gmail.com> <2D09D61DDFA73D4C884805CC7865E61153729C3E@GAALPA1MSGUSRBF.ITServices.sbc.com>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/babel/ErThz62joSUgqBa1PVYsmlOJK0o>
Subject: Re: [babel] Minor format problem in draft-ietf-babel-yang-model-04
X-BeenThere: babel@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "A list for discussion of the Babel Routing Protocol." <babel.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/babel>, <mailto:babel-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/babel/>
List-Post: <mailto:babel@ietf.org>
List-Help: <mailto:babel-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/babel>, <mailto:babel-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Jan 2020 19:07:15 -0000

Hi Barbara,

You bring up a good point.

Have added feature statements for security, MAC and certificate types, and made the identity statements conditional on the features being declared. Also beefed up the example to show how the system could be configured for HMAC-SHA256 MAC algorithm.

Thanks.

> On Jan 6, 2020, at 6:39 AM, STARK, BARBARA H <bs7652@att.com> wrote:
> 
> Hi Mahesh,
> In looking over this change, I’m trying to understand how indicating supported metric computation algorithms (expressed through feature + identity statements, but no leaf-list) differs from indicating supported security mechanisms, MAC algorithms, and certificate types (expressed through identity statements + leaf-list).
>  
> Why would we not use the same approach for all 4 of these?
> Barbara
>  
> From: babel <babel-bounces@ietf.org> On Behalf Of Mahesh Jethanandani
> Sent: Friday, January 03, 2020 4:22 PM
> To: Donald Eastlake <d3e3e3@gmail.com>
> Cc: Babel at IETF <babel@ietf.org>
> Subject: Re: [babel] Minor format problem in draft-ietf-babel-yang-model-04
>  
> Hi Donald,
>  
> In trying to make the changes you requested, I came across another change that needs to be pushed.
>  
> The information model suggests that babel-information-obj should maintain a list of metric-comp-algorithm that are supported by an implementation. The problem with just keeping a list in YANG is that there is no way to enforce that the implementation uses only those algorithms. To address the issue we had introduced the concept of features in -04 version of the draft.
>  
> Using the feature statement, the implementation can declare which of the metric-comp-algorithms it supports, which was the intention of having a list of those algorithms in the first place. As such, we do not need the global list anymore, and needs to be removed. I will be adding that change in the -05 version of the draft.
>  
> If you feel that it requires a short LC to be issued, please feel free to do so after I post the draft.
>  
> Thanks.
> 
> 
> On Jan 3, 2020, at 10:32 AM, Donald Eastlake <d3e3e3@gmail.com <mailto:d3e3e3@gmail.com>> wrote:
>  
> Hi Mahesh,
>  
> You're welcome. My apologies for not noticing it earlier. Can you go ahead and post a revision with this trivial change?
> 
> Thanks,
> Donald
> ===============================
>  Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
>  2386 Panoramic Circle, Apopka, FL 32703 USA
>  d3e3e3@gmail.com <mailto:d3e3e3@gmail.com>
>  
>  
> On Fri, Jan 3, 2020 at 2:21 AM Mahesh Jethanandani <mjethanandani@gmail.com <mailto:mjethanandani@gmail.com>> wrote:
> Hi Donald,
>  
> Yes, that should be ok. And thanks for catching it.
>  
> Cheers.
> 
> Mahesh Jethanandani
> mjethanandani@gmail.com <mailto:mjethanandani@gmail.com>
> 
> On Jan 2, 2020, at 8:27 PM, Donald Eastlake <d3e3e3@gmail.com <mailto:d3e3e3@gmail.com>> wrote:
> 
> Hi Mahesh,
> 
> Happy New Year!
> 
> There seems to be a minor format problem in this draft, in particular four lines, all identical, that are 76 characters long. Lines over 72 characters are not allowed in Internet Drafts.
> 
> On page 34, page 35, page 36, and page 38 the following line occurs:
>             xmlns:babel="urn:ietf:params:xml:ns:yang:ietf-babel">babel:babel
> Is it possible to fold this into something like
>             xmlns:babel=
>                 "urn:ietf:params:xml:ns:yang:ietf-babel">babel:babel
> or just reduce the indent of those lines?
> 
> Thanks,
> Donald
> ===============================
>  Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
>  2386 Panoramic Circle, Apopka, FL 32703 USA
>  d3e3e3@gmail.com <mailto:d3e3e3@gmail.com>
>  
> Mahesh Jethanandani
> mjethanandani@gmail.com <mailto:mjethanandani@gmail.com>
Mahesh Jethanandani
mjethanandani@gmail.com