Re: [babel] New Version Notification for draft-ietf-babel-rtt-extension-06.txt

Toke Høiland-Jørgensen <toke@toke.dk> Wed, 17 April 2024 12:37 UTC

Return-Path: <toke@toke.dk>
X-Original-To: babel@ietfa.amsl.com
Delivered-To: babel@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 054BFC14F618 for <babel@ietfa.amsl.com>; Wed, 17 Apr 2024 05:37:51 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.348
X-Spam-Level:
X-Spam-Status: No, score=-3.348 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DATE_IN_PAST_12_24=1.049, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=toke.dk
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gK9bB9jjc7w3 for <babel@ietfa.amsl.com>; Wed, 17 Apr 2024 05:37:46 -0700 (PDT)
Received: from mail.toke.dk (mail.toke.dk [IPv6:2a0c:4d80:42:2001::664]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 33678C14F60E for <babel@ietf.org>; Wed, 17 Apr 2024 05:37:44 -0700 (PDT)
From: Toke Høiland-Jørgensen <toke@toke.dk>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1713357460; bh=OzBpGDY1gQF0VB3ALPvZD3uN+JdzoNHHlLXsTmX5Ce8=; h=From:To:Subject:In-Reply-To:References:Date:From; b=XHTOeoJHuHVfn3ykmZgD3hLm4WRvz0v/9zGVIeJSeIXd0uiaV6wthvnMXeavJ7ztv sqJc1lfmkYQG6sQhcEySLxsm2sPpzlwPIT/TAH/c0ga1QBAvarwvyGmZ05iMjkySTU 1lvfkF1WIALLkdKz8Aa6NTYfjDjvts4bP9ZfvYDu0dglRysmanEuOfoVHLVTobNlTy p/2VgtlS+SfmTWMDC99K2fMBcQrRmaAK4uq2owtl9vseO3bFXPJAiq002yIeQYvRrZ FmeUNfnSmXY9CwZ5fXg1kkPaSuyIpL/MmBmySYBw51i4NZ2823zaDF3MJQFc8JPK5L CXGEZ8jGSq9hQ==
To: Juliusz Chroboczek <jch@irif.fr>, babel@ietf.org
In-Reply-To: <87v84h5k56.wl-jch@irif.fr>
References: <171328574275.28898.9111599332162642753@ietfa.amsl.com> <87v84h5k56.wl-jch@irif.fr>
Date: Tue, 16 Apr 2024 19:44:40 +0200
X-Clacks-Overhead: GNU Terry Pratchett
Message-ID: <87r0f5urqv.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain
Archived-At: <https://mailarchive.ietf.org/arch/msg/babel/J-Qd8UPbKB5K6on1BAuMJGpEHhk>
Subject: Re: [babel] New Version Notification for draft-ietf-babel-rtt-extension-06.txt
X-BeenThere: babel@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "A list for discussion of the Babel Routing Protocol." <babel.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/babel>, <mailto:babel-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/babel/>
List-Post: <mailto:babel@ietf.org>
List-Help: <mailto:babel-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/babel>, <mailto:babel-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Apr 2024 12:37:51 -0000

Juliusz Chroboczek <jch@irif.fr> writes:

>> URL:      https://www.ietf.org/archive/id/draft-ietf-babel-rtt-extension-06.txt
>> Status:   https://datatracker.ietf.org/doc/draft-ietf-babel-rtt-extension/
>> HTML:     https://www.ietf.org/archive/id/draft-ietf-babel-rtt-extension-06.html
>> HTMLized: https://datatracker.ietf.org/doc/html/draft-ietf-babel-rtt-extension
>> Diff:     https://author-tools.ietf.org/iddiff?url2=draft-ietf-babel-rtt-extension-06
>
>
> I've tried to satisfy all of the IESG comments; apologies to the reviewers
> if I've missed any, there were a lot.  The main change is that Section 3
> has been rewritten in normative style, as many reviewers requested.
>
> As far as I am aware, there are only two new requirements: the last
> paragraph of Section 3.2, and the last paragraph of Section 3.3.  I've
> checked that babeld is compliant, Toke, could you please check your
> implementation?

The Bird implementation is compliant with section 3.2, although that may
change in favour of asking the kernel to timestamp incoming packets:

https://bird.network.cz/pipermail/bird-users/2024-April/017592.html

Using kernel (or hardware) timestamps is a better solution anyway, IMO,
so maybe that particular recommendation needs rethinking?

We don't explicitly expire RTT state if the sanity checks keep failing,
so I don't believe we're compliant with the last paragraph of section
3.3.

-Toke