Re: [babel] Secdir last call review of draft-ietf-babel-source-specific-06

Toke Høiland-Jørgensen <toke@toke.dk> Wed, 28 October 2020 15:09 UTC

Return-Path: <toke@toke.dk>
X-Original-To: babel@ietfa.amsl.com
Delivered-To: babel@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B28263A0A4F; Wed, 28 Oct 2020 08:09:45 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=toke.dk
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Vjb_i1e6gCgY; Wed, 28 Oct 2020 08:09:44 -0700 (PDT)
Received: from mail.toke.dk (mail.toke.dk [IPv6:2a0c:4d80:42:2001::664]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 892453A0A07; Wed, 28 Oct 2020 08:09:42 -0700 (PDT)
From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1603897780; bh=xcM9fMc6mYay+UQq1lWdtKNWEfmwAftQ8TvUh88U6Pg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=qP5arfTFQNHx6VacQnTHNn0hBZ4Mx+iu+vBeZcYSqsV3slXdRgyufuEvUDjlLaQ4i OXeqniZGFxgfHGyWhv871W3iRdgKRoT5Kj1fJXJ4KqDwKYkFnbq08nqELFDfMi5iVK NbldiGbVkIHUSgPM0UX6qmICCxIBl+bRGEvBakuPGNGNQBlxT2CWUlsyK8/AblXv5n T+b/cjLvm4VleNcgJiZ8TphIi4E7DtqExOkb7OYMffZPebw3Y+remoKfby1dp8Axhy 8wYBknTxBg5mliB/QRcCsZ9csMgilFet6/q53kFpHBtNmGqp01hPHfMEsMvv8AEUhX RFl9pDIJU5Omg==
To: Juliusz Chroboczek <jch@irif.fr>, Rifaat Shekh-Yusef <rifaat.s.ietf@gmail.com>
Cc: last-call@ietf.org, draft-ietf-babel-source-specific.all@ietf.org, babel@ietf.org, secdir@ietf.org
In-Reply-To: <87o8kmfo2n.wl-jch@irif.fr>
References: <160364731499.17476.11455568556595523172@ietfa.amsl.com> <87o8kmfo2n.wl-jch@irif.fr>
Date: Wed, 28 Oct 2020 16:09:39 +0100
X-Clacks-Overhead: GNU Terry Pratchett
Message-ID: <87mu06mlos.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/babel/J8ZWnE4i2OKqvGreNzfbhOWYKQI>
Subject: Re: [babel] Secdir last call review of draft-ietf-babel-source-specific-06
X-BeenThere: babel@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "A list for discussion of the Babel Routing Protocol." <babel.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/babel>, <mailto:babel-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/babel/>
List-Post: <mailto:babel@ietf.org>
List-Help: <mailto:babel-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/babel>, <mailto:babel-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Oct 2020 15:09:46 -0000

Juliusz Chroboczek <jch@irif.fr> writes:

>>   “A node MUST NOT send more that one Source Prefix sub-TLV in a TLV,
>>    and a node receiving more than one Source Prefix sub-TLV in a single
>>    TLV SHOULD ignore this TLV.  It MAY ignore the whole packet.”
>
>> 2. This paragraph implies that a node might accept the TLV with more than one
>> Source Prefix sub-TLV, but it does not state when a node can do that. You might
>> want to elaborate on the conditions that a node is allowed to do that.
>
> Right.  I've made this a MUST, which reflects implementation practice.
> Group, please feel free to object if you think this is the wrong
> choice.

SGTM.

-Toke