[babel] Fwd: Rtgdir early review of draft-ietf-babel-hmac

Donald Eastlake <d3e3e3@gmail.com> Thu, 20 September 2018 02:27 UTC

Return-Path: <d3e3e3@gmail.com>
X-Original-To: babel@ietfa.amsl.com
Delivered-To: babel@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2380C128C65 for <babel@ietfa.amsl.com>; Wed, 19 Sep 2018 19:27:06 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.749
X-Spam-Level:
X-Spam-Status: No, score=-1.749 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 49Ki2RdNVCvm for <babel@ietfa.amsl.com>; Wed, 19 Sep 2018 19:27:05 -0700 (PDT)
Received: from mail-it0-x230.google.com (mail-it0-x230.google.com [IPv6:2607:f8b0:4001:c0b::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0D471126CB6 for <babel@ietf.org>; Wed, 19 Sep 2018 19:27:05 -0700 (PDT)
Received: by mail-it0-x230.google.com with SMTP id h3-v6so11156528ita.2 for <babel@ietf.org>; Wed, 19 Sep 2018 19:27:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Uglhp5kzhOgWxjv/N1AOy9BkBVMoaIiPD6Ei6Axg3QQ=; b=nH5OlrZwxuEpXXWVjFVjZJWwNaFe1+LGmoOBQUFkS7ecST7AWQQAdE1ThAt3IvMYdT QWMUMmHj/ZhuwclCY/+R8eGttHudWg01G7p1n5kyDDH84BEJok79f7uZjVXjQLvAFC1l z2hLoWU5Prk6VekJk7Sn5u9vXT1jJ+8wH7yOjCS58JRMOq9sscNv7HjekYmPE1vFNzoW LqA5UZipMviLsl6DoBF6dyKWoxZO1dVJ9ZGoWMNuSSu5nS018zBQlP0XYa7l1iv1r0oo NSwkw48qeycYreMfzGhEN+S5o+CSPx0xPJZlp6w7SwZvvUbtpssH1IL9VgBb6RVTuJzD oHEA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Uglhp5kzhOgWxjv/N1AOy9BkBVMoaIiPD6Ei6Axg3QQ=; b=qbM1h3Wmbloq8auRKWAjF5Cl1vfE+OEbxaHyjZFKaBGZmAahQ6Aaz5lMMvlR79ABkM oSEgcdvxGDdGa3UMnmEQDyM7ZkM85VBUQaa/Lj4eGuxIRROGh+0RFPtRwMiSCxaeOJmB 9QCSynipjERqGJ8xgKAGQPrCRhMUhvTpJ+A1IvpeqWXiaJcy9ITGg0JAmnT0KycvrW4A /NlajUBaiFlN8XSpeNhP1Uyn7ygEK2gkeG45y8PtcQCdnmlrHjSB6NlttQ1LUnhNI0o9 Y8UhT+MDpeKTzLBPuCAsq2IcUJCTOnbT/UYDB7eZn+vgJ1oOjQdWDl0keZr+sl41MrjZ 72sQ==
X-Gm-Message-State: APzg51CAlGPtP8n11OaGT82JbD/YGyFBW8Jrqi+lB6eYnAzWRNoSimnY YkzqmKTdh3YTrbLVvBrUiJrRK6UJNznEDDe0q60DJw==
X-Google-Smtp-Source: ANB0VdZbWQmvxiRDxm5BZwP3EAWALerWFOHCG75S3C5DFhOAtKvEGy/hIWboftfaWfibV/G/LOsMEbnzHlbdHW5EEAA=
X-Received: by 2002:a24:4305:: with SMTP id s5-v6mr527436itb.147.1537410423940; Wed, 19 Sep 2018 19:27:03 -0700 (PDT)
MIME-Version: 1.0
References: <8CCB28152EA2E14A96BBEDC15823481A1CD5B548@sjceml521-mbs.china.huawei.com>
In-Reply-To: <8CCB28152EA2E14A96BBEDC15823481A1CD5B548@sjceml521-mbs.china.huawei.com>
From: Donald Eastlake <d3e3e3@gmail.com>
Date: Wed, 19 Sep 2018 22:26:51 -0400
Message-ID: <CAF4+nEEHNOJXQNaaLr4yiXBfCRu9N-w-ABO+Cmb9AcNj7J2vpQ@mail.gmail.com>
To: Babel at IETF <babel@ietf.org>
Cc: Michael McBride <Michael.McBride@huawei.com>
Content-Type: multipart/alternative; boundary="000000000000316ec305764442d0"
Archived-At: <https://mailarchive.ietf.org/arch/msg/babel/xwNOtwxNd58P5O17y5TksS1j2cA>
Subject: [babel] Fwd: Rtgdir early review of draft-ietf-babel-hmac
X-BeenThere: babel@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "A list for discussion of the Babel Routing Protocol." <babel.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/babel>, <mailto:babel-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/babel/>
List-Post: <mailto:babel@ietf.org>
List-Help: <mailto:babel-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/babel>, <mailto:babel-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Sep 2018 02:27:06 -0000

And here is one of the Routing Directorate early reviews.

Thanks,
Donald
===============================
 Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
 1424 Pro Shop Court, Davenport, FL 33896 USA
 d3e3e3@gmail.com

---------- Forwarded message ---------
From: Michael McBride <Michael.McBride@huawei.com>
Date: Wed, Sep 19, 2018 at 7:46 PM
Subject: Rtgdir early review of draft-ietf-babel-hmac
To: draft-ietf-babel-hmac@ietf.org <draft-ietf-babel-hmac@ietf.org>
Cc: rtg-dir@ietf.org <rtg-dir@ietf.org>rg>, babel-chairs@ietf.org <
babel-chairs@ietf.org>


I have been selected to do a routing directorate “early” review of
draft-ietf-babel-hmac.



Document: draft-ietf-babel-hmac-00

Reviewer: Mike McBride

Review Date: 19-09-2018



Intended Status: Standards Track



Comments:



I only found a few nits. Great job with the draft, especially being a 00.
The nits that should be considered:



1.      Add a Terminology section to include HMAC, Babel, PC, etc

2.      1.1 Applicability Section: “The protocol defined in this document
assumes that all interfaces on a given link are equally trusted and share a
small set of symmetric keys (usually just one, two during key rotation).”
Consider changing it to: “…(Typically one key. Two keys during a key
rotation).” Otherwise it can read as “just one or two during key rotation”.

3.      4.2 Packet Transmission Section: “A Babel node may delay actually
sending TLVs by a small amount…”. Consider giving an example of a small
amount.



Sound reasonable?



mike