Re: [bess] New short WGLC for draft-ietf-bess-evpn-unequal-lb

"Fomin, Sergey (Nokia - US/Mountain View)" <sergey.fomin@nokia.com> Wed, 12 May 2021 00:07 UTC

Return-Path: <sergey.fomin@nokia.com>
X-Original-To: bess@ietfa.amsl.com
Delivered-To: bess@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2D3683A2BB2 for <bess@ietfa.amsl.com>; Tue, 11 May 2021 17:07:45 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.597
X-Spam-Level:
X-Spam-Status: No, score=-2.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.698, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=nokia.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Xb5FNs-taR8I for <bess@ietfa.amsl.com>; Tue, 11 May 2021 17:07:38 -0700 (PDT)
Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2127.outbound.protection.outlook.com [40.107.93.127]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7A75E3A2BB6 for <bess@ietf.org>; Tue, 11 May 2021 17:07:37 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KPntz4wn0A85vzZ82MPxSwSf11h1ZK7TgtolmDDi3F1fz2mE46Bd1jc3ZMxIOOfqPLbv/QoAcvNL4t5hbBfvMBB0uDhIXor5goZHYM6WgGzNf8zHDZtJAyFMVNcoWcfyft+kLWztqQuwXBzLulUaVc+W4UveQya16lOBPpaFyb2kiuNPHpXEyb5+tPaf4d30yBgzhu3MrWPZ8270KW5aqr0e3ILPsUFVXBaYa9X4M/MUARsJ/1CNG+EKuFqFE+xyx3L4WZDX9uJKzBqSIaJhisjc5ysq/Rj0oMf7yVuGgvwN5STK+rjQ65JawdjF4pdiePUOGJbMuTzT0NCXRynWFA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=297ixVliQZmqkVqt3F7VD0YPvOG8aifoWTI2Fsxp8wY=; b=KigRbPPQt/YdETWBk9PDg11/VnwrZltcrY1RsN312EleOKK7JuxOx5Lml1YanZxlW6bdk97UrpXXyIhBckeX36cBl6eIJ6qlFdIQpiGpAxx+6DjreAXBZfvGOHIs4wJmRFmaLXcR+9LK5nkh7GKmVAdEM34t6QgZQb+88eR8Aa32qia+GmhrYrT8eeVcrKIRd7qECrBs3zCSFYbXZ0pEJ54cj/9vEAje88l0l0TB1UfmGOMrwOvWXYHRdB2J7WCI+dGAddeo6gXtB5UFTlOlL48yFjxq21JcAV7qzA1p4IHIeF4T8i7/5QJvFIASKImUa3uXXlQCUteC8CM3L0vZ8g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nokia.com; dmarc=pass action=none header.from=nokia.com; dkim=pass header.d=nokia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia.onmicrosoft.com; s=selector1-nokia-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=297ixVliQZmqkVqt3F7VD0YPvOG8aifoWTI2Fsxp8wY=; b=DFDpJyTAJpHdmojIDv9C3A+BfB/fCT8ym5ylOjrDEgVryH4oRYeYcGBAjMAtQZw+EqwgIj+stF2yonH++PjXo1aytIzr80Iv+00Vil4OdwvMDHelSymMiTX/QOR6Ua4O7SbyN5Cc+2IBXM74IJAk9NkKzpK75/p1OVpwruIheaI=
Received: from BYAPR08MB5493.namprd08.prod.outlook.com (2603:10b6:a03:cc::31) by BYAPR08MB5158.namprd08.prod.outlook.com (2603:10b6:a03:6d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.27; Wed, 12 May 2021 00:07:33 +0000
Received: from BYAPR08MB5493.namprd08.prod.outlook.com ([fe80::1136:f550:4469:bad1]) by BYAPR08MB5493.namprd08.prod.outlook.com ([fe80::1136:f550:4469:bad1%4]) with mapi id 15.20.4108.031; Wed, 12 May 2021 00:07:33 +0000
From: "Fomin, Sergey (Nokia - US/Mountain View)" <sergey.fomin@nokia.com>
To: Neeraj Malhotra <neeraj.ietf@gmail.com>, "Rabadan, Jorge (Nokia - US/Mountain View)" <jorge.rabadan@nokia.com>
CC: "slitkows.ietf@gmail.com" <slitkows.ietf@gmail.com>, BESS <bess@ietf.org>, "bruno.decraene@orange.com" <bruno.decraene@orange.com>
Thread-Topic: [bess] New short WGLC for draft-ietf-bess-evpn-unequal-lb
Thread-Index: Adc/7NS2J0/mGOvKSC6oOVSo+WO3zQADkP0AAI/SegAABPyVgAAAhgbcAAlVo4AAH9LG8AAZ2xaAAAbTwQAACD6aAACAtsqAABh+g8AAAuiogAAJyS+AABqLnBAACg9I8A==
Date: Wed, 12 May 2021 00:07:32 +0000
Message-ID: <BYAPR08MB5493F8E43D2648D6401C8EE585529@BYAPR08MB5493.namprd08.prod.outlook.com>
References: <030c01d73fec$ddfc7320$99f55960$@gmail.com> <28781_1620033617_608FC051_28781_399_5_53C29892C857584299CBF5D05346208A4CD7E00D@OPEXCAUBM43.corporate.adroot.infra.ftgroup> <CAF3QiHHgaeOKz5fOr3fKJd5RD3G7PHxBf0eKuL86DHgdNPkz9A@mail.gmail.com> <4079_1620288224_6093A2E0_4079_13_11_53C29892C857584299CBF5D05346208A4CD85C3E@OPEXCAUBM43.corporate.adroot.infra.ftgroup> <BY3PR08MB7060B25F28D6D131C162F297F7589@BY3PR08MB7060.namprd08.prod.outlook.com> <5890_1620305160_6093E508_5890_360_9_53C29892C857584299CBF5D05346208A4CD86464@OPEXCAUBM43.corporate.adroot.infra.ftgroup> <005f01d742f8$23812db0$6a838910$@sergey.dev> <CAF3QiHH4OEkpEFQuETZp3O1kDek3qOJcT4o9gGqMG9AQmrr1Zg@mail.gmail.com> <1613221620415761@mail.yandex.ru> <CAF3QiHF8NSrb6J8vnttLQ1zC8+br-cM7oc=239_PD9tUVWhu6Q@mail.gmail.com> <26678_1620651274_60992D0A_26678_465_1_53C29892C857584299CBF5D05346208A4CD8BC5A@OPEXCAUBM43.corporate.adroot.infra.ftgroup> <BYAPR08MB549325F101B0DD7F8A66558B85539@BYAPR08MB5493.namprd08.prod.outlook.com> <CAF3QiHHO73-Ab2ztJxeAsoqqU4jxvVd3Hu0Gi=hjrA-uL+dFsA@mail.gmail.com> <30873_1620715165_609A269D_30873_151_1_53C29892C857584299CBF5D05346208A4CD94EE3@OPEXCAUBM43.corporate.adroot.infra.ftgroup> <BYAPR08MB5493B6001A578AFC2B77584A85539@BYAPR08MB5493.namprd08.prod.outlook.com>
In-Reply-To: <BYAPR08MB5493B6001A578AFC2B77584A85539@BYAPR08MB5493.namprd08.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=nokia.com;
x-originating-ip: [73.252.153.127]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e3d96c41-c838-4e61-d15d-08d914d9f0e9
x-ms-traffictypediagnostic: BYAPR08MB5158:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <BYAPR08MB51580AAEC5B7853BD1F41CCA85529@BYAPR08MB5158.namprd08.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: ZFIoIQHvobh/b6HgrurL2cD8tEJ/rfuMd+5jH6mb619cDXMlP198pLosieOInRlWnVD4KL8WzwmAIzraNNrTYEvYjAvBIadVjl+7CyBknPyfvas4eSKstf5xNmAmK78vlb6N3DLHBzfYMEPttnCL/kde/5rFSdXxLhhO2x4OGrGZdaGFYHpcDd+UGbKBOsUH7qCIU1fSkDRDBTDv0xZwIvTYH09s3CBZr2HUzgqtYNfgLfkUrb/PDyWPD/0MV8RFmfKScC1t79N8yL/KJz9wg2gXeH6GcqocCxGArcHP84Qp0Roq3o1ySdkzDcM7EKerefwlHU72Li95RN5j+KTnKEkp0aJnwlRUpohZ5yv7PL899k1QfvDmV/kqxdLEILGKp/xheMY60/zh6oEPrL5OTM3f0PTXWeY3ke8jnZI9i/FKqO3x+hauSQS4VaXru3z2Tuh2xJDVNNp9obvTwsmryyPiavHg6nB4LgOqR4A1Cy+UzJ+lhr8xjHL7on916gy/y/Bh3kJ5pX4DkN5ThgY4ToutpSZcF2Uy1G+l7DjOkkeujWqDcKB7b5I+/cQdVrTkVbUr12RmPe5Y5o4dxDuAP1B0X7MUwE/diPgyZhdIeQmSErwZhk+66llmGjl3aomdSTPg33zkKMk+Lu+C4X3vJYiHcXUmeqV88HIZh+k0KC0JoAjubOWqEFqBl+nVhdVs/qRxqq8MGbLYiTXhS7RsYw==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR08MB5493.namprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(366004)(39860400002)(376002)(346002)(4326008)(33656002)(316002)(76116006)(26005)(8676002)(110136005)(54906003)(7696005)(30864003)(9686003)(8936002)(53546011)(6506007)(55016002)(52536014)(6636002)(86362001)(71200400001)(66574015)(966005)(66556008)(64756008)(66476007)(5660300002)(83380400001)(66446008)(38100700002)(122000001)(478600001)(2906002)(66946007)(186003)(166002)(579004)(559001); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata: ZLCPYmzc5XoSHf8UlN9do614NRhkmPMmwdo/FCj0QAh1Ni9aKN7CS5u1zMj4Gaiwh135Nn56IyrHgoHGidLt4vMfy+RcVKaq9B8699QQlmARRykF/k6z8HTjXJNp/Gu0keDtuVBkkGZ6daDXVgYPToQqG4jy/fW12M1j6Xj6F0htx7ZVxp4TlvkIRnVipYiqKXW/8f7ir6f9m2kk52hgA4jhLms323CNDlOqtMOfR8PdTUdBPss0vxMfsVgKP04wzNWoHwsk+DqjZxJ8En0ngcZnD/7mhdUIXkha2YL8KPR9APx0v8M0gLs2L0m0A4elKVC++evj7bfk8ti4t60GX18ykMiPP02OjWIBBPcQRDOCPJY469xNQ5dDRSIZ9FMurm25t8dLvSufKnixphYZXCXBlwTRAPg3FK9Kw9cf7fKBpCSBNm+Ylwn0n+2jm1jI1ApJe7Q740inffXc6dXdGVfJo4jsgkKXKj0z4oDNXtg+ia612stRkMuI5lggZsvdXkGfCdC9fF7ncyAPw3Np6oK7k27M5oAbVfsE26IP5cWbKWxQ9mVGxMve/ncG+BDkKUCSr50NVxnhRva8P3q8youRLf7CZ0ZIHN5vtoUAo/mpju5niwS+Gq3nntJE7ZFeqo+VPCpBEvwQigJO4I3oPxpSw+lqVu1EpwynEjLnJrfhaKmQKrmDGymFiDhYtmUmQGR6OV9N080cbQAg5AgVcWOOWRA3q7CRNaX5+VwmifqiV9PisoEFbPMbw/kTo3D7QP3ttfPOV4DqoZRl1p7XleElorx8kBNsUZbOcdGuNNlr4CGMT5Uue/WeSxfoTLUClYFjpTgPGyf9k2q9fxik+4UHe4JKzRfVM7SAMEZeqXhVSKFd+5bz4Cm5oTFe1giZOLvrKZgP2uVD9VJ/NVBzhz1Qt8xPDYBdFjqjbXJi8CVo2Z7Mb8/dlwf5+vXC1fTnvr4+tz1Cg2XAT7rLjWv3KEC9xdZ5TWD41Mjh2E+4ph5rOE9w6kdg9iJX2PEl1bf7HdXIUmesyqvtwZdABQ0NM5YGXpryfpGgllPJOIx5EJfW6Kts9WjsnirwlgPu8WhrGSpNS1wHOl1Hc9pWzw399j4GXC17zwcgLq/IFnv5U3zELzlcgsiU71qx+tM6pU4iVb/INw1IWCjNfaxrzzkz04yrGxXIUnUH714ymjKv3MiuAVHpvrKsHSax+4P4HpLIqweSVQKhc28QbOWQT++wlkyEi83PPExSgcjz2LEcwEDVlq6ln0V+Vc5qDvzMBq0tsH4fAdYK5odrqsTImauF4J0X6EX+HgLRYkXfceign8EVD7outeM6IfuRF6sh7jhv
Content-Type: multipart/alternative; boundary="_000_BYAPR08MB5493F8E43D2648D6401C8EE585529BYAPR08MB5493namp_"
MIME-Version: 1.0
X-OriginatorOrg: nokia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR08MB5493.namprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e3d96c41-c838-4e61-d15d-08d914d9f0e9
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2021 00:07:32.9031 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5d471751-9675-428d-917b-70f44f9630b0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: doGuiGjIqD4MK/QTPRbrWBQVSDxCBG9L7ePJyQFhLPjzNgoTk1Zgp8A9rvd4Bzh35sQ3iC2s9bOs7XdyhcEMMg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR08MB5158
Archived-At: <https://mailarchive.ietf.org/arch/msg/bess/Us_oXA19IPOYIG5rY3PFUT3zeYo>
Subject: Re: [bess] New short WGLC for draft-ietf-bess-evpn-unequal-lb
X-BeenThere: bess@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: BGP-Enabled ServiceS working group discussion list <bess.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bess>, <mailto:bess-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bess/>
List-Post: <mailto:bess@ietf.org>
List-Help: <mailto:bess-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bess>, <mailto:bess-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 12 May 2021 00:07:45 -0000

Hi Neeraj, Jorge & all,

Just wanted to clarify my previous message after a short chat with Jorge: when I say “non-aliasing” case, I mean a scenario where eth. a-d per EVI route is not used or generated [by PEs-1/2/3 in this example].
It is indeed a relatively rare scenario which doesn’t bring much value, so I’m open to drop support for it in this draft and just require eth. a-d per EVI route to be present (=aliasing enabled) to support the procedures described in this document.

Thank you,
--
Sergey
From: BESS <bess-bounces@ietf.org> On Behalf Of Fomin, Sergey (Nokia - US/Mountain View)
Sent: Tuesday, May 11, 2021 12:48 PM
To: bruno.decraene@orange.com; Neeraj Malhotra <neeraj.ietf@gmail.com>
Cc: Rabadan, Jorge (Nokia - US/Mountain View) <jorge.rabadan@nokia.com>; slitkows.ietf@gmail.com; BESS <bess@ietf.org>
Subject: Re: [bess] New short WGLC for draft-ietf-bess-evpn-unequal-lb

Hi Neeraj & Bruno,

Bruno,
               > Stricto census, what is needed is a single instance of this sub-type and _Value-Units_. In order to accommodate one ingress PE in a domain using “Weight in units of Mbps” and another ingress PE in a different domain using “Generalized Weight”, one could imagine an egress PE advertising 2 communities/both units.
By "egress PE", I'm assuming, you mean "local PE" in terms of this RFC (with an attached ES)?
I'm not opposed to the idea, thought it adds a layer of implementation complexity.
If you see this as a valid use case (somewhat exotic, for sure), it might be worth relaxing the requirement; in this case, we also should add a remark along the lines that “remote PE” logic how to select between 2 types/sets of LBW communities is left up to the implementer / may be configurable; and support for attaching 2 types of communities at the same time is optional.

Thank you for your prompt response Neeraj,
Following up on my aliasing/non-aliasing point, I see you added the following statement
   o  Procedures related to bridged unicast and BUM traffic are
      applicable to both aliasing and non-alaising mode as defined in
      [RFC7432].
(btw, a typo in ‘aliasing’)
This is good, could we also expand text in section 5.2 “Remote PE behavior” a little bit to include an example for non-aliased case where a MAC has been learned only from a subset of PEs.
E.g. in the current example there, calculation is performed for all 3 PEs and gives weights 2 / 1 /1 for a mac entry X.
If aliasing is not enabled, and a mac entry Y is known only via PE-1 & PE-3; path-list for this mac would be [PE-1, PE-3] with 2 / 1 LB ratio.

Thank you!
--
Sergey

From: bruno.decraene@orange.com<mailto:bruno.decraene@orange.com> <bruno.decraene@orange.com<mailto:bruno.decraene@orange.com>>
Sent: Monday, May 10, 2021 11:39 PM
To: Neeraj Malhotra <neeraj.ietf@gmail.com<mailto:neeraj.ietf@gmail.com>>; Fomin, Sergey (Nokia - US/Mountain View) <sergey.fomin@nokia.com<mailto:sergey.fomin@nokia.com>>
Cc: Rabadan, Jorge (Nokia - US/Mountain View) <jorge.rabadan@nokia.com<mailto:jorge.rabadan@nokia.com>>; slitkows.ietf@gmail.com<mailto:slitkows.ietf@gmail.com>; BESS <bess@ietf.org<mailto:bess@ietf.org>>
Subject: RE: [bess] New short WGLC for draft-ietf-bess-evpn-unequal-lb

Thanks Neeraj,

Thanks.

Thanks for the text on error handling. Nothing urgent, but nitpicking on one word. §4.1 & 5.2 have 3 iterations of “this attribute is to be ignored”. I’m afraid one could read this as “this BGP attribute is to be ignored”. Surely we mean “this(theses) EVPN Link Bandwidth extended community(ies) is(are) to be ignored”

One feedback that please feel free to use or ignore.

“A receiving PE MUST ensure that each route contains only a single instance of this extended community attribute sub-type.”
Stricto census, what is needed is a single instance of this sub-type and _Value-Units_. In order to accommodate one ingress PE in a domain using “Weight in units of Mbps” and another ingress PE in a different domain using “Generalized Weight”, one could imagine an egress PE advertising 2 communities/both units. I have a slight preference for allowing both, but up to you (In deployments I would personally advocate using only a single unit and the one whose implementation is mandatory, but when there’s an opportunity to go wrong, the opportunity is rarely missed ;-) )

Thanks again,
--Bruno

From: Neeraj Malhotra [mailto:neeraj.ietf@gmail.com]
Sent: Tuesday, May 11, 2021 3:59 AM
To: Fomin, Sergey (Nokia - US/Mountain View) <sergey.fomin@nokia.com<mailto:sergey.fomin@nokia.com>>
Cc: DECRAENE Bruno TGI/OLN <bruno.decraene@orange.com<mailto:bruno.decraene@orange.com>>; Rabadan, Jorge (Nokia - US/Mountain View) <jorge.rabadan@nokia.com<mailto:jorge.rabadan@nokia.com>>; slitkows.ietf@gmail.com<mailto:slitkows.ietf@gmail.com>; BESS <bess@ietf.org<mailto:bess@ietf.org>>
Subject: Re: [bess] New short WGLC for draft-ietf-bess-evpn-unequal-lb


Hi Sergey,

Thanks for the detailed comments (missed in flight while publishing the previous revision). I have addressed all of the comments and nits below in the latest revision (rev13), except that a couple of hyperlinks for a reason that I can't immediately figure out are not showing up from XML source. Let me check and fix that in the next revision.

Again, much appreciate your diligence in catching these.

Thanks,
Neeraj

On Mon, May 10, 2021 at 5:36 PM Fomin, Sergey (Nokia - US/Mountain View) <sergey.fomin@nokia.com<mailto:sergey.fomin@nokia.com>> wrote:
Thank you Neeraj, authors,
-11 changes look good to resolve my previous concerns. (I second Bruno’s comment about 5 vs 6 octets)

  *   Stylistically I don’t think we need to expand Mbps to Mbits/sec every time (one expanded definition should be enough), but up to you.
  *   Additionally, I would add either that other “value-unit” encoding values are reserved and should not be used for non-standard implementations, or explicitly allow this usage.

I have a few other comments, mostly minor and nits.

General/minor comments:

  1.  Can we add that only a single instance of LBW community per route is allowed, and how to handle erroneous situations, such as

     *   Receiving a route with multiple attached LBW community instances
     *   Received routes from different PEs having different value-units for the same ES (e.g. PE1 sends routes with 0x00, PE2 w. 0x01)
Last paragraph in section 5.2 already describes similar case with presence/absence of the community, so it could be expanded. Though the same restrictions would apply to a recently-introduced type 5 usecase (and, perhaps to a lesser extent, to a BUM load-sharing scenarios as well) so it’s either worth moving these considerations to section 4 (community definition and usage) or expanding section 9 with the same considerations.


  1.  Across the text there's an implicit assumption that either aliasing is enabled or mac addresses are learned from all PEs (and, of course, ES is in all-active mode), which may not be the case.
I propose to add a remark/reference to 7432, stating that all "regular" qualifiers still apply (i.e. presence of both Eth A-D per ES + per EVI routes for aliasing, or per ES + type2 for non-aliased load-sharing).
This may have some effect on weight computation procedures, i.e. likely that PEs which advertise neither should be excluded from the computation despite the presence of LBW community. Or we could require aliasing to be enabled.


  1.  Section 10. IRB MH with non-EVPN routing: I think there's too much detail describing the usecase (which is not currently applicable to this document), and it feels like an intro to another draft. Is it possible to shorten it to 1 or 2 sentences?


  1.  Section 5.1 Local PE Behavior:   A PE that is part of an Ethernet Segment's redundancy group would advertise an additional "link bandwidth" extended community attribute with Ethernet A-D per-ES route (EVPN Route Type 1), that represents total bandwidth of PE's physical links in an Ethernet Segment.

     *   Shall we replace "would" with MUST/SHOULD?
     *   Also, "represents total bandwidth of physical links" is probably not accurate anymore and should be rephrased?


  1.  Can we explicitly state that the community should not be attached to A-D per EVI & type 2 mac/mac-ip routes (and ignored by remote PE if received on these route types)

Nits:

  *   It seems that ES & ESI terms are used somewhat interchangeably (starting from the very beginning in terminology section, also section 3 "Solution Overview", etc); could you please check and maybe stick to "ES" in cases where we don't specifically talk about identifiers? Also, there's no definition of ESI in the terminology section.
  *   Could we add a definition of “path-list” to the terminology section? (it is used extensively throughout the document in different variations, such as "weighted path-list", "forwarding path-list", "MAC path-list" etc)
  *   Same thing for “access bandwidth”, please add a definition
  *   Section 2 “Introduction” - first bullet point was split into two separate bullets
  *   Section 5.2, last line in the last sentence, typo  - "attribute t be used" should be "to be used"
  *   Inconsistent hyperlinking to RFC/draft references in sections 6.1, 6.3, 13; also inconsistent hyperlinking in the table of contents
  *   Section 6.2 contains a reference to a non-existing example in Section 3 ("Considering the same example as in Section 3, ...), probably should point to 5.2?
  *   Inconsistent spelling of "per ES/per-ES" (as in "Ethernet A-D per ES"). Probably should be whitespaced, not dashed (it is spelled this way in 7432)

--
Sergey

From: BESS <bess-bounces@ietf.org<mailto:bess-bounces@ietf.org>> On Behalf Of bruno.decraene@orange.com<mailto:bruno.decraene@orange.com>
Sent: Monday, May 10, 2021 5:55 AM
To: Neeraj Malhotra <neeraj.ietf@gmail.com<mailto:neeraj.ietf@gmail.com>>
Cc: Rabadan, Jorge (Nokia - US/Mountain View) <jorge.rabadan@nokia.com<mailto:jorge.rabadan@nokia.com>>; Sergey Fomin <ietf@sergey.dev<mailto:ietf@sergey.dev>>; slitkows.ietf@gmail.com<mailto:slitkows.ietf@gmail.com>; BESS <bess@ietf.org<mailto:bess@ietf.org>>
Subject: Re: [bess] New short WGLC for draft-ietf-bess-evpn-unequal-lb

Hi Neeraj, co-authors,

Thanks for taking into account the comments.
-11 addresses my comments.

Two comments on the new text:

“EVPN Link Bandwidth Extended Community value field is to be treated
   as a 6 octet unsigned integer representing total bandwidth of PE's
   all physical links in an ethernet segment, expressed in Mbits/sec
   (MegabitsPerSecond). »


Actually with your latest change introducing the new field “Value-unit”, bandwidth is encoded in only 5 octets (not 6). (I’m assuming that the new field “Value-unit” is not to be used when computing the ratio of bandwidth as this would make no sense).

§5.2 Does not say anything with regards to the new field “Value-unit”. A priori, the ratio of bandwidth is only to be computed on bandwidth/EC using the same unit, no?

Thanks,
Regards,
--Bruno

From: Neeraj Malhotra [mailto:neeraj.ietf@gmail.com]
Sent: Saturday, May 8, 2021 1:29 AM
To: Sergey Fomin <ietf@sergey.dev<mailto:ietf@sergey.dev>>
Cc: DECRAENE Bruno TGI/OLN <bruno.decraene@orange.com<mailto:bruno.decraene@orange.com>>; Rabadan, Jorge (Nokia - US/Mountain View) <jorge.rabadan@nokia.com<mailto:jorge.rabadan@nokia.com>>; slitkows.ietf@gmail.com<mailto:slitkows.ietf@gmail.com>; BESS <bess@ietf.org<mailto:bess@ietf.org>>
Subject: Re: [bess] New short WGLC for draft-ietf-bess-evpn-unequal-lb


Hi Sergey, Bruno,

Many thanks for the detailed review and comments. Discussed with co-authors and have enhanced the 'value' encoding to explicitly encode weight units as default or generalized as suggested below. I have published a revision that incorporates all comments discussed on this thread, as well as some additional editorial comments from Jorge. Please let me know if there are any additional comments (in particular on section 4).

Thanks,
Neeraj

On Fri, May 7, 2021 at 12:33 PM Sergey Fomin <ietf@sergey.dev<mailto:ietf@sergey.dev>> wrote:
Hi Neeraj,
thank you for the feedback.

I agree that allocating a new code point for every possible calculation method would be cumbersome.
How about a middle ground solution, with allocation of just a few values (even 2 would suffice: 1 for BW in whatever units we decide; the other "catch-all" generalized weight)?
This way operators will get at least basic visibility & cfg. error prevention mechanism in place (I have a preference towards explicit signaling from ops point of view; but would be glad to hear operators opinion on this one).

My concern with the current text is, while striving for maximum flexibility, we may end up in a situation where 2 implementations won't be able to interoperate with each other (e.g. vendor X decides to implement link BW as a metric, vendor Y decides to implement link count as a metric - since support for any method of weight calculation is completely optional). I believe we, as a technical community, should give guidance on implementing sensible defaults (i.e. "an implementation SHOULD support BW weight calculation method") where it makes sense.

--
Sergey


07.05.2021, 09:18, "Neeraj Malhotra" <neeraj.ietf@gmail.com<mailto:neeraj.ietf@gmail.com>>:

Hi Sergey,

Thanks for the comments. We would like to avoid adding another code point within the value field, as every new encoding of the "weight" will require a new code point. Agree that we should specify the default units (for which the consensus on the thread appears to be Mbps), but would rather leave it to implementations to support any additional units such as number of links, configured weight, or anything else, than have a standardized code point for each unit. Please let me know if this sounds fine. I will fix the units in section 5.2, and the text in section 4.1 as suggested by you and Bruno.

Thanks,
Neeraj

On Thu, May 6, 2021 at 9:19 PM <ietf@sergey.dev<mailto:ietf@sergey.dev>> wrote:

Hi Bruno, Jorge, et al.,



Jorge,

> Among the co-authors we also discussed the possibility of defining two ECs: one for BW and one for a generalized-weight, so that the remote PE can catch if the multi-homed PEs were indeed using the same meaning of the weight. However, we thought it was easier/simpler to use a generalized value in a single EC sub-type, and add the sentence below.

Have you considered reserving a byte in the value field to signal a weight type? Similar to how it is done with DF election framework (and allocate a few right away, e.g. 0 for physical link BW, 1 for link count, 2 for manually configured weight, ...). This would help not only with interop cases, but to prevent & diagnose potential configuration mistakes as well.



For interop reasons, I would support Bruno & argue that it makes sense to use "SHOULD" normative language at least for one way of calculation (e.g. BW).



A couple of minor comments on newly-introduced text in -09 and -10:

  1.  Revision -10 introduced a curious change in section 5.2 “Remote PE Behavior”, replacing “1000 Mbps” with “1000 megabytes” in an example. It is not correct in the current form, since right above it there is an explicit statement that links are Gigabit Ethernet: "As an example, for a CE dual-homed to PE-1, PE-2, PE-3 via 2, 1, and 1 GE physical links respectively".

(keeping the Mbps units there would be appropriate, since this is a weight calculation, not a community encoding example)

  1.  Section 4.1 “Usage of EVPN Link Bandwidth Extended Community”:

“An implementation may support one or more of the above ways of encoding the value." -> I would assume this should be "MUST support at least one", since every other possible option is included in bullet#2?



--

Sergey

From: BESS <bess-bounces@ietf.org<mailto:bess-bounces@ietf.org>> On Behalf Of bruno.decraene@orange.com<mailto:bruno.decraene@orange.com>
Sent: Thursday, May 6, 2021 5:46 AM
To: Rabadan, Jorge (Nokia - US/Mountain View) <jorge.rabadan@nokia.com<mailto:jorge.rabadan@nokia.com>>; Neeraj Malhotra <neeraj.ietf@gmail.com<mailto:neeraj.ietf@gmail.com>>
Cc: slitkows.ietf@gmail.com<mailto:slitkows.ietf@gmail.com>; bess@ietf.org<mailto:bess@ietf.org>
Subject: Re: [bess] New short WGLC for draft-ietf-bess-evpn-unequal-lb



Hi Jorge,



Thanks for the feedback.



Regarding the first point, I can live with the current text. But I think I would prefer that the text favour one option, and leave it to the responsibility of the SP for others usages. E.g.



OLD:

EVPN Link Bandwidth Extended Community value field is to be treated

   as a 6 octet unsigned integer that may be set to:



   o  total bandwidth of PE's all physical links in an ethernet segment,

      expressed in bytes/sec.



   o  or a generalized weight that may be set to link count, locally

      configured weight, or a value computed based on an attribute other

      than link bandwidth.



   An implementation may support one or more of the above ways of

   encoding the value.  Operator MUST ensure consistent encoding of this

   value across all PEs in an ethernet segment.  Procedures related to

   signaling and handling of this extended community defined in this

   document use "total bandwidth in bytes/sec" encoding as an example to

   illustrate its usage.



NEW:

   EVPN Link Bandwidth Extended Community value field is to be treated

   as a 6 octet unsigned integer representing total bandwidth of PE's all physical links in an ethernet segment,

      expressed in bytes/sec.



Note however that the load balancing algorithm defines in this document uses ratio of Link Bandwidths hence the operator may choose a different unit or use the community as

    a generalized weight that may be set to link count, locally

      configured weight, or a value computed based on an attribute other

      than link bandwidth. In such case, the operator MUST ensure consistent usage of the unit

across all PEs in an ethernet segment. This may involve multiple routing domains/Autonomous Systems.





But I leave this to you.



Thanks,

--Bruno



From: Rabadan, Jorge (Nokia - US/Mountain View) [mailto:jorge.rabadan@nokia.com]
Sent: Thursday, May 6, 2021 10:36 AM
To: DECRAENE Bruno TGI/OLN <bruno.decraene@orange.com<mailto:bruno.decraene@orange.com>>; Neeraj Malhotra <neeraj.ietf@gmail.com<mailto:neeraj.ietf@gmail.com>>
Cc: slitkows.ietf@gmail.com<mailto:slitkows.ietf@gmail.com>; bess@ietf.org<mailto:bess@ietf.org>
Subject: Re: [bess] New short WGLC for draft-ietf-bess-evpn-unequal-lb



Hi Bruno,



Thanks for your comments.



About the first point, we do have use cases where the bandwidth is not what we want to encode in the EC but rather a generalized weight that is derived from the link count, logical weight or simply a configured value. Among the co-authors we also discussed the possibility of defining two ECs: one for BW and one for a generalized-weight, so that the remote PE can catch if the multi-homed PEs were indeed using the same meaning of the weight. However, we thought it was easier/simpler to use a generalized value in a single EC sub-type, and add the sentence below.



The sentence can be modified/fixed. But the gist is that the multi-homed PEs may support multiple meanings for the weight (BW, link-count, etc), but at least one of those MUST be common across all PEs and the multi-homed routes must use it consistently. Would it be enough if we fix it?



About existing implementations, a new EVPN sub-type was defined only a couple of revisions ago, where, before, the existing non-transitive link BW EC was used, so there’s been some churn in the use of the EC anyway. I think it is important to get it as soon as possible, but get it right rather than finding gaps later once the document is done. But let us know your thoughts too.



Thank you.

Jorge





From: BESS <bess-bounces@ietf.org<mailto:bess-bounces@ietf.org>> on behalf of bruno.decraene@orange.com<mailto:bruno.decraene@orange.com> <bruno.decraene@orange.com<mailto:bruno.decraene@orange.com>>
Date: Thursday, May 6, 2021 at 10:04 AM
To: Neeraj Malhotra <neeraj.ietf@gmail.com<mailto:neeraj.ietf@gmail.com>>
Cc: slitkows.ietf@gmail.com<mailto:slitkows.ietf@gmail.com> <slitkows.ietf@gmail.com<mailto:slitkows.ietf@gmail.com>>, bess@ietf.org<mailto:bess@ietf.org> <bess@ietf.org<mailto:bess@ietf.org>>
Subject: Re: [bess] New short WGLC for draft-ietf-bess-evpn-unequal-lb

Hi Neeraj,



Thanks for considering my comments.

Much better from my perspective. Thank you.



I have two comments on the changes:

- Regarding deployments

§4.1 allows two rather incompatible encodings/usages with no way to detect which one is used: some PE could advertise the bandwidth in bytes, while some other PE could advertise a general weight. I understand that both works, but to me there is a significant risk of issues over time or between domain/SP. I’d prefer that you only chose one in order to favour consistency in deployments and usage and I would prefer the real bandwidth (at least for consistency with the name of the community, but also because this is not subjective)  (And if a SP really wants to put an arbitrary value, I think he will figure out by himself, that it can do so).

If you disagree with the above, then I would have a comment on the two below sentences:

An implementation may support one or more of the above ways of

   encoding the value.  Operator MUST ensure consistent encoding of this

   value across all PEs in an ethernet segment.

Logic dictates that the second sentence (MUST) can only be fulfilled if the first sentence mandates that all implementations MUST support both options, or one specifically defined.



- Regarding existing implementations:

previous version of the draft did not really specify the format of the EVPN EC. I had personally assumed that the format was similar to the draft-ietf-idr-link-bandwidth link bandwidth community hence encoded in IEEE floating point format. Latest version of the draft defines it in unsigned integer. Integer looks good to me, but for an existing implementation this may be seen as an incompatible change very late in the process. Obviously, if there are no implementation, there is no issue. In which case, you could also express the bandwidth in unit of bit/s _if you_ wish to. (I have no preference). However given that the draft had indicated a codepoint, there seem to be a risk of existing implementations hence incompatible change. BTW the codepoint is squatted even though the registry is FCFS hence easy to request.



Thanks,

--Bruno





From: Neeraj Malhotra [mailto:neeraj.ietf@gmail.com]
Sent: Thursday, May 6, 2021 7:41 AM
To: DECRAENE Bruno TGI/OLN <bruno.decraene@orange.com<mailto:bruno.decraene@orange.com>>
Cc: slitkows.ietf@gmail.com<mailto:slitkows.ietf@gmail.com>; bess@ietf.org<mailto:bess@ietf.org>
Subject: Re: [bess] New short WGLC for draft-ietf-bess-evpn-unequal-lb





Hi Bruno,



Many thanks for the review comments. We have revised the draft addressing your comments.



More inline.



Thanks,

Neeraj



On Mon, May 3, 2021 at 2:20 AM <bruno.decraene@orange.com<mailto:bruno.decraene@orange.com>> wrote:

Hi Stéphane, authors,



I have not followed the discussions on this document, but I’ll nonetheless raise one point  regarding the bandwidth community (better safe than sorry).

- why has [BGP-LINK-BW] been moved to informational reference while its reading seem mandatory?



[NM]: There was a leftover reference to this in one of the sections that has been fixed now to use new EVPN EC. With this, reference to [BGP-LINK-BW] is purely informational (as was intended).



- A new EVPN Link Bandwidth extended community is defined, but I could not find its specification. I guess that this is the same format as [BGP-LINK-BW] but transitive. Could this be explicitly stated?



[NM]: clarified in section 4.



- [BGP-LINK-BW] advertises the bandwidth in unit of bytes (not bits!) per second. Could the unit of the new EVPN Link Bandwidth extended community be also clearly spelled out? Especially give the history on this (cf below). Also in order to avoid misleading the readers could the examples use the correct unit (vs bits per seconds as writen)



[NM]: done.



- 10 years ago or so, I had raised a similar point (distinction between bits and bytes) on [BGP-LINK-BW] in the IDR WG. And it turned out that 1 major implementation had implemented and deployed “bytes per second” as per the spec, while another implementation had implemented and deployed “bits per second” which is the typical unit of link bandwidth. Given the deployments, none was willing to change its implementation as it would be a non-backward compatible change with themselves. What’s the status on this? Could we have an implementation status on this?



[NM]: I don't have this information. Perhaps someone else could comment.





Thanks

Regards,

--Bruno





From: BESS [mailto:bess-bounces@ietf.org<mailto:bess-bounces@ietf.org>] On Behalf Of slitkows.ietf@gmail.com<mailto:slitkows.ietf@gmail.com>
Sent: Monday, May 3, 2021 9:21 AM
To: bess@ietf.org<mailto:bess@ietf.org>
Subject: [bess] New short WGLC for draft-ietf-bess-evpn-unequal-lb



Hi WG,







We got final updates from authors on draft-ietf-bess-evpn-unequal-lb.



I'm opening a new short Working Group Last Call (to be closed on 5/10) to

get any last comments before moving to the next step.

However, the document having normative references to EVPN PREF DF, and PER-MCAST-FLOW-DF, the draft will not be sent to IESG until these drafts are ready.





Feel free to send comments to the list before next Monday.







Thanks,







Stephane



https://datatracker.ietf.org/doc/draft-ietf-bess-evpn-unequal-lb/











_________________________________________________________________________________________________________________________



Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc

pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler

a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,

Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.



This message and its attachments may contain confidential or privileged information that may be protected by law;

they should not be distributed, used or copied without authorisation.

If you have received this email in error, please notify the sender and delete this message and its attachments.

As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.

Thank you.

_______________________________________________
BESS mailing list
BESS@ietf.org<mailto:BESS@ietf.org>
https://www.ietf.org/mailman/listinfo/bess

_________________________________________________________________________________________________________________________



Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc

pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler

a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,

Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.



This message and its attachments may contain confidential or privileged information that may be protected by law;

they should not be distributed, used or copied without authorisation.

If you have received this email in error, please notify the sender and delete this message and its attachments.

As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.

Thank you.

_________________________________________________________________________________________________________________________



Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc

pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler

a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,

Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.



This message and its attachments may contain confidential or privileged information that may be protected by law;

they should not be distributed, used or copied without authorisation.

If you have received this email in error, please notify the sender and delete this message and its attachments.

As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.

Thank you.
,

_______________________________________________
BESS mailing list
BESS@ietf.org<mailto:BESS@ietf.org>
https://www.ietf.org/mailman/listinfo/bess

_________________________________________________________________________________________________________________________



Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc

pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler

a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,

Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.



This message and its attachments may contain confidential or privileged information that may be protected by law;

they should not be distributed, used or copied without authorisation.

If you have received this email in error, please notify the sender and delete this message and its attachments.

As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.

Thank you.

_________________________________________________________________________________________________________________________



Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc

pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler

a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,

Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.



This message and its attachments may contain confidential or privileged information that may be protected by law;

they should not be distributed, used or copied without authorisation.

If you have received this email in error, please notify the sender and delete this message and its attachments.

As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.

Thank you.